diff mbox

Behaviour when specifying '-g 0 -B'

Message ID 20120709130018.GD15468@paradies.suse.de (mailing list archive)
State Rejected
Delegated to: Alex Netes
Headers show

Commit Message

Philipp Thomas July 9, 2012, 1 p.m. UTC
Currently opensm will silently fail if you pass '-g0 -B'. As you can't ask
for a port, how about exiting with failure in daemonize. That way the user
would see the reason for opensm's failure.


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

Index: main.c
===================================================================
--- main.c.orig	2010-09-04 12:04:59.000000000 +0200
+++ main.c	2012-07-09 13:42:56.757934702 +0200
@@ -464,6 +464,11 @@  static int daemonize(osm_opensm_t * osm)
 	pid_t pid;
 	int fd;
 
+    if ( INVALID_GUID == opt.gui ) {
+        fputs(stderr, "opensm: Invalid GUID specified: exiting because of daemon mode");
+        return -1;
+    }
+
 	fd = open("/dev/null", O_WRONLY);
 	if (fd < 0) {
 		perror("open");