From patchwork Fri Apr 7 07:57:23 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin King X-Patchwork-Id: 9668967 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E76BD602A0 for ; Fri, 7 Apr 2017 07:57:34 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D37DA285B2 for ; Fri, 7 Apr 2017 07:57:34 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C6E35285DC; Fri, 7 Apr 2017 07:57:34 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 56D29285B2 for ; Fri, 7 Apr 2017 07:57:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754470AbdDGH5a (ORCPT ); Fri, 7 Apr 2017 03:57:30 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:43704 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753045AbdDGH53 (ORCPT ); Fri, 7 Apr 2017 03:57:29 -0400 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1cwOln-0005Ez-76; Fri, 07 Apr 2017 07:57:23 +0000 From: Colin King To: Santosh Shilimkar , "David S . Miller" , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] RDS: IB: ensure an initialized ret is printed in pr_warn message Date: Fri, 7 Apr 2017 08:57:23 +0100 Message-Id: <20170407075723.9669-1-colin.king@canonical.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Colin Ian King There is a path where ibmr is null and ret has not been initialized and hence a pr_warn message is printing an uninitialized value in ret. Fix this by initializing ret to zero. Detected by CoverityScan, CID#1357946 ("Uninitialized scalar variable") Signed-off-by: Colin Ian King --- net/rds/ib_rdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/rds/ib_rdma.c b/net/rds/ib_rdma.c index 977f69886c00..4fd637491dd5 100644 --- a/net/rds/ib_rdma.c +++ b/net/rds/ib_rdma.c @@ -542,7 +542,7 @@ void *rds_ib_get_mr(struct scatterlist *sg, unsigned long nents, struct rds_ib_device *rds_ibdev; struct rds_ib_mr *ibmr = NULL; struct rds_ib_connection *ic = rs->rs_conn->c_transport_data; - int ret; + int ret = 0; rds_ibdev = rds_ib_get_device(rs->rs_bound_addr); if (!rds_ibdev) {