| Message ID | 20171130133006.19699-1-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Jason Gunthorpe |
| Headers | show |
On Thu, Nov 30, 2017 at 01:30:06PM +0000, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The pointer reg_workq is local to the source and does not need to be > in global scope, so make it static. > > Cleans up sparse warning: > drivers/infiniband/hw/cxgb4/device.c:69:25: warning: symbol 'reg_workq' > was not declared. Should it be static? > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/infiniband/hw/cxgb4/device.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Thanks, Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
> > From: Colin Ian King <colin.king@canonical.com> > > The pointer reg_workq is local to the source and does not need to be > in global scope, so make it static. > > Cleans up sparse warning: > drivers/infiniband/hw/cxgb4/device.c:69:25: warning: symbol 'reg_workq' > was not declared. Should it be static? > > Signed-off-by: Colin Ian King <colin.king@canonical.com> Looks correct. This fixes a recent commit. Reviewed-by: Steve Wise <swise@opengridcomputing.com> Fixes: 1c8f1da5d851 ("iw_cxgb4: Fix possible circular dependency locking warning") Thanks, Steve. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Nov 30, 2017 at 01:30:06PM +0000, Colin Ian King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The pointer reg_workq is local to the source and does not need to be > in global scope, so make it static. > > Cleans up sparse warning: > drivers/infiniband/hw/cxgb4/device.c:69:25: warning: symbol 'reg_workq' > was not declared. Should it be static? > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > Reviewed-by: Leon Romanovsky <leonro@mellanox.com> > Reviewed-by: Steve Wise <swise@opengridcomputing.com> > drivers/infiniband/hw/cxgb4/device.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied to -next Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/infiniband/hw/cxgb4/device.c b/drivers/infiniband/hw/cxgb4/device.c index af77d128d242..91cbe3aae32e 100644 --- a/drivers/infiniband/hw/cxgb4/device.c +++ b/drivers/infiniband/hw/cxgb4/device.c @@ -66,7 +66,7 @@ MODULE_PARM_DESC(c4iw_wr_log_size_order, static LIST_HEAD(uld_ctx_list); static DEFINE_MUTEX(dev_mutex); -struct workqueue_struct *reg_workq; +static struct workqueue_struct *reg_workq; #define DB_FC_RESUME_SIZE 64 #define DB_FC_RESUME_DELAY 1