From patchwork Fri Jan 12 18:08:24 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Gunthorpe X-Patchwork-Id: 10161553 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A0FC6602D8 for ; Fri, 12 Jan 2018 18:08:44 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 960E1286D2 for ; Fri, 12 Jan 2018 18:08:44 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8A98D28770; Fri, 12 Jan 2018 18:08:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 344CB28761 for ; Fri, 12 Jan 2018 18:08:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933451AbeALSIl (ORCPT ); Fri, 12 Jan 2018 13:08:41 -0500 Received: from mail-wr0-f181.google.com ([209.85.128.181]:41790 "EHLO mail-wr0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964970AbeALSIg (ORCPT ); Fri, 12 Jan 2018 13:08:36 -0500 Received: by mail-wr0-f181.google.com with SMTP id o7so6030677wro.8 for ; Fri, 12 Jan 2018 10:08:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=0BovzQXFLAlNi8LaMgyPvYKbNq8PZyaN7kWcJeULJMc=; b=BJxf/UNMyews8aEllQPd+q0i0rfcZbihFwbdRPnXBht4px6p0pOa7qPXlegcPv+fM1 PohGtKtfONk7f4Bj/hExI3/oxQD/qs1+vcKd0KkKY3tjxWP79rxXNLfFJC7ZABTXhKDG r4rgwmfqGstjjMVBcjv9v3rm1AL7B2NfYrTMpc2s4McPDwROlkMEsszRZA37HpCawrgP VqwwJ8ll/Tu9PtOvVOmvjvUcLu6bKi7Wlac5vFg+PQOig42Dx2Ha1qsW/rZx6+qWzjjt LUQ7LLBW0s093Ji+9fUmACbrUR+sQtY/02JorUDrfhKse+owrpw8HOSUotoqWpgr9Zul 7F+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=0BovzQXFLAlNi8LaMgyPvYKbNq8PZyaN7kWcJeULJMc=; b=LhAKOHS4puidw2LHFo8Zmuvvqlrvn821ucFtYu1pzpEe8nSwmj4fTbVAj/lGqbc42I Kmao4fadC2zPLw/qTd+7H8MGLeE/Dyk9x8UvUPYkSly8WC4whRXLTmSZMtaPpd5Ju2Ws +mJXOTpP4l7s+1jBGLbPNM6FAOeFveC7vEMJ2PBwacP6v0diCU/EpHs1g0ddEZh49xSx f925c2jTHWsSM99LEZXzI2qehRI3ATE6pQACpj0xmZHDQASvKugqSObA/5+B0OBo+k4v QzbKnCjEJtCYu7+zxHhnlwf9WJkcergJizP6XXJOjX/Xv/5FIeRCoVU0jRyf7ctCF3XT hMHg== X-Gm-Message-State: AKGB3mIIYdKwW84ph1vID+w+FSDd/E1NRb6tL5r0DYG4adAQxZi+NLX0 bPnsHjF9lTV41GNRnrCrLNJBLw== X-Google-Smtp-Source: ACJfBou0T+HBS+1bypSnWqQaDrP6wJpB4OzUSH1vDCV596VnaGjAZ2v/2TKlq1Uc+hflJaH/whTVFA== X-Received: by 10.223.141.206 with SMTP id o72mr16685392wrb.0.1515780514691; Fri, 12 Jan 2018 10:08:34 -0800 (PST) Received: from ziepe.ca (S010614cc2056d97f.ed.shawcable.net. [70.74.179.152]) by smtp.gmail.com with ESMTPSA id h4sm21316964wrh.40.2018.01.12.10.08.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 12 Jan 2018 10:08:33 -0800 (PST) Received: from jgg by mlx.ziepe.ca with local (Exim 4.86_2) (envelope-from ) id 1ea3ke-0007QW-UX; Fri, 12 Jan 2018 11:08:24 -0700 Date: Fri, 12 Jan 2018 11:08:24 -0700 From: Jason Gunthorpe To: Kevin Wilson Cc: linux-rdma@vger.kernel.org Subject: Re: Building rdma-core from github gave an error "Unknown arguments specified" Message-ID: <20180112180824.GE15974@ziepe.ca> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Fri, Jan 12, 2018 at 11:35:04AM +0200, Kevin Wilson wrote: > Hi, > I had cloned the latest rdma-core: > https://github.com/linux-rdma/rdma-core.git > > I am trying to build it on Fedora 27 x86_64 machine. > When I ran: > bash build.sh > I got the following: > > CMake Error at buildlib/RDMA_BuildType.cmake:32 (if): > if given arguments: > > "STREQUAL" "-O2 -g -DNDEBUG" > > Unknown arguments specified > Call Stack (most recent call first): > CMakeLists.txt:145 (RDMA_BuildType) No idea.. Can't reproduce. I wonder if some quotes are missing: --- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/buildlib/RDMA_BuildType.cmake b/buildlib/RDMA_BuildType.cmake index 0951edadeebf61..ea2bbf8e639c2f 100644 --- a/buildlib/RDMA_BuildType.cmake +++ b/buildlib/RDMA_BuildType.cmake @@ -29,7 +29,7 @@ function(RDMA_BuildType) # with the -DNDEBUG removed foreach (language CXX C) set(VAR_TO_MODIFY "CMAKE_${language}_FLAGS_RELWITHDEBINFO") - if (${${VAR_TO_MODIFY}} STREQUAL ${${VAR_TO_MODIFY}_INIT}) + if ("${${VAR_TO_MODIFY}}" STREQUAL ${${VAR_TO_MODIFY}_INIT}) string(REGEX REPLACE "(^| )[/-]D *NDEBUG($| )" " " replacement