| Message ID | 20180311170340.27696-1-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
On (03/11/18 18:03), Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > Functions rds_info_from_znotifier and rds_message_zcopy_from_user are > local to the source and do not need to be in global scope, so make them > static. the rds_message_zcopy_from_user warning was already flagged by kbuild-robot last week. See https://www.spinics.net/lists/netdev/msg488041.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 3/11/18 10:03 AM, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > Functions rds_info_from_znotifier and rds_message_zcopy_from_user are > local to the source and do not need to be in global scope, so make them > static. > > Cleans up sparse warnins: > net/rds/message.c:70:27: warning: symbol 'rds_info_from_znotifier' was > not declared. Should it be static? > net/rds/message.c:358:5: warning: symbol 'rds_message_zcopy_from_user' > was not declared. Should it be static? > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > net/rds/message.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com> -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 3/11/18 11:54 PM, santosh.shilimkar@oracle.com wrote: > On 3/11/18 10:03 AM, Colin King wrote: >> From: Colin Ian King <colin.king@canonical.com> >> >> Functions rds_info_from_znotifier and rds_message_zcopy_from_user are >> local to the source and do not need to be in global scope, so make them >> static. >> >> Cleans up sparse warnins: >> net/rds/message.c:70:27: warning: symbol 'rds_info_from_znotifier' was >> not declared. Should it be static? >> net/rds/message.c:358:5: warning: symbol 'rds_message_zcopy_from_user' >> was not declared. Should it be static? >> >> Signed-off-by: Colin Ian King <colin.king@canonical.com> >> --- >> net/rds/message.c | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> > Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com> This was fixed by kbuild robot and the fix is already in net-next. Regards, Santosh -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/rds/message.c b/net/rds/message.c index 9c41bdd9e444..7448fa192543 100644 --- a/net/rds/message.c +++ b/net/rds/message.c @@ -67,7 +67,8 @@ static inline bool rds_zcookie_add(struct rds_msg_zcopy_info *info, u32 cookie) return true; } -struct rds_msg_zcopy_info *rds_info_from_znotifier(struct rds_znotifier *znotif) +static struct rds_msg_zcopy_info * +rds_info_from_znotifier(struct rds_znotifier *znotif) { return container_of(znotif, struct rds_msg_zcopy_info, znotif); } @@ -355,7 +356,8 @@ struct rds_message *rds_message_map_pages(unsigned long *page_addrs, unsigned in return rm; } -int rds_message_zcopy_from_user(struct rds_message *rm, struct iov_iter *from) +static int rds_message_zcopy_from_user(struct rds_message *rm, + struct iov_iter *from) { struct scatterlist *sg; int ret = 0;