From patchwork Tue Mar 13 22:33:17 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Gunthorpe X-Patchwork-Id: 10281075 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 78CF160231 for ; Tue, 13 Mar 2018 22:33:36 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5A7082857F for ; Tue, 13 Mar 2018 22:33:36 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4DAC528587; Tue, 13 Mar 2018 22:33:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A68CA2857F for ; Tue, 13 Mar 2018 22:33:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752054AbeCMWde (ORCPT ); Tue, 13 Mar 2018 18:33:34 -0400 Received: from mail-pg0-f65.google.com ([74.125.83.65]:41820 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751300AbeCMWdd (ORCPT ); Tue, 13 Mar 2018 18:33:33 -0400 Received: by mail-pg0-f65.google.com with SMTP id w17so508944pgq.8 for ; Tue, 13 Mar 2018 15:33:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=J0l2nWjjwmW0FKQIRhb5pfIrMyHAbOwCtxx7Nejj+XY=; b=ZsZdYfmEZFWStKPPZ6Ql7apwqErbZizNAQ4A8ddGDWP00AOlENT30ebx3a/pHXF1Tm lGT+yh36Kc9SVcmpHqdE0iQVnFvyXGyLYBgK9NHKVzmuLyEZtn/KbVS8spPiRIfarW5V APs+F+t0gGEqbCtu+sDv3YkADb9MsKKDmE0PIBDAQ79pSvDoN69b9m0ftMdY/P8ezVzg f2zKJg5DP74ASwue8qWkyJFp2CUT43raAT+WjVMz8xTpcETKCl4Jkq3ZnVduT5kCQC5+ cpIZ/JPA0kbZkjrBkTsYssr0SNPCoTfJlChwdVQWoBwJ+hvzxkP8v9qwiGvfpHiLaLTS 7T3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=J0l2nWjjwmW0FKQIRhb5pfIrMyHAbOwCtxx7Nejj+XY=; b=UIwDUrhmmBKWONh0WhiPJMzsrPNwksgi23NfMEBLiz+8uik1qiBnJRp1uqyQZYWLHQ y3V9hyoPDs8mLJ4GtV3KUvVCkVWqD5KDYp8YvRHW/J7cYB+Nw30L80yM7ErVZIgtjiaM 4Ig/oLpd8NMg2iu5lLJpPxc68Gz+2pyK/Q08nMku1P2/cgD0F2/GCmJX0GFGKEgKUjSz dMLlquR5HVvoelDn/gU6GTw+vYBbvE+TG+I2iX4xERKPFD5q60bEAhlBhv0LrbRtjeEU Zo+vj5X94C6aPGIrVrS7PeGi3nql2K72D3M2VcNpt6LbH4OlFZBlLeCLypbH9qIfcS02 VrwQ== X-Gm-Message-State: AElRT7ECDXtOWCIoyY1galELmUWxsNHcOUJ+BbIdDvrM5GlMcaq9ny4e V+xOv6BE6AK+OBhwha4L8ougiEcHU18= X-Google-Smtp-Source: AG47ELsktcYOGLWPbfjC/7csYewk7hs82tD6TdMkBKnEWwjzZwZhVB1W8HggE8BW9U1Ar7AdTe99Uw== X-Received: by 10.99.169.10 with SMTP id u10mr1785971pge.163.1520980413044; Tue, 13 Mar 2018 15:33:33 -0700 (PDT) Received: from ziepe.ca (S010614cc2056d97f.ed.shawcable.net. [174.3.196.123]) by smtp.gmail.com with ESMTPSA id t128sm1734500pgb.50.2018.03.13.15.33.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Mar 2018 15:33:32 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.86_2) (envelope-from ) id 1evsU7-0002wC-GS; Tue, 13 Mar 2018 16:33:31 -0600 From: Jason Gunthorpe To: linux-rdma@vger.kernel.org Cc: Yuval Shaia , Moni Shoua , Jason Gunthorpe Subject: [PATCH 1/2] RDMA/rxe: Get rid of confusing udata parameter to rxe_cq_chk_attr Date: Tue, 13 Mar 2018 16:33:17 -0600 Message-Id: <20180313223318.11151-2-jgg@ziepe.ca> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180313223318.11151-1-jgg@ziepe.ca> References: <20180313223318.11151-1-jgg@ziepe.ca> Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Jason Gunthorpe It isn't used and it couldn't possibly ever be used correctly. Signed-off-by: Jason Gunthorpe --- drivers/infiniband/sw/rxe/rxe_cq.c | 2 +- drivers/infiniband/sw/rxe/rxe_loc.h | 2 +- drivers/infiniband/sw/rxe/rxe_verbs.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/sw/rxe/rxe_cq.c b/drivers/infiniband/sw/rxe/rxe_cq.c index c4aabf78dc90f5..c9593e47275363 100644 --- a/drivers/infiniband/sw/rxe/rxe_cq.c +++ b/drivers/infiniband/sw/rxe/rxe_cq.c @@ -36,7 +36,7 @@ #include "rxe_queue.h" int rxe_cq_chk_attr(struct rxe_dev *rxe, struct rxe_cq *cq, - int cqe, int comp_vector, struct ib_udata *udata) + int cqe, int comp_vector) { int count; diff --git a/drivers/infiniband/sw/rxe/rxe_loc.h b/drivers/infiniband/sw/rxe/rxe_loc.h index e8150ab7df58d1..31070a696f3613 100644 --- a/drivers/infiniband/sw/rxe/rxe_loc.h +++ b/drivers/infiniband/sw/rxe/rxe_loc.h @@ -52,7 +52,7 @@ struct rxe_av *rxe_get_av(struct rxe_pkt_info *pkt); /* rxe_cq.c */ int rxe_cq_chk_attr(struct rxe_dev *rxe, struct rxe_cq *cq, - int cqe, int comp_vector, struct ib_udata *udata); + int cqe, int comp_vector); int rxe_cq_from_init(struct rxe_dev *rxe, struct rxe_cq *cq, int cqe, int comp_vector, struct ib_ucontext *context, diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.c b/drivers/infiniband/sw/rxe/rxe_verbs.c index 45594091353c01..34539c3242a8c3 100644 --- a/drivers/infiniband/sw/rxe/rxe_verbs.c +++ b/drivers/infiniband/sw/rxe/rxe_verbs.c @@ -892,7 +892,7 @@ static struct ib_cq *rxe_create_cq(struct ib_device *dev, if (attr->flags) return ERR_PTR(-EINVAL); - err = rxe_cq_chk_attr(rxe, NULL, attr->cqe, attr->comp_vector, udata); + err = rxe_cq_chk_attr(rxe, NULL, attr->cqe, attr->comp_vector); if (err) goto err1; @@ -931,7 +931,7 @@ static int rxe_resize_cq(struct ib_cq *ibcq, int cqe, struct ib_udata *udata) struct rxe_cq *cq = to_rcq(ibcq); struct rxe_dev *rxe = to_rdev(ibcq->device); - err = rxe_cq_chk_attr(rxe, cq, cqe, 0, udata); + err = rxe_cq_chk_attr(rxe, cq, cqe, 0); if (err) goto err1;