From patchwork Tue Mar 20 20:19:49 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Gunthorpe X-Patchwork-Id: 10297821 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 68A61600F6 for ; Tue, 20 Mar 2018 20:20:22 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 57D6628C5E for ; Tue, 20 Mar 2018 20:20:22 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 485772962D; Tue, 20 Mar 2018 20:20:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0C2C528C5E for ; Tue, 20 Mar 2018 20:20:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751408AbeCTUUP (ORCPT ); Tue, 20 Mar 2018 16:20:15 -0400 Received: from mail-wr0-f195.google.com ([209.85.128.195]:36565 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751317AbeCTUUO (ORCPT ); Tue, 20 Mar 2018 16:20:14 -0400 Received: by mail-wr0-f195.google.com with SMTP id d10so3033317wrf.3 for ; Tue, 20 Mar 2018 13:20:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=6h4hNsDiwqNwSyGPeDyAOdPllBHh/KXcvIo0KDWv7ec=; b=HDMKQFJN3cktT1CRNfJVHZPVAXVnBtqDiP2NQX/pkm3K2gDayonbDJQ/RbC9jZ8pLV D5pxnxNxvFqdpHriX7rA3Tq85xz4Mfn1/1/uvsNBINLidUICo4dREGj2k4/AR+HnIQDB Am6tA/HLkZ27dT71uBR1PBIdcP8j9wvj3p30YpTdV8pqb0BcKKLb1CgiKqn/o7ICy3cZ DLcuSjo9CDcAyMfJNw9kCpDxXE6UoYjtYefyzjBMMjqx7f/asR2wwgO4XxmM5dtYtcG8 TLLjrXa4X7RmbfpWdtXgAyExnN0yfQfnYijPQqXe6/ftvepLLO1IpQ1dDI4w+AGJaY8O 6ihw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=6h4hNsDiwqNwSyGPeDyAOdPllBHh/KXcvIo0KDWv7ec=; b=Zri4LQeg7lsJE1lb/fT+AfD2COZV4WDwOVlD+CZ5L8vTXc8n0q/2F56pkXUcHUHWws J+miCvx5xuUV4bf05NcuR6SDIDN3lNzZL6DikUjE0/uDjdxQtYzxqNw3HInD3KzeuMNJ luGN5xaBQ9M1Dwt643i5PVnbW3CiRFf96KMj2TebP1LAgkC5HuzXUdjQdBt3RScBNOtX ZcF0ydqBkf3IBLOvyIw/e0TBLxBU4qkLj+sJikjL3fKLr+WR+opIrSSsp+Ep/9s9poIa P2Bl07RDx4aE2jr6BgZreZwPDEB9Mr8bVhbrXq9H3lnJOl+T8izNSeL9HXc83h2fTItc sRTQ== X-Gm-Message-State: AElRT7EeIEVmNJNcUrDAPnGeDmVpxeQgy1z0ROooqSkjMTx3gdSZg/Ci JT1uMuKJo9vLZVWF6ImE7lxOTXawHTk= X-Google-Smtp-Source: AG47ELuqQJA87R6M87LyHhfjEHyQxf8ZZvxLNyx2JKNt/X7dWcj7meCsFmYjiX+rtqWFY046gJVxCw== X-Received: by 10.223.161.135 with SMTP id u7mr9888452wru.184.1521577213208; Tue, 20 Mar 2018 13:20:13 -0700 (PDT) Received: from ziepe.ca (S010614cc2056d97f.ed.shawcable.net. [174.3.196.123]) by smtp.gmail.com with ESMTPSA id q21sm2438560wra.24.2018.03.20.13.20.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Mar 2018 13:20:12 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.86_2) (envelope-from ) id 1eyNjt-0001Nk-SR; Tue, 20 Mar 2018 14:20:09 -0600 From: Jason Gunthorpe To: linux-rdma@vger.kernel.org, Yishai Hadas Cc: Jason Gunthorpe Subject: [PATCH 4/6] RDMA/mlx4: Fix uABI structure layouts for 32/64 compat Date: Tue, 20 Mar 2018 14:19:49 -0600 Message-Id: <20180320201951.4998-5-jgg@ziepe.ca> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180320201951.4998-1-jgg@ziepe.ca> References: <20180320201951.4998-1-jgg@ziepe.ca> Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Jason Gunthorpe rss_caps in struct mlx4_uverbs_ex_query_device_resp is misaligned on 32 bit compared to 64 bit, add explicit padding. The rss caps were introduced recently and are very rarely used in user space, mainly for DPDK. We don't expect there to be a real 32 bit user, so this change is done without compat considerations. Fixes: 09d208b258a2 ("IB/mlx4: Add report for RSS capabilities by vendor channel") Signed-off-by: Jason Gunthorpe --- include/uapi/rdma/mlx4-abi.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi/rdma/mlx4-abi.h b/include/uapi/rdma/mlx4-abi.h index a448abd070526e..50a56aeb1f4179 100644 --- a/include/uapi/rdma/mlx4-abi.h +++ b/include/uapi/rdma/mlx4-abi.h @@ -183,6 +183,7 @@ struct mlx4_uverbs_ex_query_device_resp { __u32 response_length; __u64 hca_core_clock_offset; __u32 max_inl_recv_sz; + __u32 reserved; struct mlx4_ib_rss_caps rss_caps; struct mlx4_ib_tso_caps tso_caps; };