From patchwork Mon Aug 27 06:42:32 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Honggang LI X-Patchwork-Id: 10576411 X-Patchwork-Delegate: hal@mellanox.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id DE9EC15A7 for ; Mon, 27 Aug 2018 06:43:02 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D275B29720 for ; Mon, 27 Aug 2018 06:43:02 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C472E2971F; Mon, 27 Aug 2018 06:43:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 74AD22971F for ; Mon, 27 Aug 2018 06:43:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727085AbeH0K2S (ORCPT ); Mon, 27 Aug 2018 06:28:18 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:46752 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726874AbeH0K2S (ORCPT ); Mon, 27 Aug 2018 06:28:18 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D628683221; Mon, 27 Aug 2018 06:43:00 +0000 (UTC) Received: from lhg.nay.redhat.com (unknown [10.66.129.124]) by smtp.corp.redhat.com (Postfix) with ESMTP id 431682166B41; Mon, 27 Aug 2018 06:42:58 +0000 (UTC) From: Honggang LI To: hal@dev.mellanox.co.il Cc: linux-rdma@vger.kernel.org, Honggang Li Subject: [PATCH 4/5] osm_qos_parser_y.y: fix resource leak Date: Mon, 27 Aug 2018 14:42:32 +0800 Message-Id: <20180827064233.3218-4-honli@redhat.com> In-Reply-To: <20180827064233.3218-3-honli@redhat.com> References: <20180827064233.3218-1-honli@redhat.com> <20180827064233.3218-2-honli@redhat.com> <20180827064233.3218-3-honli@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Mon, 27 Aug 2018 06:43:00 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Mon, 27 Aug 2018 06:43:00 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'honli@redhat.com' RCPT:'' Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Honggang Li Issue was found by Coverity. Error: RESOURCE_LEAK (CWE-772): [#def11] opensm-3.3.20/opensm/osm_qos_parser_y.y:996: alloc_fn: Storage is returned from allocation function "malloc". opensm-3.3.20/opensm/osm_qos_parser_y.y:996: var_assign: Assigning: "range_arr" = storage returned from "malloc(8UL)". opensm-3.3.20/opensm/osm_qos_parser_y.y:1006: noescape: Resource "range_arr" is not freed or pointed-to in "__validate_pkeys". opensm-3.3.20/opensm/osm_qos_parser_y.y:3111:42: noescape: "__validate_pkeys(uint64_t **, unsigned int, boolean_t)" does not free or save its parameter "range_arr". opensm-3.3.20/opensm/osm_qos_parser_y.y:1007: leaked_storage: Variable "range_arr" going out of scope leaks the storage it points to. |# 1005| */ |# 1006| if (__validate_pkeys(range_arr, 1, TRUE)) |# 1007|-> return 1; |# 1008| |# 1009| p_current_qos_match_rule->pkey_range_arr = range_arr; Signed-off-by: Honggang Li --- opensm/osm_qos_parser_y.y | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/opensm/osm_qos_parser_y.y b/opensm/osm_qos_parser_y.y index e0f6580c..12466956 100644 --- a/opensm/osm_qos_parser_y.y +++ b/opensm/osm_qos_parser_y.y @@ -1003,8 +1003,11 @@ qos_ulp: TK_ULP_DEFAULT single_number { * we still need to validate it by checking that it has * at least two full members. Otherwise IPoIB won't work. */ - if (__validate_pkeys(range_arr, 1, TRUE)) + if (__validate_pkeys(range_arr, 1, TRUE)) { + free(range_arr[0]); + free(range_arr); return 1; + } p_current_qos_match_rule->pkey_range_arr = range_arr; p_current_qos_match_rule->pkey_range_len = 1;