From patchwork Thu Nov 15 04:56:48 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kamal Heib X-Patchwork-Id: 10683505 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E6FFD14D6 for ; Thu, 15 Nov 2018 04:57:09 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C5EAC2C202 for ; Thu, 15 Nov 2018 04:57:09 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B31A92C211; Thu, 15 Nov 2018 04:57:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 852C82C202 for ; Thu, 15 Nov 2018 04:57:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726821AbeKOPDX (ORCPT ); Thu, 15 Nov 2018 10:03:23 -0500 Received: from mail-pl1-f195.google.com ([209.85.214.195]:44889 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726689AbeKOPDX (ORCPT ); Thu, 15 Nov 2018 10:03:23 -0500 Received: by mail-pl1-f195.google.com with SMTP id s5-v6so8871327plq.11 for ; Wed, 14 Nov 2018 20:57:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=UiOntr4Yh4w8x37F39fLF4nhm1hZq0wMrZ/fC6B1CJQ=; b=KAleO5OgLwsnvI/cT0VBUG/XCanD50t+3vX5g8jG5h98W36YvJb4fSAnwgqsFHVN4k ce43UOUYia7hHZ+wGTI9E1h+T+osUBrvXMR65nMTmdkkLxLtWk/9GYda8eas1Zz6trAC sbgv1LHJrU0YyBEctaPNGJCmaR25SkDbQkn+ZlASyDjlz43WZxDl5Kro4UjDwwF9d+pR atkB7nTaJuiMuzk7CBkesqaLI36akRD+EirKv5FGmFRwU9iebdLT22XlzqWSqDPhcWu6 18nkLi7Xh1sn4KWlKZ1z0scsvzKL1Kzjc3HcEAUpoZrdPzsqVMEmjxzW4c8cL6g2bF9s AFnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=UiOntr4Yh4w8x37F39fLF4nhm1hZq0wMrZ/fC6B1CJQ=; b=PL39yC4+Wv6OUC4tmqh1Yu4NhgU/qsg7rszFYmLpLKhI91ThwGuPjdIA3irwPhDcn8 ptGEIuypGLKWBqDCbO8fTfNQEVmMhAos6mHy6Zznnxz6TvC+71RVhga1Damm/uYN+igb H6kCGB1j8tpKJu7/dVqkOeohY5ekLrja/HRVACt8kjd6L2bgbeu8+zhHNhZxdEaZ2l77 abeYdp49IulLY8dVGKD5keBYXJkaEN9zn1JMx9Z1UfErk1scPhj12HfNdM+pYGpH8yxe NgyT3y0RpHpiJTCdHIp9qFVYJNiKDsHGfBI8GqTf4FKI+/f3gpQynsx/CkkrbfbaJ5AX j8Lw== X-Gm-Message-State: AGRZ1gI6R3x0Ce6R98Hf0ow3EI4354ENsz/6/1IJH8BJ9nz9fAuwc4Oq HOmCcGBzcen0/PMi+phJOUY= X-Google-Smtp-Source: AJdET5dy8QmsFFbfd6VR7U+gl+d6PCgawHf6H5eEf17PENaOZ6UeoXvfNhJYsOt2zUw3isCNhfNTaQ== X-Received: by 2002:a17:902:e290:: with SMTP id cf16mr1070502plb.81.1542257826125; Wed, 14 Nov 2018 20:57:06 -0800 (PST) Received: from localhost.localdomain (S0106e0cbbc9b8b21.vc.shawcable.net. [24.80.201.149]) by smtp.gmail.com with ESMTPSA id 85sm22749195pfw.17.2018.11.14.20.57.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 14 Nov 2018 20:57:05 -0800 (PST) From: Kamal Heib To: Doug Ledford , Jason Gunthorpe Cc: linux-rdma@vger.kernel.org, Kamal Heib Subject: [PATCH rdma-next] RDMA/rdmavt: Fix rvt_create_ah prototype Date: Wed, 14 Nov 2018 20:56:48 -0800 Message-Id: <20181115045648.7810-1-kamalheib1@gmail.com> X-Mailer: git-send-email 2.14.5 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch fixes the wrong assignment of the create_ah function pointer, the create_ah verb receive three parameters while the rvt_create_ah receives two parameters, this happens due to the wrong function casting that is done in check_driver_override(). Signed-off-by: Kamal Heib --- drivers/infiniband/sw/rdmavt/ah.c | 4 +++- drivers/infiniband/sw/rdmavt/ah.h | 3 ++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/sw/rdmavt/ah.c b/drivers/infiniband/sw/rdmavt/ah.c index 89ec0f64abfc..084bb4baebb5 100644 --- a/drivers/infiniband/sw/rdmavt/ah.c +++ b/drivers/infiniband/sw/rdmavt/ah.c @@ -91,13 +91,15 @@ EXPORT_SYMBOL(rvt_check_ah); * rvt_create_ah - create an address handle * @pd: the protection domain * @ah_attr: the attributes of the AH + * @udata: pointer to user's input output buffer information. * * This may be called from interrupt context. * * Return: newly allocated ah */ struct ib_ah *rvt_create_ah(struct ib_pd *pd, - struct rdma_ah_attr *ah_attr) + struct rdma_ah_attr *ah_attr, + struct ib_udata *udata) { struct rvt_ah *ah; struct rvt_dev_info *dev = ib_to_rvt(pd->device); diff --git a/drivers/infiniband/sw/rdmavt/ah.h b/drivers/infiniband/sw/rdmavt/ah.h index 16105af99189..25271b48a683 100644 --- a/drivers/infiniband/sw/rdmavt/ah.h +++ b/drivers/infiniband/sw/rdmavt/ah.h @@ -51,7 +51,8 @@ #include struct ib_ah *rvt_create_ah(struct ib_pd *pd, - struct rdma_ah_attr *ah_attr); + struct rdma_ah_attr *ah_attr, + struct ib_udata *udata); int rvt_destroy_ah(struct ib_ah *ibah); int rvt_modify_ah(struct ib_ah *ibah, struct rdma_ah_attr *ah_attr); int rvt_query_ah(struct ib_ah *ibah, struct rdma_ah_attr *ah_attr);