From patchwork Mon Dec 10 19:09:29 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kamal Heib X-Patchwork-Id: 10722251 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5AEDE3E9D for ; Mon, 10 Dec 2018 19:10:23 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4BB002A795 for ; Mon, 10 Dec 2018 19:10:23 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 403482A7EE; Mon, 10 Dec 2018 19:10:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_WEB autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CB7272A87C for ; Mon, 10 Dec 2018 19:10:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727156AbeLJTKW (ORCPT ); Mon, 10 Dec 2018 14:10:22 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:38761 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727246AbeLJTKW (ORCPT ); Mon, 10 Dec 2018 14:10:22 -0500 Received: by mail-wm1-f66.google.com with SMTP id m22so12524236wml.3 for ; Mon, 10 Dec 2018 11:10:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=s9J1l5oOpqn7dFBXHSsD50YArQwa6t/Llsi3XlzmWtY=; b=jerwMa4bMAeZt0eYpQurwkXy+Nnpdw+9E4wqne7xBm3XaurdOoefBH6gXaqrH2U9Zp V8RMWlb2jctSu5VgZunnKJxObcLuUVe5D1OO/BiO5CBYBHVsg5z07d3DIf8GYAfv8dQd 1o5cAjhXV2nu0pFhzQwC3XUEb1yaPAfnFRPyVevf82QSpWLGaO51R6oj6Ivu+9XXaoH4 7ZsD30IvqzQr2DryUOKI5Y4eNWfCuNq/gKF/5yq1ZTJIWBRl9RlTIBumHhSw5ftb91sV QgopcQg0juMsrHPe7jjFfd/WYDI7tL3hOc8JJAd6LOgY0MR1whsaQW/8iGAWcYNMaM9H AuGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=s9J1l5oOpqn7dFBXHSsD50YArQwa6t/Llsi3XlzmWtY=; b=shOzY6D4SBZZmFG16ZhLkvJzgUR8ebApkF78fCrAMWxDgAaNh0kL0xVsMSx73VliaI CVp117f/OtHb76T2bdsOwg2YEVY94E1hzqxRU9TjzZw746TqhPmvWl2Qvk4q9oStIMBT fN8IqxGscKlMRqrz+Eeap15kXMefRLVpKsq22Ut18cL2p9+cnp05b+oqwLs5rwUB3/Ug JBpeM/o3W7Ge57mPTAK6IxCWoHHDZmYCtx4GsLYh2qqiyeb2Ttz/9TK5KOh8MpuWGq+f 62sat4cSnx9WQ8Pg4yoIgwMzDyZjcsxJJzIx1zDu21bszgNv1SyXiy++ZMr81gCb5s2T wVvA== X-Gm-Message-State: AA+aEWYSwvzVXGiJUo69bGb/JZK0MsqD+EltSu4ClsxGWlGMJxF5dmTT HFMHuJFS9JE1lHxPW2OnevfzhPDp X-Google-Smtp-Source: AFSGD/WnXaL5UsGxMOxglGhHddAcP2g+nbo/NX5+b9pUGDzFjBDFS6aHLy2jS6bdibfek+YsikY5mA== X-Received: by 2002:a1c:4855:: with SMTP id v82mr6615410wma.15.1544469019846; Mon, 10 Dec 2018 11:10:19 -0800 (PST) Received: from kheib-workstation.redhat.com (bzq-109-64-38-215.red.bezeqint.net. [109.64.38.215]) by smtp.gmail.com with ESMTPSA id o5sm33847657wmg.25.2018.12.10.11.10.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 10 Dec 2018 11:10:19 -0800 (PST) From: Kamal Heib To: Doug Ledford , Jason Gunthorpe Cc: linux-rdma@vger.kernel.org, kamalheib1@gmail.com, Jason Gunthorpe Subject: [PATCH rdma-next v5 01/20] RDMA/rdmavt: Fix rvt_create_ah function signature Date: Mon, 10 Dec 2018 21:09:29 +0200 Message-Id: <20181210190948.6892-2-kamalheib1@gmail.com> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20181210190948.6892-1-kamalheib1@gmail.com> References: <20181210190948.6892-1-kamalheib1@gmail.com> MIME-Version: 1.0 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP rdmavt uses a crazy system that looses the type checking when assinging functions to struct ib_device function pointers. Because of this the signature to this function was not changed when the below commit revised things. Fix the signature so we are not calling a function pointer with a mismatched signature. Fixes: 477864c8fcd9 ("IB/core: Let create_ah return extended response to user") Signed-off-by: Kamal Heib Reviewed-by: Dennis Dalessandro Signed-off-by: Jason Gunthorpe --- drivers/infiniband/sw/rdmavt/ah.c | 4 +++- drivers/infiniband/sw/rdmavt/ah.h | 3 ++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/sw/rdmavt/ah.c b/drivers/infiniband/sw/rdmavt/ah.c index 89ec0f64abfc..084bb4baebb5 100644 --- a/drivers/infiniband/sw/rdmavt/ah.c +++ b/drivers/infiniband/sw/rdmavt/ah.c @@ -91,13 +91,15 @@ EXPORT_SYMBOL(rvt_check_ah); * rvt_create_ah - create an address handle * @pd: the protection domain * @ah_attr: the attributes of the AH + * @udata: pointer to user's input output buffer information. * * This may be called from interrupt context. * * Return: newly allocated ah */ struct ib_ah *rvt_create_ah(struct ib_pd *pd, - struct rdma_ah_attr *ah_attr) + struct rdma_ah_attr *ah_attr, + struct ib_udata *udata) { struct rvt_ah *ah; struct rvt_dev_info *dev = ib_to_rvt(pd->device); diff --git a/drivers/infiniband/sw/rdmavt/ah.h b/drivers/infiniband/sw/rdmavt/ah.h index 16105af99189..25271b48a683 100644 --- a/drivers/infiniband/sw/rdmavt/ah.h +++ b/drivers/infiniband/sw/rdmavt/ah.h @@ -51,7 +51,8 @@ #include struct ib_ah *rvt_create_ah(struct ib_pd *pd, - struct rdma_ah_attr *ah_attr); + struct rdma_ah_attr *ah_attr, + struct ib_udata *udata); int rvt_destroy_ah(struct ib_ah *ibah); int rvt_modify_ah(struct ib_ah *ibah, struct rdma_ah_attr *ah_attr); int rvt_query_ah(struct ib_ah *ibah, struct rdma_ah_attr *ah_attr);