From patchwork Wed Jan 2 13:13:09 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Honggang LI X-Patchwork-Id: 10746349 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4B970746 for ; Wed, 2 Jan 2019 13:14:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3B14428848 for ; Wed, 2 Jan 2019 13:14:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2FA9928857; Wed, 2 Jan 2019 13:14:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E2C5228848 for ; Wed, 2 Jan 2019 13:14:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729911AbfABNOc (ORCPT ); Wed, 2 Jan 2019 08:14:32 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42974 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729909AbfABNOc (ORCPT ); Wed, 2 Jan 2019 08:14:32 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 733732D2BD3; Wed, 2 Jan 2019 13:14:32 +0000 (UTC) Received: from localhost (ovpn-12-97.pek2.redhat.com [10.72.12.97]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B034660C66; Wed, 2 Jan 2019 13:14:31 +0000 (UTC) From: Honggang Li To: hal@dev.mellanox.co.il Cc: linux-rdma@vger.kernel.org, Honggang Li Subject: [ibsim patch 14/23] sim_mad.c: Fix NO_EFFECT issue for do_linearforwtbl Date: Wed, 2 Jan 2019 21:13:09 +0800 Message-Id: <20190102131318.5765-14-honli@redhat.com> In-Reply-To: <20190102131318.5765-1-honli@redhat.com> References: <20190102131318.5765-1-honli@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Wed, 02 Jan 2019 13:14:32 +0000 (UTC) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Issue was detected by Coverity. This less-than-zero comparison of an unsigned value is never true. "mod < 0U". Signed-off-by: Honggang Li --- ibsim/sim_mad.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ibsim/sim_mad.c b/ibsim/sim_mad.c index a89e2d62afd8..b6e24881fb9e 100644 --- a/ibsim/sim_mad.c +++ b/ibsim/sim_mad.c @@ -711,7 +711,7 @@ static int do_linearforwtbl(Port * port, unsigned op, uint32_t mod, if (!sw) // not a Switch? return ERR_ATTR_UNSUPPORTED; - if (mod < 0 || mod > 767) + if (mod > 767) return ERR_BAD_PARAM; if (op == IB_MAD_METHOD_SET)