From patchwork Wed Jan 2 13:13:10 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Honggang LI X-Patchwork-Id: 10746351 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 680F2746 for ; Wed, 2 Jan 2019 13:14:37 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5860A28848 for ; Wed, 2 Jan 2019 13:14:37 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4CFAA28857; Wed, 2 Jan 2019 13:14:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 091C028848 for ; Wed, 2 Jan 2019 13:14:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729914AbfABNOg (ORCPT ); Wed, 2 Jan 2019 08:14:36 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40718 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729909AbfABNOg (ORCPT ); Wed, 2 Jan 2019 08:14:36 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8CDEA356D3; Wed, 2 Jan 2019 13:14:36 +0000 (UTC) Received: from localhost (ovpn-12-97.pek2.redhat.com [10.72.12.97]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DABC95D9CA; Wed, 2 Jan 2019 13:14:35 +0000 (UTC) From: Honggang Li To: hal@dev.mellanox.co.il Cc: linux-rdma@vger.kernel.org, Honggang Li Subject: [ibsim patch 15/23] sim_mad.c: Fix a CONSTANT_EXPRESSION_RESULT for switch_lookup Date: Wed, 2 Jan 2019 21:13:10 +0800 Message-Id: <20190102131318.5765-15-honli@redhat.com> In-Reply-To: <20190102131318.5765-1-honli@redhat.com> References: <20190102131318.5765-1-honli@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Wed, 02 Jan 2019 13:14:36 +0000 (UTC) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Issue was detected by Coverity. "(outport = node->sw->fdb[lid]) < 0" is always false regardless of the values of its operands, because node->sw->fdb[lid] is uint8_t. Signed-off-by: Honggang Li --- ibsim/sim_mad.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/ibsim/sim_mad.c b/ibsim/sim_mad.c index b6e24881fb9e..5ef1d0a6dbeb 100644 --- a/ibsim/sim_mad.c +++ b/ibsim/sim_mad.c @@ -1579,12 +1579,11 @@ static int switch_lookup(Node * node, int lid) if (!node->sw) return -1; - if (lid > node->sw->linearFDBtop || (outport = node->sw->fdb[lid]) < 0) { + if (lid > node->sw->linearFDBtop) { IBWARN("sw guid %" PRIx64 ": bad lid %u", node->nodeguid, lid); return -1; } - - return outport; + return outport = node->sw->fdb[lid]; } static int port_get_remote(Port * port, Node ** remotenode, Port ** remoteport)