| Message ID | 20190302193933.GA13467@embeddedor.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Leon Romanovsky |
| Headers | show |
| Series | [next] net/mlx5e: Remove redundant assignment | expand |
On 02/03/2019 21:39, Gustavo A. R. Silva wrote: > Remove redundant assignment to tun_entropy->enabled. > > Addesses-Coverity-ID: 1477328 ("Unused value") > Fixes: 97417f6182f8 ("net/mlx5e: Fix GRE key by controlling port tunnel entropy calculation") the commit doesn't fix any real issue but is more of a cleanup. so I'm not sure if fixes line is relevant or not. beside that looks ok. Reviewed-by: Roi Dayan <roid@mellanox.com> > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > --- > drivers/net/ethernet/mellanox/mlx5/core/lib/port_tun.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lib/port_tun.c b/drivers/net/ethernet/mellanox/mlx5/core/lib/port_tun.c > index 40f4a19b1ce1..be69c1d7941a 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/lib/port_tun.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/lib/port_tun.c > @@ -80,10 +80,8 @@ void mlx5_init_port_tun_entropy(struct mlx5_tun_entropy *tun_entropy, > mlx5_query_port_tun_entropy(mdev, &entropy_flags); > tun_entropy->num_enabling_entries = 0; > tun_entropy->num_disabling_entries = 0; > - tun_entropy->enabled = entropy_flags.calc_enabled; > - tun_entropy->enabled = > - (entropy_flags.calc_supported) ? > - entropy_flags.calc_enabled : true; > + tun_entropy->enabled = entropy_flags.calc_supported ? > + entropy_flags.calc_enabled : true; > } > > static int mlx5_set_entropy(struct mlx5_tun_entropy *tun_entropy, >
Reviewed-by: Eli Britstein <elibr@mellanox.com> On 3/3/2019 5:20 PM, Roi Dayan wrote: > > On 02/03/2019 21:39, Gustavo A. R. Silva wrote: >> Remove redundant assignment to tun_entropy->enabled. >> >> Addesses-Coverity-ID: 1477328 ("Unused value") >> Fixes: 97417f6182f8 ("net/mlx5e: Fix GRE key by controlling port tunnel entropy calculation") > the commit doesn't fix any real issue but is more of a cleanup. > so I'm not sure if fixes line is relevant or not. > beside that looks ok. > > Reviewed-by: Roi Dayan <roid@mellanox.com> > > >> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> >> --- >> drivers/net/ethernet/mellanox/mlx5/core/lib/port_tun.c | 6 ++---- >> 1 file changed, 2 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lib/port_tun.c b/drivers/net/ethernet/mellanox/mlx5/core/lib/port_tun.c >> index 40f4a19b1ce1..be69c1d7941a 100644 >> --- a/drivers/net/ethernet/mellanox/mlx5/core/lib/port_tun.c >> +++ b/drivers/net/ethernet/mellanox/mlx5/core/lib/port_tun.c >> @@ -80,10 +80,8 @@ void mlx5_init_port_tun_entropy(struct mlx5_tun_entropy *tun_entropy, >> mlx5_query_port_tun_entropy(mdev, &entropy_flags); >> tun_entropy->num_enabling_entries = 0; >> tun_entropy->num_disabling_entries = 0; >> - tun_entropy->enabled = entropy_flags.calc_enabled; >> - tun_entropy->enabled = >> - (entropy_flags.calc_supported) ? >> - entropy_flags.calc_enabled : true; >> + tun_entropy->enabled = entropy_flags.calc_supported ? >> + entropy_flags.calc_enabled : true; >> } >> >> static int mlx5_set_entropy(struct mlx5_tun_entropy *tun_entropy, >>
On Sun, Mar 03, 2019 at 03:20:57PM +0000, Roi Dayan wrote: > > > On 02/03/2019 21:39, Gustavo A. R. Silva wrote: > > Remove redundant assignment to tun_entropy->enabled. > > > > Addesses-Coverity-ID: 1477328 ("Unused value") > > Fixes: 97417f6182f8 ("net/mlx5e: Fix GRE key by controlling port tunnel entropy calculation") > > the commit doesn't fix any real issue but is more of a cleanup. > so I'm not sure if fixes line is relevant or not. > beside that looks ok. It doesn't matter if it is real issue or not, the code is wrong and should be fixed. This alone is enough to see the Fixes line. Thanks, Acked-by: Leon Romanovsky <leonro@mellanox.com>
On Mon, 2019-03-04 at 08:26 +0200, Leon Romanovsky wrote: > On Sun, Mar 03, 2019 at 03:20:57PM +0000, Roi Dayan wrote: > > > > On 02/03/2019 21:39, Gustavo A. R. Silva wrote: > > > Remove redundant assignment to tun_entropy->enabled. > > > > > > Addesses-Coverity-ID: 1477328 ("Unused value") > > > Fixes: 97417f6182f8 ("net/mlx5e: Fix GRE key by controlling port > > > tunnel entropy calculation") > > > > the commit doesn't fix any real issue but is more of a cleanup. > > so I'm not sure if fixes line is relevant or not. > > beside that looks ok. > > It doesn't matter if it is real issue or not, the code is wrong and > should be fixed. This alone is enough to see the Fixes line. > > Thanks, > Acked-by: Leon Romanovsky <leonro@mellanox.com> Acked-by: Saeed Mahameed <saeedm@mellanox.com> Dave, Do you think such patch should go to net, or do you want me to send it in my next pull request to net-next, once it is open of course ?
From: Saeed Mahameed <saeedm@mellanox.com> Date: Tue, 5 Mar 2019 22:21:39 +0000 > On Mon, 2019-03-04 at 08:26 +0200, Leon Romanovsky wrote: >> On Sun, Mar 03, 2019 at 03:20:57PM +0000, Roi Dayan wrote: >> > >> > On 02/03/2019 21:39, Gustavo A. R. Silva wrote: >> > > Remove redundant assignment to tun_entropy->enabled. >> > > >> > > Addesses-Coverity-ID: 1477328 ("Unused value") >> > > Fixes: 97417f6182f8 ("net/mlx5e: Fix GRE key by controlling port >> > > tunnel entropy calculation") >> > >> > the commit doesn't fix any real issue but is more of a cleanup. >> > so I'm not sure if fixes line is relevant or not. >> > beside that looks ok. >> >> It doesn't matter if it is real issue or not, the code is wrong and >> should be fixed. This alone is enough to see the Fixes line. >> >> Thanks, >> Acked-by: Leon Romanovsky <leonro@mellanox.com> > > Acked-by: Saeed Mahameed <saeedm@mellanox.com> > Dave, Do you think such patch should go to net, or do you want me to > send it in my next pull request to net-next, once it is open of course > ? This feels more like net-next stuff to me, thanks for asking.
On Tue, 2019-03-05 at 19:03 -0800, David Miller wrote: > From: Saeed Mahameed <saeedm@mellanox.com> > Date: Tue, 5 Mar 2019 22:21:39 +0000 > > > On Mon, 2019-03-04 at 08:26 +0200, Leon Romanovsky wrote: > > > On Sun, Mar 03, 2019 at 03:20:57PM +0000, Roi Dayan wrote: > > > > On 02/03/2019 21:39, Gustavo A. R. Silva wrote: > > > > > Remove redundant assignment to tun_entropy->enabled. > > > > > > > > > > Addesses-Coverity-ID: 1477328 ("Unused value") > > > > > Fixes: 97417f6182f8 ("net/mlx5e: Fix GRE key by controlling > > > > > port > > > > > tunnel entropy calculation") > > > > > > > > the commit doesn't fix any real issue but is more of a cleanup. > > > > so I'm not sure if fixes line is relevant or not. > > > > beside that looks ok. > > > > > > It doesn't matter if it is real issue or not, the code is wrong > > > and > > > should be fixed. This alone is enough to see the Fixes line. > > > > > > Thanks, > > > Acked-by: Leon Romanovsky <leonro@mellanox.com> > > > > Acked-by: Saeed Mahameed <saeedm@mellanox.com> > > Dave, Do you think such patch should go to net, or do you want me > > to > > send it in my next pull request to net-next, once it is open of > > course > > ? > > This feels more like net-next stuff to me, thanks for asking. Applied to net-next-mlx5, will be sent in the next pull request when net-next reopens, Thanks!
Hi all, Friendly ping: Who can take this? Thanks -- Gustavo On 3/3/19 11:31 AM, Eli Britstein wrote: > Reviewed-by: Eli Britstein <elibr@mellanox.com> > > On 3/3/2019 5:20 PM, Roi Dayan wrote: >> >> On 02/03/2019 21:39, Gustavo A. R. Silva wrote: >>> Remove redundant assignment to tun_entropy->enabled. >>> >>> Addesses-Coverity-ID: 1477328 ("Unused value") >>> Fixes: 97417f6182f8 ("net/mlx5e: Fix GRE key by controlling port tunnel entropy calculation") >> the commit doesn't fix any real issue but is more of a cleanup. >> so I'm not sure if fixes line is relevant or not. >> beside that looks ok. >> >> Reviewed-by: Roi Dayan <roid@mellanox.com> >> >> >>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> >>> --- >>> drivers/net/ethernet/mellanox/mlx5/core/lib/port_tun.c | 6 ++---- >>> 1 file changed, 2 insertions(+), 4 deletions(-) >>> >>> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lib/port_tun.c b/drivers/net/ethernet/mellanox/mlx5/core/lib/port_tun.c >>> index 40f4a19b1ce1..be69c1d7941a 100644 >>> --- a/drivers/net/ethernet/mellanox/mlx5/core/lib/port_tun.c >>> +++ b/drivers/net/ethernet/mellanox/mlx5/core/lib/port_tun.c >>> @@ -80,10 +80,8 @@ void mlx5_init_port_tun_entropy(struct mlx5_tun_entropy *tun_entropy, >>> mlx5_query_port_tun_entropy(mdev, &entropy_flags); >>> tun_entropy->num_enabling_entries = 0; >>> tun_entropy->num_disabling_entries = 0; >>> - tun_entropy->enabled = entropy_flags.calc_enabled; >>> - tun_entropy->enabled = >>> - (entropy_flags.calc_supported) ? >>> - entropy_flags.calc_enabled : true; >>> + tun_entropy->enabled = entropy_flags.calc_supported ? >>> + entropy_flags.calc_enabled : true; >>> } >>> >>> static int mlx5_set_entropy(struct mlx5_tun_entropy *tun_entropy, >>>
On Mon, 2019-03-18 at 12:35 -0500, Gustavo A. R. Silva wrote: > Hi all, > > Friendly ping: > > Who can take this? > Hi Gustavo, I already replied on March 8, that this patch was applied to my branch, net-next-mlx5, https://git.kernel.org/pub/scm/linux/kernel/git/saeed/linux.git/commit/?h=net-next-mlx5&id=6279999c6e3de5a93312a2d66b3fd6ac8636f260 Once net-next is open, this patch is going to make it there as part of my next pull request to Dave. Thanks, Saeed. > Thanks > -- > Gustavo > > On 3/3/19 11:31 AM, Eli Britstein wrote: > > Reviewed-by: Eli Britstein <elibr@mellanox.com> > > > > On 3/3/2019 5:20 PM, Roi Dayan wrote: > > > On 02/03/2019 21:39, Gustavo A. R. Silva wrote: > > > > Remove redundant assignment to tun_entropy->enabled. > > > > > > > > Addesses-Coverity-ID: 1477328 ("Unused value") > > > > Fixes: 97417f6182f8 ("net/mlx5e: Fix GRE key by controlling > > > > port tunnel entropy calculation") > > > the commit doesn't fix any real issue but is more of a cleanup. > > > so I'm not sure if fixes line is relevant or not. > > > beside that looks ok. > > > > > > Reviewed-by: Roi Dayan <roid@mellanox.com> > > > > > > > > > > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > > > > --- > > > > drivers/net/ethernet/mellanox/mlx5/core/lib/port_tun.c | 6 > > > > ++---- > > > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > > > > > diff --git > > > > a/drivers/net/ethernet/mellanox/mlx5/core/lib/port_tun.c > > > > b/drivers/net/ethernet/mellanox/mlx5/core/lib/port_tun.c > > > > index 40f4a19b1ce1..be69c1d7941a 100644 > > > > --- a/drivers/net/ethernet/mellanox/mlx5/core/lib/port_tun.c > > > > +++ b/drivers/net/ethernet/mellanox/mlx5/core/lib/port_tun.c > > > > @@ -80,10 +80,8 @@ void mlx5_init_port_tun_entropy(struct > > > > mlx5_tun_entropy *tun_entropy, > > > > mlx5_query_port_tun_entropy(mdev, &entropy_flags); > > > > tun_entropy->num_enabling_entries = 0; > > > > tun_entropy->num_disabling_entries = 0; > > > > - tun_entropy->enabled = entropy_flags.calc_enabled; > > > > - tun_entropy->enabled = > > > > - (entropy_flags.calc_supported) ? > > > > - entropy_flags.calc_enabled : true; > > > > + tun_entropy->enabled = entropy_flags.calc_supported ? > > > > + entropy_flags.calc_enabled : > > > > true; > > > > } > > > > > > > > static int mlx5_set_entropy(struct mlx5_tun_entropy > > > > *tun_entropy, > > > >
On 3/18/19 1:10 PM, Saeed Mahameed wrote: > On Mon, 2019-03-18 at 12:35 -0500, Gustavo A. R. Silva wrote: >> Hi all, >> >> Friendly ping: >> >> Who can take this? >> > > > Hi Gustavo, > > I already replied on March 8, that this patch was applied to my branch, > net-next-mlx5, > Oh, somehow I missed that one. > https://git.kernel.org/pub/scm/linux/kernel/git/saeed/linux.git/commit/?h=net-next-mlx5&id=6279999c6e3de5a93312a2d66b3fd6ac8636f260 > > Once net-next is open, this patch is going to make it there as part of > my next pull request to Dave. > Sounds great. :) Thanks, Saeed. -- Gustavo
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lib/port_tun.c b/drivers/net/ethernet/mellanox/mlx5/core/lib/port_tun.c index 40f4a19b1ce1..be69c1d7941a 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/lib/port_tun.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/lib/port_tun.c @@ -80,10 +80,8 @@ void mlx5_init_port_tun_entropy(struct mlx5_tun_entropy *tun_entropy, mlx5_query_port_tun_entropy(mdev, &entropy_flags); tun_entropy->num_enabling_entries = 0; tun_entropy->num_disabling_entries = 0; - tun_entropy->enabled = entropy_flags.calc_enabled; - tun_entropy->enabled = - (entropy_flags.calc_supported) ? - entropy_flags.calc_enabled : true; + tun_entropy->enabled = entropy_flags.calc_supported ? + entropy_flags.calc_enabled : true; } static int mlx5_set_entropy(struct mlx5_tun_entropy *tun_entropy,
Remove redundant assignment to tun_entropy->enabled. Addesses-Coverity-ID: 1477328 ("Unused value") Fixes: 97417f6182f8 ("net/mlx5e: Fix GRE key by controlling port tunnel entropy calculation") Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> --- drivers/net/ethernet/mellanox/mlx5/core/lib/port_tun.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)