diff mbox series

[2/3] IB/isert: remove unneeded semicolon

Message ID 20210110111903.486681-2-mgurtovoy@nvidia.com (mailing list archive)
State Accepted
Delegated to: Jason Gunthorpe
Headers show
Series [1/3] IB/isert: remove unneeded new lines | expand

Commit Message

Max Gurtovoy Jan. 10, 2021, 11:19 a.m. UTC 
No need to add semicolon after closing bracket.

Reviewed-by: Israel Rukshin <israelr@nvidia.com>
Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
---
 drivers/infiniband/ulp/isert/ib_isert.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Leon Romanovsky Jan. 10, 2021, 11:36 a.m. UTC | #1 
On Sun, Jan 10, 2021 at 11:19:02AM +0000, Max Gurtovoy wrote:
> No need to add semicolon after closing bracket.
>
> Reviewed-by: Israel Rukshin <israelr@nvidia.com>
> Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
> ---
>  drivers/infiniband/ulp/isert/ib_isert.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/ulp/isert/ib_isert.c b/drivers/infiniband/ulp/isert/ib_isert.c
> index 5958929b7dec..96514f675427 100644
> --- a/drivers/infiniband/ulp/isert/ib_isert.c
> +++ b/drivers/infiniband/ulp/isert/ib_isert.c
> @@ -1991,7 +1991,7 @@ isert_set_dif_domain(struct se_cmd *se_cmd, struct ib_sig_domain *domain)
>  	if (se_cmd->prot_type == TARGET_DIF_TYPE1_PROT ||
>  	    se_cmd->prot_type == TARGET_DIF_TYPE2_PROT)
>  		domain->sig.dif.ref_remap = true;
> -};
> +}

The same goes for iser_set_dif_domain() and iser_cleanup_handler().

Thanks

>
>  static int
>  isert_set_sig_attrs(struct se_cmd *se_cmd, struct ib_sig_attrs *sig_attrs)
> --
> 2.25.4
>
Max Gurtovoy Jan. 10, 2021, 12:07 p.m. UTC | #2 
On 1/10/2021 1:36 PM, Leon Romanovsky wrote:
> On Sun, Jan 10, 2021 at 11:19:02AM +0000, Max Gurtovoy wrote:
>> No need to add semicolon after closing bracket.
>>
>> Reviewed-by: Israel Rukshin <israelr@nvidia.com>
>> Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
>> ---
>>   drivers/infiniband/ulp/isert/ib_isert.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/infiniband/ulp/isert/ib_isert.c b/drivers/infiniband/ulp/isert/ib_isert.c
>> index 5958929b7dec..96514f675427 100644
>> --- a/drivers/infiniband/ulp/isert/ib_isert.c
>> +++ b/drivers/infiniband/ulp/isert/ib_isert.c
>> @@ -1991,7 +1991,7 @@ isert_set_dif_domain(struct se_cmd *se_cmd, struct ib_sig_domain *domain)
>>   	if (se_cmd->prot_type == TARGET_DIF_TYPE1_PROT ||
>>   	    se_cmd->prot_type == TARGET_DIF_TYPE2_PROT)
>>   		domain->sig.dif.ref_remap = true;
>> -};
>> +}
> The same goes for iser_set_dif_domain() and iser_cleanup_handler().

Good catch, I'll send iSER fixes in different series.

This series is for minor fixes for iSERT.

>
> Thanks
>
>>   static int
>>   isert_set_sig_attrs(struct se_cmd *se_cmd, struct ib_sig_attrs *sig_attrs)
>> --
>> 2.25.4
>>
Sagi Grimberg Jan. 14, 2021, 12:07 a.m. UTC | #3 
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
diff mbox series

Patch

diff --git a/drivers/infiniband/ulp/isert/ib_isert.c b/drivers/infiniband/ulp/isert/ib_isert.c
index 5958929b7dec..96514f675427 100644
--- a/drivers/infiniband/ulp/isert/ib_isert.c
+++ b/drivers/infiniband/ulp/isert/ib_isert.c
@@ -1991,7 +1991,7 @@  isert_set_dif_domain(struct se_cmd *se_cmd, struct ib_sig_domain *domain)
 	if (se_cmd->prot_type == TARGET_DIF_TYPE1_PROT ||
 	    se_cmd->prot_type == TARGET_DIF_TYPE2_PROT)
 		domain->sig.dif.ref_remap = true;
-};
+}
 
 static int
 isert_set_sig_attrs(struct se_cmd *se_cmd, struct ib_sig_attrs *sig_attrs)