diff mbox series

[rdma-core,1/4] bnxt_re/lib: fix AH validity check

Message ID 20210503064802.457482-2-devesh.sharma@broadcom.com (mailing list archive)
State Superseded
Headers show
Series Broadcom's rdma provider lib update | expand

Commit Message

Devesh Sharma May 3, 2021, 6:47 a.m. UTC 
Fixing the AH validity check when initializing the
UD SQE from AH.

Signed-off-by: Devesh Sharma <devesh.sharma@broadcom.com>
---
 providers/bnxt_re/verbs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Jason Gunthorpe May 3, 2021, 1:33 p.m. UTC | #1 
On Mon, May 03, 2021 at 12:17:59PM +0530, Devesh Sharma wrote:
> Fixing the AH validity check when initializing the
> UD SQE from AH.
> 
> Signed-off-by: Devesh Sharma <devesh.sharma@broadcom.com>
> ---
>  providers/bnxt_re/verbs.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

This all need fixes lines and why do they have such a strange subject?

Jason
Devesh Sharma May 5, 2021, 3:01 p.m. UTC | #2 
On Mon, May 3, 2021 at 7:03 PM Jason Gunthorpe <jgg@ziepe.ca> wrote:
>
> On Mon, May 03, 2021 at 12:17:59PM +0530, Devesh Sharma wrote:
> > Fixing the AH validity check when initializing the
> > UD SQE from AH.
> >
> > Signed-off-by: Devesh Sharma <devesh.sharma@broadcom.com>
> > ---
> >  providers/bnxt_re/verbs.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
>
> This all need fixes lines and why do they have such a strange subject?

Let me get back with V2. May be I did the patches in a hurry, let me
correct these.
>
>
> Jason




--
-Regards
Devesh
diff mbox series

Patch

diff --git a/providers/bnxt_re/verbs.c b/providers/bnxt_re/verbs.c
index ca561662..a015bed7 100644
--- a/providers/bnxt_re/verbs.c
+++ b/providers/bnxt_re/verbs.c
@@ -1193,13 +1193,13 @@  static int bnxt_re_build_ud_sqe(struct bnxt_re_qp *qp, void *wqe,
 	int len;
 
 	len = bnxt_re_build_send_sqe(qp, wqe, wr, is_inline);
-	sqe->qkey = htole32(wr->wr.ud.remote_qkey);
-	sqe->dst_qp = htole32(wr->wr.ud.remote_qpn);
 	if (!wr->wr.ud.ah) {
 		len = -EINVAL;
 		goto bail;
 	}
 	ah = to_bnxt_re_ah(wr->wr.ud.ah);
+	sqe->qkey = htole32(wr->wr.ud.remote_qkey);
+	sqe->dst_qp = htole32(wr->wr.ud.remote_qpn);
 	sqe->avid = htole32(ah->avid & 0xFFFFF);
 bail:
 	return len;