| Message ID | 20210510084235.223628-1-yanjun.zhu@intel.com (mailing list archive) |
|---|---|
| State | Rejected |
| Headers | show |
| Series | [1/1] RDMA/rxe: remove the unnecessary break | expand |
On Mon, May 10, 2021 at 12:18 AM Zhu Yanjun <yanjun.zhu@intel.com> wrote: > > From: Zhu Yanjun <zyjzyj2000@gmail.com> > > In the final default, the break is not necessary. Hi, Jason Gunthorpe and Leon Romanovsky Gently ping Zhu Yanjun > > Fixes: 8700e3e7c485 ("Soft RoCE driver") > Signed-off-by: Zhu Yanjun <zyjzyj2000@gmail.com> > --- > drivers/infiniband/sw/rxe/rxe_qp.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/infiniband/sw/rxe/rxe_qp.c b/drivers/infiniband/sw/rxe/rxe_qp.c > index 34ae957a315c..00588735744f 100644 > --- a/drivers/infiniband/sw/rxe/rxe_qp.c > +++ b/drivers/infiniband/sw/rxe/rxe_qp.c > @@ -186,7 +186,6 @@ static void rxe_qp_init_misc(struct rxe_dev *rxe, struct rxe_qp *qp, > > default: > qp->ibqp.qp_num = qpn; > - break; > } > > INIT_LIST_HEAD(&qp->grp_list); > -- > 2.27.0 >
On Wed, May 12, 2021 at 10:45:17AM +0800, Zhu Yanjun wrote: > On Mon, May 10, 2021 at 12:18 AM Zhu Yanjun <yanjun.zhu@intel.com> wrote: > > > > From: Zhu Yanjun <zyjzyj2000@gmail.com> > > > > In the final default, the break is not necessary. > > Hi, Jason Gunthorpe and Leon Romanovsky > > Gently ping I'm not keen on this kind of churn Jason
diff --git a/drivers/infiniband/sw/rxe/rxe_qp.c b/drivers/infiniband/sw/rxe/rxe_qp.c index 34ae957a315c..00588735744f 100644 --- a/drivers/infiniband/sw/rxe/rxe_qp.c +++ b/drivers/infiniband/sw/rxe/rxe_qp.c @@ -186,7 +186,6 @@ static void rxe_qp_init_misc(struct rxe_dev *rxe, struct rxe_qp *qp, default: qp->ibqp.qp_num = qpn; - break; } INIT_LIST_HEAD(&qp->grp_list);