| Message ID | 20211220152530.60399-1-kamalheib1@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Jason Gunthorpe |
| Headers | show |
| Series | [for-next] RDMA/cxgb4: Set queue pair state when being queried | expand |
On Mon, Dec 20, 2021 at 05:25:30PM +0200, Kamal Heib wrote: > The API for ib_query_qp requires the driver to set > cur_qp_state on return, add the missing set. > > Fixes: 67bbc05512d8 ("RDMA/cxgb4: Add query_qp support") > Signed-off-by: Kamal Heib <kamalheib1@gmail.com> > --- > drivers/infiniband/hw/cxgb4/qp.c | 1 + > 1 file changed, 1 insertion(+) I wonder if this is last error of such type. The bnxt_re had same error 53839b51a767 ("RDMA/bnxt_re: Set queue pair state when being queried") Thanks, Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
On Mon, Dec 20, 2021 at 05:25:30PM +0200, Kamal Heib wrote: > The API for ib_query_qp requires the driver to set > cur_qp_state on return, add the missing set. > > Fixes: 67bbc05512d8 ("RDMA/cxgb4: Add query_qp support") > Signed-off-by: Kamal Heib <kamalheib1@gmail.com> > Reviewed-by: Leon Romanovsky <leonro@nvidia.com> > --- > drivers/infiniband/hw/cxgb4/qp.c | 1 + > 1 file changed, 1 insertion(+) Applied to for-next, thanks Jason
diff --git a/drivers/infiniband/hw/cxgb4/qp.c b/drivers/infiniband/hw/cxgb4/qp.c index d20b4ef2c853..ffbd9a89981e 100644 --- a/drivers/infiniband/hw/cxgb4/qp.c +++ b/drivers/infiniband/hw/cxgb4/qp.c @@ -2460,6 +2460,7 @@ int c4iw_ib_query_qp(struct ib_qp *ibqp, struct ib_qp_attr *attr, memset(attr, 0, sizeof(*attr)); memset(init_attr, 0, sizeof(*init_attr)); attr->qp_state = to_ib_qp_state(qhp->attr.state); + attr->cur_qp_state = to_ib_qp_state(qhp->attr.state); init_attr->cap.max_send_wr = qhp->attr.sq_num_entries; init_attr->cap.max_recv_wr = qhp->attr.rq_num_entries; init_attr->cap.max_send_sge = qhp->attr.sq_max_sges;
The API for ib_query_qp requires the driver to set cur_qp_state on return, add the missing set. Fixes: 67bbc05512d8 ("RDMA/cxgb4: Add query_qp support") Signed-off-by: Kamal Heib <kamalheib1@gmail.com> --- drivers/infiniband/hw/cxgb4/qp.c | 1 + 1 file changed, 1 insertion(+)