| Message ID | 20220326165909.506926-9-benni@stuerz.xyz (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [01/22] orion5x: Replace comments with C99 initializers | expand |
On Sat, Mar 26, 2022 at 6:00 PM Benjamin Stürz <benni@stuerz.xyz> wrote: > This replaces comments with C99's designated > initializers because the kernel supports them now. > > Signed-off-by: Benjamin Stürz <benni@stuerz.xyz> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On Sat, Mar 26, 2022 at 6:00 PM Benjamin Stürz <benni@stuerz.xyz> wrote: > > This replaces comments with C99's designated > initializers because the kernel supports them now. > > Signed-off-by: Benjamin Stürz <benni@stuerz.xyz> > --- > drivers/gpio/gpio-winbond.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpio/gpio-winbond.c b/drivers/gpio/gpio-winbond.c > index 7f8f5b02e31d..0b637fdb407c 100644 > --- a/drivers/gpio/gpio-winbond.c > +++ b/drivers/gpio/gpio-winbond.c > @@ -249,7 +249,7 @@ struct winbond_gpio_info { > }; > > static const struct winbond_gpio_info winbond_gpio_infos[6] = { > - { /* 0 */ > + [0] = { > .dev = WB_SIO_DEV_GPIO12, > .enablereg = WB_SIO_GPIO12_REG_ENABLE, > .enablebit = WB_SIO_GPIO12_ENABLE_1, > @@ -266,7 +266,7 @@ static const struct winbond_gpio_info winbond_gpio_infos[6] = { > .warnonly = true > } > }, > - { /* 1 */ > + [1] = { > .dev = WB_SIO_DEV_GPIO12, > .enablereg = WB_SIO_GPIO12_REG_ENABLE, > .enablebit = WB_SIO_GPIO12_ENABLE_2, > @@ -277,7 +277,7 @@ static const struct winbond_gpio_info winbond_gpio_infos[6] = { > .datareg = WB_SIO_GPIO12_REG_DATA2 > /* special conflict handling so doesn't use conflict data */ > }, > - { /* 2 */ > + [2] = { > .dev = WB_SIO_DEV_GPIO34, > .enablereg = WB_SIO_GPIO34_REG_ENABLE, > .enablebit = WB_SIO_GPIO34_ENABLE_3, > @@ -294,7 +294,7 @@ static const struct winbond_gpio_info winbond_gpio_infos[6] = { > .warnonly = true > } > }, > - { /* 3 */ > + [3] = { > .dev = WB_SIO_DEV_GPIO34, > .enablereg = WB_SIO_GPIO34_REG_ENABLE, > .enablebit = WB_SIO_GPIO34_ENABLE_4, > @@ -311,7 +311,7 @@ static const struct winbond_gpio_info winbond_gpio_infos[6] = { > .warnonly = true > } > }, > - { /* 4 */ > + [4] = { > .dev = WB_SIO_DEV_WDGPIO56, > .enablereg = WB_SIO_WDGPIO56_REG_ENABLE, > .enablebit = WB_SIO_WDGPIO56_ENABLE_5, > @@ -328,7 +328,7 @@ static const struct winbond_gpio_info winbond_gpio_infos[6] = { > .warnonly = true > } > }, > - { /* 5 */ > + [5] = { > .dev = WB_SIO_DEV_WDGPIO56, > .enablereg = WB_SIO_WDGPIO56_REG_ENABLE, > .enablebit = WB_SIO_WDGPIO56_ENABLE_6, > -- > 2.35.1 > Acked-by: Bartosz Golaszewski <brgl@bgdev.pl>
diff --git a/drivers/gpio/gpio-winbond.c b/drivers/gpio/gpio-winbond.c index 7f8f5b02e31d..0b637fdb407c 100644 --- a/drivers/gpio/gpio-winbond.c +++ b/drivers/gpio/gpio-winbond.c @@ -249,7 +249,7 @@ struct winbond_gpio_info { }; static const struct winbond_gpio_info winbond_gpio_infos[6] = { - { /* 0 */ + [0] = { .dev = WB_SIO_DEV_GPIO12, .enablereg = WB_SIO_GPIO12_REG_ENABLE, .enablebit = WB_SIO_GPIO12_ENABLE_1, @@ -266,7 +266,7 @@ static const struct winbond_gpio_info winbond_gpio_infos[6] = { .warnonly = true } }, - { /* 1 */ + [1] = { .dev = WB_SIO_DEV_GPIO12, .enablereg = WB_SIO_GPIO12_REG_ENABLE, .enablebit = WB_SIO_GPIO12_ENABLE_2, @@ -277,7 +277,7 @@ static const struct winbond_gpio_info winbond_gpio_infos[6] = { .datareg = WB_SIO_GPIO12_REG_DATA2 /* special conflict handling so doesn't use conflict data */ }, - { /* 2 */ + [2] = { .dev = WB_SIO_DEV_GPIO34, .enablereg = WB_SIO_GPIO34_REG_ENABLE, .enablebit = WB_SIO_GPIO34_ENABLE_3, @@ -294,7 +294,7 @@ static const struct winbond_gpio_info winbond_gpio_infos[6] = { .warnonly = true } }, - { /* 3 */ + [3] = { .dev = WB_SIO_DEV_GPIO34, .enablereg = WB_SIO_GPIO34_REG_ENABLE, .enablebit = WB_SIO_GPIO34_ENABLE_4, @@ -311,7 +311,7 @@ static const struct winbond_gpio_info winbond_gpio_infos[6] = { .warnonly = true } }, - { /* 4 */ + [4] = { .dev = WB_SIO_DEV_WDGPIO56, .enablereg = WB_SIO_WDGPIO56_REG_ENABLE, .enablebit = WB_SIO_WDGPIO56_ENABLE_5, @@ -328,7 +328,7 @@ static const struct winbond_gpio_info winbond_gpio_infos[6] = { .warnonly = true } }, - { /* 5 */ + [5] = { .dev = WB_SIO_DEV_WDGPIO56, .enablereg = WB_SIO_WDGPIO56_REG_ENABLE, .enablebit = WB_SIO_WDGPIO56_ENABLE_6,
This replaces comments with C99's designated initializers because the kernel supports them now. Signed-off-by: Benjamin Stürz <benni@stuerz.xyz> --- drivers/gpio/gpio-winbond.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)