From patchwork Mon Jul 4 06:00:55 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Zhijian Li (Fujitsu)" X-Patchwork-Id: 12904730 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED856C43334 for ; Mon, 4 Jul 2022 06:01:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229576AbiGDGBG (ORCPT ); Mon, 4 Jul 2022 02:01:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229499AbiGDGBE (ORCPT ); Mon, 4 Jul 2022 02:01:04 -0400 Received: from esa18.fujitsucc.c3s2.iphmx.com (esa18.fujitsucc.c3s2.iphmx.com [216.71.158.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6FCD863AE for ; Sun, 3 Jul 2022 23:01:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=fujitsu.com; i=@fujitsu.com; q=dns/txt; s=fj1; t=1656914464; x=1688450464; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Zy8xOPZWZB1CbQUP5nX/vKzMxGjIoG2c0up/fy8cRw0=; b=loMBOZC6ntZkAmx17kZ+pd0eYnp2bMG4nd3YSAethJtK4ahp1qkqNaAd 9y6DweZ7lRL48IjzpUopgnCo0E6WFk4bASv+8kaYEGYXPEvPRiEl35gGr mO6FO6RtXv+4PpeRJzOpJFbeny4yFMPZWgg9Ld4BDNIe1C1cAS52s56Yo ci/GsVXo1FE2xdXP7uBSWm79WHumCubmB104xbXh2zemDriphnKyJl30s F7yGLvgGOaQB4Dsv9iFvOa7bZY7NfQiCqTWxrXvAsocbZ2Np6vxVQVM8d sN7SD7gwj5U0fal77tk/GM+PyPeHlWIt1AklnvNWN7+0nTSP0zhUwbx5l A==; X-IronPort-AV: E=McAfee;i="6400,9594,10397"; a="60952360" X-IronPort-AV: E=Sophos;i="5.92,243,1650898800"; d="scan'208";a="60952360" Received: from mail-tycjpn01lp2169.outbound.protection.outlook.com (HELO JPN01-TYC-obe.outbound.protection.outlook.com) ([104.47.23.169]) by ob1.fujitsucc.c3s2.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jul 2022 15:01:01 +0900 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D0wFz4ODIGrVxeEvHzqdH3Bl2S/KGzp/cLZKg+8SepFWlB+GKWv1TlBvItik3g7s8aVYNOsAuDxgrl3eO62rJTo5D0GhxOpBUdEcst44wtzpnsx4v7XOrHqsDovupahoMrAQJroZQuB/cnU4Tpq3NICjiNSUmwyRXdpmjrFvqY4LgSvcZZk8EBbKPt041pZg6WPrMvX8OMUDBaqgrXQeVMftmYXyn3xA7OlwyH2Vi8jSRnK3Vr0xoodNmNt5vGpOOPtHkUBerMUywqtTYeHNMetR2fkIxmPksFPGtINx4SxqV1ZJ99h1Uavh6dxTNM2hpdjkV5YsJlD917dKk9oy3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Zy8xOPZWZB1CbQUP5nX/vKzMxGjIoG2c0up/fy8cRw0=; b=Y1logjiJ6cxjNqHPxgIriQuGa+d0Qvpqk+3WKgdCzzhvIjFSWZNQvSb1kXvPAyneuFu71dJ2LK+rk7U7CvOz2JefzuO6ghF0Ni9cftryQvXUtIY/27RjBZ/4om7A1+/j0mAjdyXq4Kw+4s9mjEds2tTMl+HMjmzlsIM/Nevv95EV5VGktj83VVhIGKJp0/laXsagDuBt0RU5GSPN13B1RIFftLyF/8HZZU/wbD/F7RCwUtENyKjuvqrokv0MMPc61GI3r//Lbr7DJAtMlTxnUUAITjeoV6VpI+Yiz7oeVHzWlaIgbfemUoitzerLwr2jYcqr6YDK6enTGDPtror8fg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=fujitsu.com; dmarc=pass action=none header.from=fujitsu.com; dkim=pass header.d=fujitsu.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fujitsu.onmicrosoft.com; s=selector2-fujitsu-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Zy8xOPZWZB1CbQUP5nX/vKzMxGjIoG2c0up/fy8cRw0=; b=B9BQKvPz+3EW7F0M2D0+K/NE1JfJewyVoGNtdLksAlx+Qaf/Ynln+YwRewoHFSFD8EintrDJmw0azxsO05z8L3Q0M5zM/io1BPXJXFs3VsC3mnGQXngAvoraquk9D15l1wm4i3vsv4tRq5+4aIFk2nPOEgP28E++pB3wlnzNTtQ= Received: from TYCPR01MB9305.jpnprd01.prod.outlook.com (2603:1096:400:196::10) by TY1PR01MB1753.jpnprd01.prod.outlook.com (2603:1096:403:1::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.18; Mon, 4 Jul 2022 06:00:55 +0000 Received: from TYCPR01MB9305.jpnprd01.prod.outlook.com ([fe80::8d7a:baa8:3b18:cd93]) by TYCPR01MB9305.jpnprd01.prod.outlook.com ([fe80::8d7a:baa8:3b18:cd93%6]) with mapi id 15.20.5395.020; Mon, 4 Jul 2022 06:00:55 +0000 From: "lizhijian@fujitsu.com" To: Yanjun Zhu , Jason Gunthorpe , Haakon Bugge , "linux-rdma@vger.kernel.org" , Bob Pearson CC: Cheng Xu , "lizhijian@fujitsu.com" Subject: [PATCH v5 1/4] RDMA/rxe: Update wqe_index for each wqe error completion Thread-Topic: [PATCH v5 1/4] RDMA/rxe: Update wqe_index for each wqe error completion Thread-Index: AQHYj2ts7pOi9bWXrkiEg2X7//pIyg== Date: Mon, 4 Jul 2022 06:00:55 +0000 Message-ID: <20220704060806.1622849-2-lizhijian@fujitsu.com> References: <20220704060806.1622849-1-lizhijian@fujitsu.com> In-Reply-To: <20220704060806.1622849-1-lizhijian@fujitsu.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.31.1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=fujitsu.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 69b35b6e-0898-434e-8684-08da5d828f02 x-ms-traffictypediagnostic: TY1PR01MB1753:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QVqwKzvZd7Pj0rgyIcOBHCbbpNxfHn4k5cqQlQgq1W+nQb5UEDdyTMy7uVhd5jjIQKtlRqzzjOQRHU4c4rpnguYEArmF6OD3g+xebhAOW8sOcwMIZaYIeWsQtqB8coDuqSbZspCiqd9pUX0uDB+CRJM0fpb/K/la8rVdPvzlrSRF29/r+UcUefHFStiwNDOfbxCQJlwZeIZBhTD0m5hFjRbmsQ7fXT/ORjNT5wSdvYUT62AgYiiJNkBYSbyDptjRotk/SpdFFtsXKr1zlw3hu5uqGLM8I51EVPV27LG3Ho7qWySBagJQoMhwCuOJ9ltsRKJWfvuAMkMtRM8AEOoDqkFkcF2xnSS3IQksaKOd8eKePablNz7f7TAolatpAUdAc4Hvm2BsvxssSgFbxIbf2obRHWJ/weTuX7ltzStKcA5eX3PCEy6I/7kI0o/fOQYhTjtHchu6w5OiYgpE50tIJM9SYlZ0RS+CMTa2WbYG0HOU1ZaGwc0qf7pfYps/s+QuavK0R9M+EgEd0Drfy+hH1eNYWpnuJUew/0EWJNcmiiiTbuyMzE2HbMMEkt2wKP8q8cuYXo3++sAEWaQz/2tH1YRmxX22OVMO/+erIfTuCIz21mho5VieG5nsPnu4sZfdG3wFp5YGCxk7w4joSNmfTHbJaRsAjyM7cs0wmRtMwhxuHtDqjXjR+H03kcNcFmYnISagwHrnEzI9oHUD4LYN1044TByqkBNTsINh91+e+8LzcQN9J25O0Z9le4DV0geeQDyec75Lre1OP43nLcoaXeGZo7cmaNdj5ROS3MpHebeqzwrdOGFHIK0rtkr4LlIO x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TYCPR01MB9305.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(346002)(136003)(376002)(366004)(396003)(2616005)(107886003)(186003)(1076003)(38070700005)(38100700002)(64756008)(36756003)(71200400001)(8676002)(66446008)(316002)(66476007)(66946007)(76116006)(110136005)(66556008)(83380400001)(85182001)(91956017)(54906003)(4326008)(15650500001)(5660300002)(6512007)(6506007)(4744005)(478600001)(6486002)(8936002)(82960400001)(122000001)(86362001)(41300700001)(26005)(2906002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?eucgb2312_cn?b?SUVLa1dGMUJVUEZCUGVZeGtH?= =?eucgb2312_cn?b?KzE2N056MlJKK21NMkFoSDRrYmJPM2NpSC9oRWtOTmdlcE5HV0UwTUM1eTJ5Ty9x?= =?eucgb2312_cn?b?V2s3R0FrdnN5RUgzM2RDcWt6NlZ6d01ubzlzMDUrazgreUx0UmdwOTBsbzlVVXN2?= =?eucgb2312_cn?b?b2ZKd09ZTFllWGRnbmFUb3ZiTlZhalUrZktNQy8zc1JkalpiQ1pUV0hQTUptLy9k?= =?eucgb2312_cn?b?S0ZqaHNUWWNBbUFMMDlCUjdKMlk1MmJ4NElxckNjQnF6VmE4elhzWVhhTStEV1ZR?= =?eucgb2312_cn?b?aXRkZmg0aXBlOWgxNmFOSzNQRWJSSVpnQU9jSlRIVHQrMXdWS0FzUTdkNnFPVm1F?= =?eucgb2312_cn?b?Wk9sT3FUWkdpbE5oWWI3RzJ6cVlETkZyWktTL2ROTW02VmQ0UkdrNW5icjJ6YnFV?= =?eucgb2312_cn?b?K2cvM2lMalh6WEVOd3ZsbnFBUmszTUpmUjYzZTdFZGV4SFFlcmZOQUU1OE9NNlRG?= =?eucgb2312_cn?b?cnh4bUJHNUoyR0htTTdsNHlPZnQwWlpEMzk0RmlyT0dhM1pGMTZXTTN2THVjMzc0?= =?eucgb2312_cn?b?VlIrK1dkaE9jRjgrRDdZWGFoWkVYdVU4clV0bjNlODZ2M0g5ZFZvQ2grTTR4Ulgz?= =?eucgb2312_cn?b?N0NHd2d3ZFhtU2dSQmwxNmh3R1gweEhLemQ3cG9MMGtya1NxaEFSUUhsVEI2TmZz?= =?eucgb2312_cn?b?bkJOaHJhS0tpOHR1R21BTmx4S0p4b0gzZUs3U3R4SUNOMnhNK1YvVHUrangxUTRy?= =?eucgb2312_cn?b?K0x3djlaczNHejVQTVdDZTl5WDJRK1JvM0NGcG5HVTg5QnhrTThwamxVbEJyUjBD?= =?eucgb2312_cn?b?TU1rOXFFUnZiVVdpS2dWdUsyOHZUYjBhVDBscHFXZ0FLdXRGYUo2VUJoOXpWSTNq?= =?eucgb2312_cn?b?S09ZOWdTL3ZuaHZMczA5SnFaREVoM1hKU1dvVWlMcTZMcHBYcUZMMDcvNVJPTk9s?= =?eucgb2312_cn?b?am9EVVBydWJ3Ni9HckhvRUJDRGh2c3BUdGs5MDR5bWdJb0ZQa1BtaEZhOG5OcE4x?= =?eucgb2312_cn?b?WFcyV3luUHNCdVdHTnFaZFNhKzlhQ0loNmZMcHpMWVZmU0VTZzFIUEJIMmdVcDB2?= =?eucgb2312_cn?b?M01NNmlteDBNc01wbHo1WkZZWXZJYmJtUVBhSGNQNjlKOXExWURocVYvTm9Ca3VE?= =?eucgb2312_cn?b?REFOdWlyZjJFRk5yRkdqZy9STkxKNmljYWFLWjJvR1lCSE5DYlhxNzJOY2NEV3gw?= =?eucgb2312_cn?b?YmgzaVExdTh2UjZCOWdRekxFcVRuQklqMEdLTWJ1MWxLOHI2WG9GQmY3cmZxTWxF?= =?eucgb2312_cn?b?TVFqVllyTUxPT09iNXBFYndTdloweFEvNWF0aVhTalBJZ2xJWjA5ejhEUEtNVEpa?= =?eucgb2312_cn?b?REZmVlZGZTNvdkxMZEJXdEcxVitxeGdZcGthZnNKU3BBWGJ0SEdBM2F5TVJOaUpk?= =?eucgb2312_cn?b?NUxMcFJPZVErVnNlWWRPeXdtUHh4cEx6bFE5YUs3bGJab0JwNzRqNFFhMzJiMVND?= =?eucgb2312_cn?b?Y0JoRGJXV2Z2VTA5Z2x4dEROaUI3RVhaaGFjQU1INlJvVmFDVlUxWDRvOW1EZVEx?= =?eucgb2312_cn?b?dm5EdnNPY0JWK0VweWIrbFlpUlBtd2dpNGZOQ29Cand3b3ZlclN6OGREOXBXTERQ?= =?eucgb2312_cn?b?Z2xZTmNFWGpiRm40dUdLblorc21rbDR5UnVCRVV2aUJGUzFvVERwaks5bXBsOWUx?= =?eucgb2312_cn?b?Q3lkblNPRk9sazRjcDl2dGRFc2huaGZlWE1hQWV0QTI4M25LeGE2SittUklWNmc2?= =?eucgb2312_cn?b?V0M5K085N0ZkQUxZZ05taHhFZjZwWjk1dU1kNU1xM2NlWStMd1ZBRjFxN3pCSVc5?= =?eucgb2312_cn?b?SGhHOXI0eWZRS2xxNGFuYkQwcHEwU3ZNNTNJWnR1ZzRUMkp6KytJcHBjSTVXYkVj?= =?eucgb2312_cn?b?N29XTlV2L21MVFRnRTNRLzVYOW9jN2R2VkhPRy9QT0Y0VWlaVVhYS1RLWmduaUcy?= =?eucgb2312_cn?b?V1k2dWY5S09RWGhHS0Y2dEx3UUQ1b2Rpd3FpOGdqZFFLVmFwRDRZS2RIZDd0ZEdv?= =?eucgb2312_cn?b?RWhrbFplcGptSW0yMmthK3Q0WitFRzhkMEZ2eThCZ08zRzlDUXJvNEQwcnAzV2FM?= =?eucgb2312_cn?b?Mi8zWjQ1U0YvYkwxd2RiN2RCM3BPUkNsMStoNFJjZG5keGpneFVzVHRpbWJaak4z?= =?eucgb2312_cn?b?UUhaMG1iUCtpajEwV2Q0ZE8wQ0Z1b3Q1TXFTalBYeTMzL1V5bUk4WVluZkFQQjRO?= =?eucgb2312_cn?b?L0ZhMXAvbXFyNkdoSzlOLzlFNmc9PQ==?= MIME-Version: 1.0 X-OriginatorOrg: fujitsu.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYCPR01MB9305.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 69b35b6e-0898-434e-8684-08da5d828f02 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jul 2022 06:00:55.2316 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a19f121d-81e1-4858-a9d8-736e267fd4c7 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: bHAYH8TYIQ+XxfNNd5LHOhx2phRDCk608Vo6Lf1E9AJK08/jiCU2AxIACNGFzFgVXtGSCqZb5d1g25RsFtoMrA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY1PR01MB1753 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Previously, if user space keeps sending abnormal wqe, queue.index will keep increasing while qp->req.wqe_index doesn't. Once qp->req.wqe_index==queue.index in next round, req_next_wqe() will treat queue as empty. In such case, no new completion would be generated. Update wqe_index for each wqe completion so that req_next_wqe() can get next wqe properly. Signed-off-by: Li Zhijian --- drivers/infiniband/sw/rxe/rxe_req.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/infiniband/sw/rxe/rxe_req.c b/drivers/infiniband/sw/rxe/rxe_req.c index 9d98237389cf..4ffc4ebd6e28 100644 --- a/drivers/infiniband/sw/rxe/rxe_req.c +++ b/drivers/infiniband/sw/rxe/rxe_req.c @@ -759,6 +759,8 @@ int rxe_requester(void *arg) if (ah) rxe_put(ah); err: + /* update wqe_index for each wqe completion */ + qp->req.wqe_index = queue_next_index(qp->sq.queue, qp->req.wqe_index); wqe->state = wqe_state_error; __rxe_do_task(&qp->comp.task);