From patchwork Tue Oct 18 04:33:33 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bob Pearson X-Patchwork-Id: 13009875 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62438C433FE for ; Tue, 18 Oct 2022 04:36:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229687AbiJREgS (ORCPT ); Tue, 18 Oct 2022 00:36:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229648AbiJREgR (ORCPT ); Tue, 18 Oct 2022 00:36:17 -0400 Received: from mail-oa1-x2b.google.com (mail-oa1-x2b.google.com [IPv6:2001:4860:4864:20::2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C3E76A0241 for ; Mon, 17 Oct 2022 21:36:16 -0700 (PDT) Received: by mail-oa1-x2b.google.com with SMTP id 586e51a60fabf-136b5dd6655so15617010fac.3 for ; Mon, 17 Oct 2022 21:36:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6QtHbx7j5MLEIzMsh4ikjKbKP5OllTIf9TzcOjs/vnc=; b=SQYozpljiYG6dY8y6PwLB/BLOuWmwHvRLZq9KK5GWxqwXY+0bYmqn5t9UgGB4MlFq7 9SlvlMttq7wKWFXz45iqayjizG71hDJlYt10LZWLPRFBrBjssHLGYGStBAefSyuiVHhW qh/K6/w4r5bL+aT7CnTx71Su023vsmDrcTb5T78XaNUOjyihf6Cjqn/hEpQ0IbjFta9A M+0VYOhgGib4+yXOMCvER1QuGX++OgAlbnlidYk8dvUDYWIH97v1UlqDPsOzf8wyrhsW cmwChBjXrn8IBGpD83hmTELwnqN9XfUn6sRLsj7Aa9sjftr2BEyIOzSJrdEBg2VOl7w4 uCvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6QtHbx7j5MLEIzMsh4ikjKbKP5OllTIf9TzcOjs/vnc=; b=57aJ91iW2lSN344lVGrXk57G9OfxxpqZBAQir9D70cv4inPFjfML9ALzGO8g/WT5IP vt6PNGecpizYQ1fqmcpfLUe60DzANKLNphd5/HURsEp6onknqCyt3ytzQoZWuk4riro6 xNB0MOCt7MqCa93e7kbxPmTDaPwc6id5cSnmLD/Y5VrHo3KSCb3MWIImo9RMCuEWf807 rtm0eJojOBoJtiIggqXvxxT303lXRRPd4bxsIX3Z9G2Rscd9bHXAVTyxvbCeTwNnIDhp W59gkjQPu3a9hbPkxkFdZea4iSukE9n2mrQead+BHWUX85hJv7ArRwSOBzmSd0V6x1D0 iXhA== X-Gm-Message-State: ACrzQf3I/NdiiljUFpYHUk+b9NnL2Wy0b4YkPjT/Lqc+7jdikKTW6rOc 3IOo7cQT3UCHfbJX+rIu7vE= X-Google-Smtp-Source: AMsMyM47iAB44hchj3MpvreNUmAnztMoQCgHa4anjpqiLFAD9Trdg1Xfig+n1n4hg543QbMM+FCBDw== X-Received: by 2002:a05:6870:b150:b0:131:c7a9:5d15 with SMTP id a16-20020a056870b15000b00131c7a95d15mr17180011oal.183.1666067776135; Mon, 17 Oct 2022 21:36:16 -0700 (PDT) Received: from ubuntu-22.tx.rr.com (2603-8081-140c-1a00-290b-8972-ce76-602c.res6.spectrum.com. [2603:8081:140c:1a00:290b:8972:ce76:602c]) by smtp.googlemail.com with ESMTPSA id e96-20020a9d01e9000000b006618ca5caa0sm5480333ote.78.2022.10.17.21.36.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Oct 2022 21:36:15 -0700 (PDT) From: Bob Pearson To: jgg@nvidia.com, zyjzyj2000@gmail.com, matsuda-daisuke@fujitsu.com, lizhijian@fujitsu.com, leon@kernel.org, linux-rdma@vger.kernel.org, jenny.hack@hpe.com, ian.ziemba@hpe.com Cc: Bob Pearson Subject: [PATCH for-next 02/16] RDMA/rxe: Removed unused name from rxe_task struct Date: Mon, 17 Oct 2022 23:33:33 -0500 Message-Id: <20221018043345.4033-3-rpearsonhpe@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221018043345.4033-1-rpearsonhpe@gmail.com> References: <20221018043345.4033-1-rpearsonhpe@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org The name field in struct rxe_task is never used. This patch removes it. Signed-off-by: Bob Pearson --- drivers/infiniband/sw/rxe/rxe_qp.c | 9 +++------ drivers/infiniband/sw/rxe/rxe_task.c | 4 +--- drivers/infiniband/sw/rxe/rxe_task.h | 4 +--- 3 files changed, 5 insertions(+), 12 deletions(-) diff --git a/drivers/infiniband/sw/rxe/rxe_qp.c b/drivers/infiniband/sw/rxe/rxe_qp.c index 57c3f05ad15b..03bd9f3e9956 100644 --- a/drivers/infiniband/sw/rxe/rxe_qp.c +++ b/drivers/infiniband/sw/rxe/rxe_qp.c @@ -238,10 +238,8 @@ static int rxe_qp_init_req(struct rxe_dev *rxe, struct rxe_qp *qp, skb_queue_head_init(&qp->req_pkts); - rxe_init_task(&qp->req.task, qp, - rxe_requester, "req"); - rxe_init_task(&qp->comp.task, qp, - rxe_completer, "comp"); + rxe_init_task(&qp->req.task, qp, rxe_requester); + rxe_init_task(&qp->comp.task, qp, rxe_completer); qp->qp_timeout_jiffies = 0; /* Can't be set for UD/UC in modify_qp */ if (init->qp_type == IB_QPT_RC) { @@ -288,8 +286,7 @@ static int rxe_qp_init_resp(struct rxe_dev *rxe, struct rxe_qp *qp, skb_queue_head_init(&qp->resp_pkts); - rxe_init_task(&qp->resp.task, qp, - rxe_responder, "resp"); + rxe_init_task(&qp->resp.task, qp, rxe_responder); qp->resp.opcode = OPCODE_NONE; qp->resp.msn = 0; diff --git a/drivers/infiniband/sw/rxe/rxe_task.c b/drivers/infiniband/sw/rxe/rxe_task.c index ec2b7de1c497..182d0532a8ab 100644 --- a/drivers/infiniband/sw/rxe/rxe_task.c +++ b/drivers/infiniband/sw/rxe/rxe_task.c @@ -94,12 +94,10 @@ void rxe_do_task(struct tasklet_struct *t) task->ret = ret; } -int rxe_init_task(struct rxe_task *task, - void *arg, int (*func)(void *), char *name) +int rxe_init_task(struct rxe_task *task, void *arg, int (*func)(void *)) { task->arg = arg; task->func = func; - snprintf(task->name, sizeof(task->name), "%s", name); task->destroyed = false; tasklet_setup(&task->tasklet, rxe_do_task); diff --git a/drivers/infiniband/sw/rxe/rxe_task.h b/drivers/infiniband/sw/rxe/rxe_task.h index 7f612a1c68a7..b3dfd970d1dc 100644 --- a/drivers/infiniband/sw/rxe/rxe_task.h +++ b/drivers/infiniband/sw/rxe/rxe_task.h @@ -25,7 +25,6 @@ struct rxe_task { void *arg; int (*func)(void *arg); int ret; - char name[16]; bool destroyed; }; @@ -34,8 +33,7 @@ struct rxe_task { * arg => parameter to pass to fcn * func => function to call until it returns != 0 */ -int rxe_init_task(struct rxe_task *task, - void *arg, int (*func)(void *), char *name); +int rxe_init_task(struct rxe_task *task, void *arg, int (*func)(void *)); /* cleanup task */ void rxe_cleanup_task(struct rxe_task *task);