From patchwork Wed Jun 26 10:26:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Dragos Tatulea X-Patchwork-Id: 13712568 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on2054.outbound.protection.outlook.com [40.107.96.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FD0B17B428; Wed, 26 Jun 2024 10:27:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.96.54 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719397639; cv=fail; b=hodthmYY6alLd3+dBQh+/9VJtsw9/d7ab60IPJTeeGXcNODe/zdxnTEFAMLKYnwcWWAoYmKbblD/2yow4KWarqoJvw5KeGH34rNwHUtpNXeBqp/z6jT6K5f26DAD1/UDha70UapKZls8D9ghK4tz+nKHcKUQPG88lZA+9N7LiAM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719397639; c=relaxed/simple; bh=Lrb09Cm5N5VK0SZvWT5VoPC7EZthINFRB2Q+ObRG548=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=M0PibmSVrehabcNazyCodOUOmhSV8MGpcYO+97C+Z8mdLsYeqnYJEitolM671YKC6lb+sHKwXNqjHrg2XnWbM/4HMZM5K6sAw77REFfjOH78LFBpJ1Q/Vk7lMQcEbkX/bI+bmd+V7xiXVFgOtjM4xJLPma4X+PDw0DzX/dZArEI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=IlLe7ycD; arc=fail smtp.client-ip=40.107.96.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="IlLe7ycD" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vu7GygdJAgATz7+RI70hR+BgOZMLEr7ABQ03f8eB6FGgEk2+po9dZAo4EwilrJAF+ESNtTSORJZge82nNhAuFzmSKv4gbjkuWaqJ3y1/CJqRh8C4H1425NnbXByza8UQwevCR3NXdm8PUBLzyXD9U5TpR38bEZ4i/9uzuR8swq7MY7tZCP6AZiHtP286pfXiK9d708Z38DqQKydV5TINkhjQcJQwRCQg3V/TGODqzyXERAnqy7rVt4mOnbmpvV6gzyd1IJzGB8GiUdSqbAP9AG1r+KUpsPFRGR0KtaRrp11AGDGqYW62hDpkbARHCXw5Lbmso4xZV9cIfZt7A4gKGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pYhkLZGkyT9zbQnqBmUACl4aJSi5TJazcHtqeL9j3gA=; b=gTsAn/DcX3bjcGMRsAFxn1WQaOsaYF3y/UVJVUb9hOCYOMhstXYCNBZt7PjUCssm+gRPmYCykfJfoYj+D0Orn5P4AjWiMs51ynCwZqpTVdL/cXXeVChrKEn2oB9CCd2WY7EtEo07xIpPeJlUJcCFwNCQW4UH1QxpBdOaj7iiFM4cIAxw/Y/HHuShXnPN+0bm6DNoN3OV317xSm9uUIX4usZasrx20XJw+oPfjDntaXZoVE5gs2gT5UARBfnO6IOZV7Q5VeuVu1c9E2Vdn06Lw9vQyfRSc2xcfzXn+ibr0QaKSOkiRPqQsQvY2dttEwoxFiTYelbHTtutTSSsrxvanQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pYhkLZGkyT9zbQnqBmUACl4aJSi5TJazcHtqeL9j3gA=; b=IlLe7ycDzbYBzxCWIctMWUJVppDmwYPC4swVbDNkSvQprF5VIR4ibkOzeCqhe1pyzSZ8iKwcsTOix/Gi/Fx43/nIoSsd5lB8i4CDuO0B82Yi8AgeFai//dm9YfEQdv3SPHCGQsEa5I0jeZifoddLvM7elU7NtCV9Y6H+hfqWvrDhtw/DJLi63S66kFoiwd/NMY4j0/0F2n6nK+Hq3hbV8HboSx309KUcx0YA6FQFh13ynAhId6gs4ZkVD77WiYfhql16x3wIA5NaYWoVNdVrpgJI0/XjmzdYvXg+F1n+ZgpicmR69oRZ7/JU0TFeVEFgKRw87bANVhDce30Um3ejBw== Received: from BL1PR13CA0438.namprd13.prod.outlook.com (2603:10b6:208:2c3::23) by CY5PR12MB6382.namprd12.prod.outlook.com (2603:10b6:930:3e::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7698.33; Wed, 26 Jun 2024 10:27:15 +0000 Received: from BL6PEPF00020E5F.namprd04.prod.outlook.com (2603:10b6:208:2c3:cafe::e1) by BL1PR13CA0438.outlook.office365.com (2603:10b6:208:2c3::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7719.22 via Frontend Transport; Wed, 26 Jun 2024 10:27:14 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BL6PEPF00020E5F.mail.protection.outlook.com (10.167.249.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.15 via Frontend Transport; Wed, 26 Jun 2024 10:27:14 +0000 Received: from rnnvmail205.nvidia.com (10.129.68.10) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Wed, 26 Jun 2024 03:26:59 -0700 Received: from rnnvmail205.nvidia.com (10.129.68.10) by rnnvmail205.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Wed, 26 Jun 2024 03:26:59 -0700 Received: from dev-l-177.mtl.labs.mlnx (10.127.8.11) by mail.nvidia.com (10.129.68.10) with Microsoft SMTP Server id 15.2.1544.4 via Frontend Transport; Wed, 26 Jun 2024 03:26:55 -0700 From: Dragos Tatulea Date: Wed, 26 Jun 2024 13:26:39 +0300 Subject: [PATCH vhost v2 03/24] vdpa/mlx5: Drop redundant code Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-ID: <20240626-stage-vdpa-vq-precreate-v2-3-560c491078df@nvidia.com> References: <20240626-stage-vdpa-vq-precreate-v2-0-560c491078df@nvidia.com> In-Reply-To: <20240626-stage-vdpa-vq-precreate-v2-0-560c491078df@nvidia.com> To: "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?utf-8?q?Eugenio_P=C3=A9rez?= , Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Si-Wei Liu CC: , , , , Cosmin Ratiu , Dragos Tatulea X-Mailer: b4 0.13.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF00020E5F:EE_|CY5PR12MB6382:EE_ X-MS-Office365-Filtering-Correlation-Id: c8056d13-2eae-4990-1f26-08dc95ca8c1e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230038|7416012|376012|1800799022|36860700011|82310400024; X-Microsoft-Antispam-Message-Info: =?utf-8?q?sWGnC0UfeiHdkfL6sPDKqCOKIDOorpZ?= =?utf-8?q?Y720KgqVAkmZzeOkoA4VLQKL82yA6sHGToSouRbWa3hIn7S+4+zk1LJLJCqkRsror?= =?utf-8?q?sPbD03DRXkRnKLXMAmBW6UYIovoVbF8/tQCPPGvVGS9kUy93FLzQIyN0tErr0YNgk?= =?utf-8?q?r6UwupdvtHcI+zScypRhcIN3LRgt2Am3pI/Mem5rhWpccmdOExQmykSp3FP3X7R8C?= =?utf-8?q?Iu8sHTPfxBeD7r59kPdZ1fFYDOXiW0uqujmM2xbhj/hJKQKtWpWNf5ZmkFXyII4TY?= =?utf-8?q?oYUMF38R3e8Lz3naeXHgNMduZnOMTYt7Oy6ve9wy40/KU5SoUl+Wps/9fipOBE7Nn?= =?utf-8?q?C6vYmAi1mnB1QxodsCMHwqvotZJ/1oe2kfESVETBZMp0IALfVaKU6fxefRe/vomo6?= =?utf-8?q?0PmTDYchzpx0uNvRTPDMZq/GIJaasR/p8kKLIk4TjE+tl12+SDVIPPjJCIAzN1RvZ?= =?utf-8?q?YHu9J4HyLivJ7K5xo6yxmSV6oyfHhPnzgKRVy1AdegAA2ZSMWXX590A2o5aLVR+pG?= =?utf-8?q?8Y2i6ZlOLfWCKm1DZzpze/8Vt4zAY7aTO8hLG9gr7x50NWr3cMOnotJFZ19/beivQ?= =?utf-8?q?MkYHnK5FAP4EejlbdboKCMy0YfkVgL9QJZtRQnLJ03a07QIYG4dLTKLHIfBW8eDXh?= =?utf-8?q?Qr/WnqUMjn8uCX/gzKw+np5eze0kiFd6FUcVPYGMiSQjdr0AKcbOOysbgtoVRBS1m?= =?utf-8?q?e+ZsdCza7VdWUFC67m1CIhiMoEZnNUzeZQVU8Xk+s7Ad7HOiuOZx8uNdTPO6hyhpM?= =?utf-8?q?GWC5EVcqA7vM7bOxYE0zKS3jvEQOWZLsmqjeZylGqbarBOPyxEXt2eqvyKA6F2v6H?= =?utf-8?q?8ULbOMWWCsGKmTJYE5vodCLoW8CC9Ff4X7u7ZRTgM/M7QRkKnLvxsRA+J8rFfXRn4?= =?utf-8?q?7dlh1yOx20Vk90Gqh46+i5Wrh0r1/nXrTQvGTwwNp4mpxMKfDUFcDCPthEiolcRaa?= =?utf-8?q?Q2C8ToRjDdT42DpQ8QumgcYJKEArNsIaCnMEz3W7p+r3veQkzfhkhV35r1FaK1d2C?= =?utf-8?q?Q9XUgx+NhK4HCZyCXzUdQtsQJShskiIUeDw5zsAoU41wowcRf/00F3aQB/kPPA9hR?= =?utf-8?q?rqHtydsluhTqd3sav/b+Q34+zef6faT0FMLykTNESxi5QEnghXkuMo/FR92OxXQal?= =?utf-8?q?eZO9OZ+vteloNLT7GQejbZsgG7CecT9eGJvFlIAGFBTBDJhZ/Yy0mQdqZZ4axKa5W?= =?utf-8?q?UUTHpRllEzvW/81LFX7+YTW7nUWO4yb+NNjILMuojrYilha+6f+99DYUmpwrXIoRl?= =?utf-8?q?HB0t8d1fBw6kQe3kdi7cdYvWq5ZLTHgz9jRj78Jc1JZb0wYpLdiUXWYrM+IAKPtpv?= =?utf-8?q?eoFT4M0xseWKJDP/F3V6UBkrQfxCAUXCvIpFkaPwHhmfDEI8msh5cRBQFpS8iSl1W?= =?utf-8?q?qjh+8ediEAd?= X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230038)(7416012)(376012)(1800799022)(36860700011)(82310400024);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jun 2024 10:27:14.4609 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c8056d13-2eae-4990-1f26-08dc95ca8c1e X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF00020E5F.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6382 Originally, the second loop initialized the CVQ. But (acde3929492b ("vdpa/mlx5: Use consistent RQT size") initialized all the queues in the first loop, so the second iteration in init_mvqs() is never called because the first one will iterate up to max_vqs. Reviewed-by: Cosmin Ratiu Acked-by: Eugenio Pérez Signed-off-by: Dragos Tatulea --- drivers/vdpa/mlx5/net/mlx5_vnet.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c index 1ad281cbc541..b4d9ef4f66c8 100644 --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c @@ -3519,12 +3519,6 @@ static void init_mvqs(struct mlx5_vdpa_net *ndev) mvq->fwqp.fw = true; mvq->fw_state = MLX5_VIRTIO_NET_Q_OBJECT_NONE; } - for (; i < ndev->mvdev.max_vqs; i++) { - mvq = &ndev->vqs[i]; - memset(mvq, 0, offsetof(struct mlx5_vdpa_virtqueue, ri)); - mvq->index = i; - mvq->ndev = ndev; - } } struct mlx5_vdpa_mgmtdev {