From patchwork Wed Jun 26 10:26:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Dragos Tatulea X-Patchwork-Id: 13712571 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2071.outbound.protection.outlook.com [40.107.92.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BA5A17F4FF; Wed, 26 Jun 2024 10:27:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.92.71 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719397649; cv=fail; b=UQJ9Dmrxhf31OxhbU0g8pLFlwkZ2HPI7rK7Grm3T56CUViXLSS9A/ph5jPOiPb5GEvRRzU4t+7Lv6JGjeRsrRZ7uJRXOws1zFKPkL6GIYCwQ34WAtGIDAgoy66NN0qwg7LApEGrpT6sbOjvFni9Pz/K54kXCARW4qypvQdoa/Fo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719397649; c=relaxed/simple; bh=7cjNJOBX9jeX49KRJhhB9Z878bN/YVyCDUsqS2Q2vy0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=XVJAf3OMqnMkNc8/1catF1zCBaZKGHEJup5e87D1/Onvt1/l4sCDwzGiS2Sff42hmHqrEo57r4RXQsJmJ0CGkn3KQn0EGLEDPlODvaRS1WgrPC8wagg8Ba3XzjsyLOqL++L7i6P+VN3PGsfZLyA53CIrWqlRXOXZZtNTSynEfso= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=HG2L2mxj; arc=fail smtp.client-ip=40.107.92.71 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="HG2L2mxj" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IqpwG6K/c5gUjRtydmjLeMrV5hmC5a/xdnrhb7AT4l4A9YuESQ3YR0lTMJ8zpQQ3k5WC2TX0h4KBy35xvDyFsHL+g7y/OR6K2DTHwBA/8OwqFsF9+QJyLrBTC1xszzCasDda9MJ7RlP6twbrIOdOc8FEoay96Hdk2vCSPztdytcxFu8T859x6xqdXl+6JnBBr1zwM5e8Xf+Ze2m+X489iZ9zbswLLYyKcJF2QnygpCi4SzBRjxXS3xb+nhHzE4XosPbx9JtGF0pABDYxo35WkgYenVwBTogVhwSq/cIZdQBAjIIH9rhbruUOEhb1L9XOYI8lT/pF3T7Faea6d+7EWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s6+plDX3Exdv64qzQokta757NaNYI3PsLvLf/wcUoQA=; b=GORQCfWqTS/zavoIJbVu28WkmPNyYt1rorI4k7x9W6/Iy+eSBOtzGeQLs8duR7oowJX0lcdfb3IcXyuKzVzSs5/5C0vfccXCWqgIyyoNp0NHCVeg3oysdau2/PreOSVDE7oiVRzqJWpw8AEGvn2Jo4MMdaw6Ma4HPb1AekA+DuK8++NOg3+yKStun28HqOWdBgXXRTYXkN1BaLi/2I6VZlTAVHHZvxB2eoH/UCaYCLQju5FEhf9cr3bJTDdAQbf0uptbPprtgPsUSd1y6Q2k3onBs4ArSjm22k/93Y1ew6bIWoR5vi6XcDiqZ5gjkEPcN8DEV8noVqWp2ikXuDU4CQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s6+plDX3Exdv64qzQokta757NaNYI3PsLvLf/wcUoQA=; b=HG2L2mxj7ocXXBwMaTZUzzA1mqGMjywHuRCjfbTxoIcjB+wHMlMc9SgEYGbSEWMnQJAQNXoSHBv2z+u8HM3Xypfy5VzDQ5Q29bckHJ23KQx3JBDyhW+nuChCIKy3dYNutOj6SBn3KsYsWGseN8CaDJu6hF2EQTIsq8C/qhJR4eBJ6NBTebyu9gyfyQXm1V/mUMoqj5tOdUcm3h6NqUFFMGtBtQrCYVYA45EXy2sWk2CjvSq0JVeha4/8McynQF3cvIuRPKNROaM4RO8AFv7TnZpUMrS+bGkj5ZAzqW7pD9fNCI4oMku4tgZUppfKmADnjsknIBu6kU440QW11BfWeQ== Received: from MN2PR04CA0031.namprd04.prod.outlook.com (2603:10b6:208:d4::44) by PH7PR12MB7018.namprd12.prod.outlook.com (2603:10b6:510:1b8::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7698.30; Wed, 26 Jun 2024 10:27:24 +0000 Received: from BL6PEPF00020E62.namprd04.prod.outlook.com (2603:10b6:208:d4:cafe::3b) by MN2PR04CA0031.outlook.office365.com (2603:10b6:208:d4::44) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7719.22 via Frontend Transport; Wed, 26 Jun 2024 10:27:24 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BL6PEPF00020E62.mail.protection.outlook.com (10.167.249.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.15 via Frontend Transport; Wed, 26 Jun 2024 10:27:24 +0000 Received: from rnnvmail204.nvidia.com (10.129.68.6) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Wed, 26 Jun 2024 03:27:11 -0700 Received: from rnnvmail205.nvidia.com (10.129.68.10) by rnnvmail204.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Wed, 26 Jun 2024 03:27:11 -0700 Received: from dev-l-177.mtl.labs.mlnx (10.127.8.11) by mail.nvidia.com (10.129.68.10) with Microsoft SMTP Server id 15.2.1544.4 via Frontend Transport; Wed, 26 Jun 2024 03:27:08 -0700 From: Dragos Tatulea Date: Wed, 26 Jun 2024 13:26:42 +0300 Subject: [PATCH vhost v2 06/24] vdpa/mlx5: Remove duplicate suspend code Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-ID: <20240626-stage-vdpa-vq-precreate-v2-6-560c491078df@nvidia.com> References: <20240626-stage-vdpa-vq-precreate-v2-0-560c491078df@nvidia.com> In-Reply-To: <20240626-stage-vdpa-vq-precreate-v2-0-560c491078df@nvidia.com> To: "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?utf-8?q?Eugenio_P=C3=A9rez?= , Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Si-Wei Liu CC: , , , , Cosmin Ratiu , Dragos Tatulea X-Mailer: b4 0.13.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF00020E62:EE_|PH7PR12MB7018:EE_ X-MS-Office365-Filtering-Correlation-Id: eea3f7e0-6782-4a62-f440-08dc95ca91ea X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230038|36860700011|376012|7416012|1800799022|82310400024; X-Microsoft-Antispam-Message-Info: =?utf-8?q?qOT9gpvVCH3lOSNZR+zdBUZMHtzoYHF?= =?utf-8?q?p+kYlW51b9kliw5PT4Vfzbln307ts69aWvR6pImAYiICPeFyEu/r3J9Vmy/4ShNag?= =?utf-8?q?MCOKiACvw2cVE75D/BV4EEQ9yKoZLj8F1K+h/srjjVRvWR1Qgc6eCZI7jPND8jQ8C?= =?utf-8?q?R2eraayKG+a88k0bT4tbvYRMhZumbdrssCpMdAvFuhnYcWuZSTymOMiTjWWZTJVEu?= =?utf-8?q?395g9nvCYMaFzuUIGyKOBP8UsPbfBNeszZgJdBgTBebYDYS2X/VebQFh8N0ivPN8a?= =?utf-8?q?6knwctQtxPL2xH9hjbGZM1C202247M1TgwolBFh7Uu/IR+J83awxq+RGB+HDSH3u/?= =?utf-8?q?E22uQMA1hBzfJe1R5yPDhPeDF+m3U8i3IQiTy5bzm+ceZQrPyyWMNMhDga5GB+7cf?= =?utf-8?q?C4g7zFErBMLLD3Sg/mo2UVrot4qB/YaPv8ExK0U7Ladl3e9WJsbahng6HeicI5OCn?= =?utf-8?q?SwXcKtzMynCgDEK6lilRvLVuyC0Wfg+6eq5vX4r2JvjBgzFJ8JcUOLXz+rkPnIUCH?= =?utf-8?q?X265P/bFehCLzLu0id9qx/H4B6l7hnM+AsjoE5BlGv7vWtO5N7/62y1V858FmmY8B?= =?utf-8?q?THPFtRc4tVInipokUPqP/806PNnBLH8D3YRwC4h2o3k2q/JKyF3iPOfjehbn9utKy?= =?utf-8?q?4G12pISnZQXBzKVByx7+Wz/2I+3Yo6Y4QMIDCTv4V1VrClmtGUjjUfGt0lOErDiU8?= =?utf-8?q?7eWGdmNHalQi03RgSPZ8hbtyGMoaZJS/xT+jVX/veCk/37ruDybWDOV2glESzQ+am?= =?utf-8?q?wR3nw4C/6cHqwGZuVh+pJcAoxFh4wUvdV15CYBo/fJkYCBvx8AaanpvXypaRSmRud?= =?utf-8?q?FyxER7cnl6yKmfT3dfM1Q8yVDcCWc3mKyAqPIvhljf8N+HzowWbmTAfQLFb6qLqvk?= =?utf-8?q?GOvDp9zwyR66wcfrcKxzHlbwPWHFOsupNpDwvL98RtQfeedIbxQtaKLOkfOUFbcfr?= =?utf-8?q?vAg3chYdW0X3N5ZrF190JA9uE+z0yxMqpDmtwylUkZXqqbuENye/bEGKMNiTFgGVR?= =?utf-8?q?GU0DR7X+WzpibwJ6xB47rVqj6dc7i/8a75EYD7yW4x3CANuqFCp/GSEVmkAz+gc9X?= =?utf-8?q?6CmqINxh59dJhUf2wg8ZApUVYsAPedf1dg6tCcRKN+hZq25EMcrNmMuzpFGEVWaPw?= =?utf-8?q?r7wJvuHyojD4WLIx3bPKdmnpymSmQYnUtZ6/FkINGWTgimuOHano6g00yTsJWvLZW?= =?utf-8?q?w/RwJGUgjCr3lQZlUOeQHoKjREzMRcS8mR7YieJxzjqlgeMDrJDnK/oI+xbGvxDFC?= =?utf-8?q?2gu276VuMD8j8y9TEO7tJrsFRopJ66SKjHjEEq7+eYgkyacFK2Q3au7I5yuEI49zq?= =?utf-8?q?RZyFF5tYxRrewXu/r9ZuhPulJ4DJgqZ6uQ=3D=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230038)(36860700011)(376012)(7416012)(1800799022)(82310400024);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jun 2024 10:27:24.1607 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: eea3f7e0-6782-4a62-f440-08dc95ca91ea X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF00020E62.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7018 Use the dedicated suspend_vqs() function instead. Reviewed-by: Cosmin Ratiu Reviewed-by: Eugenio Pérez Signed-off-by: Dragos Tatulea --- drivers/vdpa/mlx5/net/mlx5_vnet.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c index 51630b1935f4..eca6f68c2eda 100644 --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c @@ -3355,17 +3355,12 @@ static int mlx5_vdpa_suspend(struct vdpa_device *vdev) { struct mlx5_vdpa_dev *mvdev = to_mvdev(vdev); struct mlx5_vdpa_net *ndev = to_mlx5_vdpa_ndev(mvdev); - struct mlx5_vdpa_virtqueue *mvq; - int i; mlx5_vdpa_info(mvdev, "suspending device\n"); down_write(&ndev->reslock); unregister_link_notifier(ndev); - for (i = 0; i < ndev->cur_num_vqs; i++) { - mvq = &ndev->vqs[i]; - suspend_vq(ndev, mvq); - } + suspend_vqs(ndev); mlx5_vdpa_cvq_suspend(mvdev); mvdev->suspended = true; up_write(&ndev->reslock);