[vhost,v3,09/24] vdpa/mlx5: Rename init_mvqs

Message ID	20240708-stage-vdpa-vq-precreate-v3-9-afe3c766e393@nvidia.com (mailing list archive)
State	Not Applicable
Headers	show Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2069.outbound.protection.outlook.com [40.107.244.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BDD681204; Mon, 8 Jul 2024 12:02:00 +0000 (UTC) Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C From: Dragos Tatulea <dtatulea@nvidia.com> Date: Mon, 8 Jul 2024 15:00:33 +0300 Subject: [PATCH vhost v3 09/24] vdpa/mlx5: Rename init_mvqs Precedence: bulk MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-ID: <20240708-stage-vdpa-vq-precreate-v3-9-afe3c766e393@nvidia.com> References: <20240708-stage-vdpa-vq-precreate-v3-0-afe3c766e393@nvidia.com> In-Reply-To: <20240708-stage-vdpa-vq-precreate-v3-0-afe3c766e393@nvidia.com> To: "Michael S. Tsirkin" <mst@redhat.com>, Jason Wang <jasowang@redhat.com>, Xuan Zhuo <xuanzhuo@linux.alibaba.com>, =?utf-8?q?Eugenio_P=C3=A9rez?= <eperezma@redhat.com>, Saeed Mahameed <saeedm@nvidia.com>, Leon Romanovsky <leon@kernel.org>, Tariq Toukan <tariqt@nvidia.com>, Si-Wei Liu <si-wei.liu@oracle.com> CC: <virtualization@lists.linux.dev>, <linux-kernel@vger.kernel.org>, <linux-rdma@vger.kernel.org>, <netdev@vger.kernel.org>, Dragos Tatulea <dtatulea@nvidia.com>
Series	vdpa/mlx5: Pre-create HW VQs to reduce LM downtime \| expand [vhost,v3,00/24] vdpa/mlx5: Pre-create HW VQs to reduce LM downtime [vhost,v3,01/24] vdpa/mlx5: Clarify meaning thorough function rename [vhost,v3,02/24] vdpa/mlx5: Make setup/teardown_vq_resources() symmetrical [vhost,v3,03/24] vdpa/mlx5: Drop redundant code [vhost,v3,04/24] vdpa/mlx5: Drop redundant check in teardown_virtqueues() [vhost,v3,05/24] vdpa/mlx5: Iterate over active VQs during suspend/resume [vhost,v3,06/24] vdpa/mlx5: Remove duplicate suspend code [vhost,v3,07/24] vdpa/mlx5: Initialize and reset device with one queue pair [vhost,v3,08/24] vdpa/mlx5: Clear and reinitialize software VQ data on reset [vhost,v3,09/24] vdpa/mlx5: Rename init_mvqs [vhost,v3,10/24] vdpa/mlx5: Add support for modifying the virtio_version VQ field [vhost,v3,11/24] vdpa/mlx5: Add support for modifying the VQ features field [vhost,v3,12/24] vdpa/mlx5: Set an initial size on the VQ [vhost,v3,13/24] vdpa/mlx5: Start off rqt_size with max VQPs [vhost,v3,14/24] vdpa/mlx5: Set mkey modified flags on all VQs [vhost,v3,15/24] vdpa/mlx5: Allow creation of blank VQs [vhost,v3,16/24] vdpa/mlx5: Accept Init -> Ready VQ transition in resume_vq() [vhost,v3,17/24] vdpa/mlx5: Add error code for suspend/resume VQ [vhost,v3,18/24] vdpa/mlx5: Consolidate all VQ modify to Ready to use resume_vq() [vhost,v3,19/24] vdpa/mlx5: Forward error in suspend/resume device [vhost,v3,20/24] vdpa/mlx5: Use suspend/resume during VQP change [vhost,v3,21/24] vdpa/mlx5: Pre-create hardware VQs at vdpa .dev_add time [vhost,v3,22/24] vdpa/mlx5: Re-create HW VQs under certain conditions [vhost,v3,23/24] vdpa/mlx5: Don't reset VQs more than necessary [vhost,v3,24/24] vdpa/mlx5: Don't enable non-active VQs in .set_vq_ready()

Message ID

20240708-stage-vdpa-vq-precreate-v3-9-afe3c766e393@nvidia.com (mailing list archive)

State

Not Applicable

Headers

Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates
 216.228.117.161 as permitted sender) receiver=protection.outlook.com;
 client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C
From: Dragos Tatulea <dtatulea@nvidia.com>
Date: Mon, 8 Jul 2024 15:00:33 +0300
Subject: [PATCH vhost v3 09/24] vdpa/mlx5: Rename init_mvqs
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Message-ID: <20240708-stage-vdpa-vq-precreate-v3-9-afe3c766e393@nvidia.com>
References: <20240708-stage-vdpa-vq-precreate-v3-0-afe3c766e393@nvidia.com>
In-Reply-To: <20240708-stage-vdpa-vq-precreate-v3-0-afe3c766e393@nvidia.com>
To: "Michael S. Tsirkin" <mst@redhat.com>, Jason Wang <jasowang@redhat.com>,
 Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
 =?utf-8?q?Eugenio_P=C3=A9rez?= <eperezma@redhat.com>,
 Saeed Mahameed <saeedm@nvidia.com>, Leon Romanovsky <leon@kernel.org>,
 Tariq Toukan <tariqt@nvidia.com>, Si-Wei Liu <si-wei.liu@oracle.com>
CC: <virtualization@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
	<linux-rdma@vger.kernel.org>, <netdev@vger.kernel.org>, Dragos Tatulea
	<dtatulea@nvidia.com>
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2024 12:01:57.5730
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 
 8380f6ff-d29a-4da9-fbdb-08dc9f45c47d
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: 
 TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com]
X-MS-Exchange-CrossTenant-AuthSource: 
	BL6PEPF0001AB72.namprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8182

Series

vdpa/mlx5: Pre-create HW VQs to reduce LM downtime | expand

Commit Message

Dragos Tatulea July 8, 2024, noon UTC

Function is used to set default values, so name it accordingly.

Reviewed-by: Eugenio Pérez <eperezma@redhat.com>
Signed-off-by: Dragos Tatulea <dtatulea@nvidia.com>
---
 drivers/vdpa/mlx5/net/mlx5_vnet.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c
index de013b5a2815..739c2886fc33 100644
--- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
+++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
@@ -155,7 +155,7 @@  static bool is_index_valid(struct mlx5_vdpa_dev *mvdev, u16 idx)
 }
 
 static void free_fixed_resources(struct mlx5_vdpa_net *ndev);
-static void init_mvqs(struct mlx5_vdpa_net *ndev);
+static void mvqs_set_defaults(struct mlx5_vdpa_net *ndev);
 static int setup_vq_resources(struct mlx5_vdpa_net *ndev);
 static void teardown_vq_resources(struct mlx5_vdpa_net *ndev);
 
@@ -2810,7 +2810,7 @@  static void restore_channels_info(struct mlx5_vdpa_net *ndev)
 	int i;
 
 	mlx5_clear_vqs(ndev);
-	init_mvqs(ndev);
+	mvqs_set_defaults(ndev);
 	for (i = 0; i < ndev->mvdev.max_vqs; i++) {
 		mvq = &ndev->vqs[i];
 		ri = &mvq->ri;
@@ -3023,7 +3023,7 @@  static int mlx5_vdpa_compat_reset(struct vdpa_device *vdev, u32 flags)
 	down_write(&ndev->reslock);
 	unregister_link_notifier(ndev);
 	teardown_vq_resources(ndev);
-	init_mvqs(ndev);
+	mvqs_set_defaults(ndev);
 
 	if (flags & VDPA_RESET_F_CLEAN_MAP)
 		mlx5_vdpa_destroy_mr_resources(&ndev->mvdev);
@@ -3485,7 +3485,7 @@  static void free_fixed_resources(struct mlx5_vdpa_net *ndev)
 	res->valid = false;
 }
 
-static void init_mvqs(struct mlx5_vdpa_net *ndev)
+static void mvqs_set_defaults(struct mlx5_vdpa_net *ndev)
 {
 	struct mlx5_vdpa_virtqueue *mvq;
 	int i;
@@ -3635,7 +3635,7 @@  static int mlx5_vdpa_dev_add(struct vdpa_mgmt_dev *v_mdev, const char *name,
 	}
 	ndev->cur_num_vqs = MLX5V_DEFAULT_VQ_COUNT;
 
-	init_mvqs(ndev);
+	mvqs_set_defaults(ndev);
 	allocate_irqs(ndev);
 	init_rwsem(&ndev->reslock);
 	config = &ndev->config;

[vhost,v3,09/24] vdpa/mlx5: Rename init_mvqs

Commit Message

Patch