diff mbox series

[PATCH-next] RDMA/erdma: Fix opcode conditional check

Message ID 20241219043939.10344-1-advaitdhamorikar@gmail.com (mailing list archive)
State Accepted
Headers show
Series [PATCH-next] RDMA/erdma: Fix opcode conditional check | expand

Commit Message

Advait Dhamorikar Dec. 19, 2024, 4:39 a.m. UTC 
Fix conditional if else check by checking with wr->opcode.
The indicated dead code may have performed some action; that
action will never occur as op is pre-assigned a different value.

Signed-off-by: Advait Dhamorikar <advaitdhamorikar@gmail.com>
---
 drivers/infiniband/hw/erdma/erdma_qp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Cheng Xu Dec. 19, 2024, 5:40 a.m. UTC | #1 
On 12/19/24 12:39 PM, Advait Dhamorikar wrote:
> Fix conditional if else check by checking with wr->opcode.
> The indicated dead code may have performed some action; that
> action will never occur as op is pre-assigned a different value.
> 
> Signed-off-by: Advait Dhamorikar <advaitdhamorikar@gmail.com>
> ---
>  drivers/infiniband/hw/erdma/erdma_qp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Reviewed-by: Cheng Xu <chengyou@linux.alibaba.com>

Thanks very much,
Cheng Xu

> diff --git a/drivers/infiniband/hw/erdma/erdma_qp.c b/drivers/infiniband/hw/erdma/erdma_qp.c
> index 4dfb4272ad86..5c266918fb36 100644
> --- a/drivers/infiniband/hw/erdma/erdma_qp.c
> +++ b/drivers/infiniband/hw/erdma/erdma_qp.c
> @@ -406,7 +406,7 @@ static void init_send_sqe_rc(struct erdma_qp *qp, struct erdma_send_sqe_rc *sqe,
>  	if (wr->opcode == IB_WR_SEND_WITH_IMM) {
>  		op = ERDMA_OP_SEND_WITH_IMM;
>  		sqe->imm_data = wr->ex.imm_data;
> -	} else if (op == IB_WR_SEND_WITH_INV) {
> +	} else if (wr->opcode == IB_WR_SEND_WITH_INV) {
>  		op = ERDMA_OP_SEND_WITH_INV;
>  		sqe->invalid_stag = cpu_to_le32(wr->ex.invalidate_rkey);
>  	}
Leon Romanovsky Dec. 19, 2024, 12:16 p.m. UTC | #2 
On Thu, 19 Dec 2024 10:09:39 +0530, Advait Dhamorikar wrote:
> Fix conditional if else check by checking with wr->opcode.
> The indicated dead code may have performed some action; that
> action will never occur as op is pre-assigned a different value.
> 
> 

Applied, thanks!

[1/1] RDMA/erdma: Fix opcode conditional check
      https://git.kernel.org/rdma/rdma/c/c57c76498a895a

Best regards,
diff mbox series

Patch

diff --git a/drivers/infiniband/hw/erdma/erdma_qp.c b/drivers/infiniband/hw/erdma/erdma_qp.c
index 4dfb4272ad86..5c266918fb36 100644
--- a/drivers/infiniband/hw/erdma/erdma_qp.c
+++ b/drivers/infiniband/hw/erdma/erdma_qp.c
@@ -406,7 +406,7 @@  static void init_send_sqe_rc(struct erdma_qp *qp, struct erdma_send_sqe_rc *sqe,
 	if (wr->opcode == IB_WR_SEND_WITH_IMM) {
 		op = ERDMA_OP_SEND_WITH_IMM;
 		sqe->imm_data = wr->ex.imm_data;
-	} else if (op == IB_WR_SEND_WITH_INV) {
+	} else if (wr->opcode == IB_WR_SEND_WITH_INV) {
 		op = ERDMA_OP_SEND_WITH_INV;
 		sqe->invalid_stag = cpu_to_le32(wr->ex.invalidate_rkey);
 	}