| Message ID | 2bbe900e-18b3-46b5-a08c-42eb71886da6@stanley.mountain (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [next] RDMA/mana_ib: Fix error code in probe() | expand |
> Return -ENOMEM if dma_pool_create() fails. Don't return success. > > Fixes: df91c470d9e5 ("RDMA/mana_ib: create/destroy AH") > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Thank you! Reviewed-by: Long Li <longli@microsoft.com> > --- > drivers/infiniband/hw/mana/device.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/infiniband/hw/mana/device.c > b/drivers/infiniband/hw/mana/device.c > index 0a7553f819ba..a17e7a6b0545 100644 > --- a/drivers/infiniband/hw/mana/device.c > +++ b/drivers/infiniband/hw/mana/device.c > @@ -144,8 +144,10 @@ static int mana_ib_probe(struct auxiliary_device *adev, > > dev->av_pool = dma_pool_create("mana_ib_av", mdev->gdma_context- > >dev, > MANA_AV_BUFFER_SIZE, > MANA_AV_BUFFER_SIZE, 0); > - if (!dev->av_pool) > + if (!dev->av_pool) { > + ret = -ENOMEM; > goto destroy_rnic; > + } > > ret = ib_register_device(&dev->ib_dev, "mana_%d", > mdev->gdma_context->dev); > -- > 2.47.2
On Fri, 07 Feb 2025 12:16:03 +0300, Dan Carpenter wrote: > Return -ENOMEM if dma_pool_create() fails. Don't return success. > > Applied, thanks! [1/1] RDMA/mana_ib: Fix error code in probe() https://git.kernel.org/rdma/rdma/c/607a7dcf2e9814 Best regards,
diff --git a/drivers/infiniband/hw/mana/device.c b/drivers/infiniband/hw/mana/device.c index 0a7553f819ba..a17e7a6b0545 100644 --- a/drivers/infiniband/hw/mana/device.c +++ b/drivers/infiniband/hw/mana/device.c @@ -144,8 +144,10 @@ static int mana_ib_probe(struct auxiliary_device *adev, dev->av_pool = dma_pool_create("mana_ib_av", mdev->gdma_context->dev, MANA_AV_BUFFER_SIZE, MANA_AV_BUFFER_SIZE, 0); - if (!dev->av_pool) + if (!dev->av_pool) { + ret = -ENOMEM; goto destroy_rnic; + } ret = ib_register_device(&dev->ib_dev, "mana_%d", mdev->gdma_context->dev);
Return -ENOMEM if dma_pool_create() fails. Don't return success. Fixes: df91c470d9e5 ("RDMA/mana_ib: create/destroy AH") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> --- drivers/infiniband/hw/mana/device.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)