| Message ID | 3c523c58a8e3f3d240d4ff9363d672fb977c9d93.1533675546.git.gustavo@embeddedor.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | net: ethernet: Mark expected switch fall-throughs | expand |
On Tue, Aug 7, 2018 at 4:25 PM, Gustavo A. R. Silva <gustavo@embeddedor.com> wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Addresses-Coverity-ID: 114808 ("Missing break in switch") > Addresses-Coverity-ID: 114802 ("Missing break in switch") > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Acked-by: Saeed Mahameed <saeedm@mellanox.com> > --- > drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c b/drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c > index 1881468..ad6d471 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c > @@ -91,9 +91,11 @@ bool mlx5e_xdp_handle(struct mlx5e_rq *rq, struct mlx5e_dma_info *di, > return true; > default: > bpf_warn_invalid_xdp_action(act); > + /* fall through */ > case XDP_ABORTED: > xdp_abort: > trace_xdp_exception(rq->netdev, prog, act); > + /* fall through */ > case XDP_DROP: > rq->stats->xdp_drop++; > return true; > -- > 2.7.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c b/drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c index 1881468..ad6d471 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c @@ -91,9 +91,11 @@ bool mlx5e_xdp_handle(struct mlx5e_rq *rq, struct mlx5e_dma_info *di, return true; default: bpf_warn_invalid_xdp_action(act); + /* fall through */ case XDP_ABORTED: xdp_abort: trace_xdp_exception(rq->netdev, prog, act); + /* fall through */ case XDP_DROP: rq->stats->xdp_drop++; return true;
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 114808 ("Missing break in switch") Addresses-Coverity-ID: 114802 ("Missing break in switch") Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> --- drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c | 2 ++ 1 file changed, 2 insertions(+)