| Message ID | 47050fe9f6f26f11fc14ff0ac06547f73ec3b81e.camel@oracle.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [1/1] net/rds: Use "unpin_user_page" as "pin_user_pages" counterpart | expand |
On 4/6/22 14:03, Gerd Rausch wrote: > In cases where "pin_user_pages" was used to obtain longerm references, > the pages must be released with "unpin_user_pages". > > Fixes: 0d4597c8c5ab ("net/rds: Track user mapped pages through special API") > Signed-off-by: Gerd Rausch <gerd.rausch@oracle.com> Reviewed-by: Sharath Srinivasan <sharath.srinivasan@oracle.com> Regards, Sharath > --- > net/rds/ib_rdma.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/net/rds/ib_rdma.c b/net/rds/ib_rdma.c > index 8f070ee7e742..9d86d6db98c4 100644 > --- a/net/rds/ib_rdma.c > +++ b/net/rds/ib_rdma.c > @@ -256,8 +256,7 @@ void __rds_ib_teardown_mr(struct rds_ib_mr *ibmr) > /* FIXME we need a way to tell a r/w MR > * from a r/o MR */ > WARN_ON(!page->mapping && irqs_disabled()); > - set_page_dirty(page); > - put_page(page); > + unpin_user_pages_dirty_lock(&page, 1, true); > } > kfree(ibmr->sg); > >
On Wed, 06 Apr 2022 14:03:05 -0700 Gerd Rausch wrote: > In cases where "pin_user_pages" was used to obtain longerm references, > the pages must be released with "unpin_user_pages". > > Fixes: 0d4597c8c5ab ("net/rds: Track user mapped pages through special API") > Signed-off-by: Gerd Rausch <gerd.rausch@oracle.com> You must CC authors of the commit under Fixes. Please repost.
On Wed, Apr 06, 2022 at 02:03:05PM -0700, Gerd Rausch wrote: > In cases where "pin_user_pages" was used to obtain longerm references, > the pages must be released with "unpin_user_pages". > > Fixes: 0d4597c8c5ab ("net/rds: Track user mapped pages through special API") > Signed-off-by: Gerd Rausch <gerd.rausch@oracle.com> > --- > net/rds/ib_rdma.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Jason Gunthorpe <jgg@nvidia.com> Jason
diff --git a/net/rds/ib_rdma.c b/net/rds/ib_rdma.c index 8f070ee7e742..9d86d6db98c4 100644 --- a/net/rds/ib_rdma.c +++ b/net/rds/ib_rdma.c @@ -256,8 +256,7 @@ void __rds_ib_teardown_mr(struct rds_ib_mr *ibmr) /* FIXME we need a way to tell a r/w MR * from a r/o MR */ WARN_ON(!page->mapping && irqs_disabled()); - set_page_dirty(page); - put_page(page); + unpin_user_pages_dirty_lock(&page, 1, true); } kfree(ibmr->sg);
In cases where "pin_user_pages" was used to obtain longerm references, the pages must be released with "unpin_user_pages". Fixes: 0d4597c8c5ab ("net/rds: Track user mapped pages through special API") Signed-off-by: Gerd Rausch <gerd.rausch@oracle.com> --- net/rds/ib_rdma.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)