From patchwork Thu Oct 22 23:08:54 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vu Pham X-Patchwork-Id: 55472 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n9MN8wlc019218 for ; Thu, 22 Oct 2009 23:08:58 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751120AbZJVXIw (ORCPT ); Thu, 22 Oct 2009 19:08:52 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750863AbZJVXIw (ORCPT ); Thu, 22 Oct 2009 19:08:52 -0400 Received: from p02c12o146.mxlogic.net ([208.65.145.79]:51682 "EHLO p02c12o146.mxlogic.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750758AbZJVXIv (ORCPT ); Thu, 22 Oct 2009 19:08:51 -0400 Received: from unknown [63.251.237.3] (EHLO mtiexch01.mti.com) by p02c12o146.mxlogic.net(mxl_mta-6.4.0-1) with ESMTP id 606e0ea4.0.105882.00-003.230671.p02c12o146.mxlogic.net (envelope-from ); Thu, 22 Oct 2009 17:08:56 -0600 (MDT) X-MXL-Hash: 4ae0e6082e32525c-7150f1d7f2db4852bdbdd50517434f085bf9ffd8 Received: from [10.2.1.145] ([10.2.1.145]) by mtiexch01.mti.com with Microsoft SMTPSVC(6.0.3790.3959); Thu, 22 Oct 2009 16:11:44 -0700 Message-ID: <4AE0E606.6090805@mellanox.com> Date: Thu, 22 Oct 2009 16:08:54 -0700 From: Vu Pham User-Agent: Thunderbird 2.0.0.23 (Windows/20090812) MIME-Version: 1.0 To: Roland Dreier CC: Linux RDMA list Subject: Re: [ofa-general][PATCH 2/4] SRP fail-over faster References: <4AD3B443.7040107@mellanox.com> <4AD62D9D.1020900@mellanox.com> In-Reply-To: X-OriginalArrivalTime: 22 Oct 2009 23:11:44.0515 (UTC) FILETIME=[05AB8D30:01CA536D] X-Spam: [F=0.2000000000; CM=0.500; S=0.200(2009101401)] X-MAIL-FROM: X-SOURCE-IP: [63.251.237.3] X-AnalysisOut: [v=1.0 c=1 a=U4YpQQfJ8bEA:10 a=xupnbh4h0YLOHZnncC45HQ==:17 ] X-AnalysisOut: [a=fML16yHk8rPra-aomREA:9 a=ANjx3f7koNzs_ly5P5TkPS7YagYA:4 ] X-AnalysisOut: [a=CbDCq_QkAAAA:8 a=T-MVoIjafskBWSHodS8A:9 a=Y6Yb9hZksyV0xA] X-AnalysisOut: [8DvhAA:7 a=ySnZgUVoFp0v6EgybhAub11GdqgA:4 a=E3yz0KKPV6YA:1] X-AnalysisOut: [0] Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c index 54c8fe2..dfa14de 100644 --- a/drivers/infiniband/ulp/srp/ib_srp.c +++ b/drivers/infiniband/ulp/srp/ib_srp.c @@ -415,13 +415,11 @@ static void srp_disconnect_target(struct srp_target_port *target) { /* XXX should send SRP_I_LOGOUT request */ - init_completion(&target->done); if (ib_send_cm_dreq(target->cm_id, NULL, 0)) { shost_printk(KERN_DEBUG, target->scsi_host, PFX "Sending CM DREQ failed\n"); return; } - wait_for_completion(&target->done); } static void srp_remove_work(struct work_struct *work) @@ -1301,7 +1299,6 @@ static int srp_cm_handler(struct ib_cm_id *cm_id, struct ib_cm_event *event) shost_printk(KERN_ERR, target->scsi_host, PFX "connection closed\n"); - comp = 1; target->status = 0; break;