From patchwork Fri Apr 22 18:19:12 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Schutt X-Patchwork-Id: 727831 X-Patchwork-Delegate: alexne@voltaire.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p3MIJcle028852 for ; Fri, 22 Apr 2011 18:19:38 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755894Ab1DVSTh (ORCPT ); Fri, 22 Apr 2011 14:19:37 -0400 Received: from sentry-three.sandia.gov ([132.175.109.17]:60164 "EHLO sentry-three.sandia.gov" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753697Ab1DVSTh (ORCPT ); Fri, 22 Apr 2011 14:19:37 -0400 X-WSS-ID: 0LK2G8M-0C-26M-02 X-M-MSG: Received: from interceptor1.sandia.gov (interceptor1.sandia.gov [132.175.109.5]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by sentry-three.sandia.gov (Postfix) with ESMTP id 1C5174D1E5C for ; Fri, 22 Apr 2011 12:19:33 -0600 (MDT) Received: from sentry.sandia.gov (sentry.sandia.gov [132.175.109.20]) by interceptor1.sandia.gov (RSA Interceptor) for ; Fri, 22 Apr 2011 12:15:40 -0600 Received: from [134.253.103.1] by sentry.sandia.gov with ESMTP (SMTP Relay 01 (Email Firewall v6.3.2)); Fri, 22 Apr 2011 12:19:22 -0600 X-Server-Uuid: 6BFC7783-7E22-49B4-B610-66D6BE496C0E Received: from [134.253.4.20] (134.253.95.179) by mail.sandia.gov ( 134.253.103.1) with Microsoft SMTP Server (TLS) id 14.1.270.1; Fri, 22 Apr 2011 12:19:22 -0600 Message-ID: <4DB1C6A0.9000001@sandia.gov> Date: Fri, 22 Apr 2011 12:19:12 -0600 From: "Jim Schutt" User-Agent: Thunderbird 2.0.0.24 (X11/20110128) MIME-Version: 1.0 To: linux-rdma@vger.kernel.org Subject: opensm: switch incorrectly reports IB_PORT_CAP_HAS_MCAST_FDB_TOP ? X-Originating-IP: [134.253.95.179] X-TMWD-Spam-Summary: TS=20110422181922; ID=1; SEV=2.3.1; DFV=B2011042217; IFV=NA; AIF=B2011042217; RPD=5.03.0010; ENG=NA; RPDID=7374723D303030312E30413031303230382E34444231433641422E303033342C73733D312C6667733D30; CAT=NONE; CON=NONE; SIG=AAAAAAAAAAAAAAAAAAAAAAAAfQ== X-MMS-Spam-Filter-ID: B2011042217_5.03.0010 X-WSS-ID: 61AF19202K42001371-01-01 X-RSA-Inspected: yes X-RSA-Classifications: public X-RSA-Action: allow Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Fri, 22 Apr 2011 18:19:39 +0000 (UTC) Hi, I've been testing the current opensm development head (commit 83b67527d16 from git://git.openfabrics.org/~alexnetes/opensm), and I've been getting some messages that are new since version 3.3.7: Apr 22 12:08:09 646534 [411CD940] 0x01 -> log_rcv_cb_error: ERR 3111: Received MAD with error status = 0x1C SubnGetResp(SwitchInfo), attr_mod 0x0, TID 0x4802 Initial path: 0,1,1,4 Return path: 0,20,1,7 I get one of these messages for each switch in my fabric, on every heavy sweep. It appears these are caused by my switches incorrectly reporting the capability IB_PORT_CAP_HAS_MCAST_FDB_TOP; i.e. this patch stops the messages: IB_PORT_CAP_HAS_MCAST_FDB_TOP is bit 30 of the port capability mask, which in at least IBA v1.2.1 was a reserved bit but apparently is not anymore. Should I file a bug report with my switch vendor about setting a port capability bit for a capability they don't support, or is there something else going on that I haven't figured out yet? FWIW I think my switches have a base SP0; maybe it's got something to do with that? Thanks -- Jim --- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/opensm/osm_mcast_mgr.c b/opensm/osm_mcast_mgr.c index ea52bfe..63d2968 100644 --- a/opensm/osm_mcast_mgr.c +++ b/opensm/osm_mcast_mgr.c @@ -1041,7 +1041,7 @@ static void mcast_mgr_set_mfttop(IN osm_sm_t * sm, IN osm_switch_t * p_sw) p_path = osm_physp_get_dr_path_ptr(p_physp); p_tbl = osm_switch_get_mcast_tbl_ptr(p_sw); - if (p_physp->port_info.capability_mask & IB_PORT_CAP_HAS_MCAST_FDB_TOP) { + if (0 && p_physp->port_info.capability_mask & IB_PORT_CAP_HAS_MCAST_FDB_TOP) { /* Set the top of the multicast forwarding table. */