From patchwork Tue Jul 26 15:23:35 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hal Rosenstock X-Patchwork-Id: 1008452 X-Patchwork-Delegate: alexne@voltaire.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.4) with ESMTP id p6QFNkQO009759 for ; Tue, 26 Jul 2011 15:23:46 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752926Ab1GZPXq (ORCPT ); Tue, 26 Jul 2011 11:23:46 -0400 Received: from mail-ww0-f44.google.com ([74.125.82.44]:47016 "EHLO mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751776Ab1GZPXp (ORCPT ); Tue, 26 Jul 2011 11:23:45 -0400 Received: by wwe5 with SMTP id 5so652087wwe.1 for ; Tue, 26 Jul 2011 08:23:43 -0700 (PDT) Received: by 10.216.237.233 with SMTP id y83mr1994217weq.9.1311693823541; Tue, 26 Jul 2011 08:23:43 -0700 (PDT) Received: from [192.168.1.102] (c-71-192-10-85.hsd1.ma.comcast.net [71.192.10.85]) by mx.google.com with ESMTPS id em16sm521872wbb.16.2011.07.26.08.23.41 (version=SSLv3 cipher=OTHER); Tue, 26 Jul 2011 08:23:42 -0700 (PDT) Message-ID: <4E2EDBF7.3080509@dev.mellanox.co.il> Date: Tue, 26 Jul 2011 11:23:35 -0400 From: Hal Rosenstock User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.18) Gecko/20110616 Thunderbird/3.1.11 MIME-Version: 1.0 To: Alex Netes CC: "linux-rdma@vger.kernel.org" Subject: [PATCH 1/3] opensm/osm_helper: Add rate related routines Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Tue, 26 Jul 2011 15:23:46 +0000 (UTC) for proper comparison and selector operation Rate enum was never is ascending order of actual underlying rates but even worse with newly added extended link speeds. Signed-off-by: Hal Rosenstock --- -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/include/opensm/osm_helper.h b/include/opensm/osm_helper.h index f11fdee..a2c1dea 100644 --- a/include/opensm/osm_helper.h +++ b/include/opensm/osm_helper.h @@ -1,6 +1,6 @@ /* * Copyright (c) 2004-2009 Voltaire, Inc. All rights reserved. - * Copyright (c) 2002-2010 Mellanox Technologies LTD. All rights reserved. + * Copyright (c) 2002-2011 Mellanox Technologies LTD. All rights reserved. * Copyright (c) 1996-2003 Intel Corporation. All rights reserved. * Copyright (c) 2009 HNR Consulting. All rights reserved. * @@ -582,5 +582,85 @@ const char *osm_get_sm_mgr_state_str(IN uint16_t state); * SEE ALSO *********/ +/****f* IBA Base: Types/ib_path_compare_rates +* NAME +* ib_path_compare_rates +* +* DESCRIPTION +* Compares the encoded values for two path rates and +* return value is based on the ordered comparison of +* the path rates (or path rate equivalents). +* +* SYNOPSIS +*/ +int ib_path_compare_rates(IN const int rate1, IN const int rate2); + +/* +* PARAMETERS +* rate1 +* [in] Encoded path rate 1. +* +* rate2 +* [in] Encoded path rate 2. +* +* RETURN VALUES +* Returns an int indicating less than (-1), equal to (0), or +* greater than (1) rate1 as compared with rate2. +* +* NOTES +* +* SEE ALSO +*********/ + +/****f* IBA Base: Types/ib_path_rate_get_prev +* NAME +* ib_path_rate_get_prev +* +* DESCRIPTION +* Obtains encoded rate for the rate previous to the one requested. +* +* SYNOPSIS +*/ +int ib_path_rate_get_prev(IN const int rate); + +/* +* PARAMETERS +* rate +* [in] Encoded path rate. +* +* RETURN VALUES +* Returns an int indicating encoded rate or +* 0 if none can be found. +* +* NOTES +* +* SEE ALSO +*********/ + +/****f* IBA Base: Types/ib_path_rate_get_next +* NAME +* ib_path_rate_get_next +* +* DESCRIPTION +* Obtains encoded rate for the rate subsequent to the one requested. +* +* SYNOPSIS +*/ +int ib_path_rate_get_next(IN const int rate); + +/* +* PARAMETERS +* rate +* [in] Encoded path rate. +* +* RETURN VALUES +* Returns an int indicating encoded rate or +* 0 if none can be found. +* +* NOTES +* +* SEE ALSO +*********/ + END_C_DECLS #endif /* _OSM_HELPER_H_ */ diff --git a/opensm/libopensm.map b/opensm/libopensm.map index 68d5b17..ca7d236 100644 --- a/opensm/libopensm.map +++ b/opensm/libopensm.map @@ -57,5 +57,8 @@ OPENSM_1.5 { osm_get_lsa_str; osm_get_sm_mgr_signal_str; osm_get_sm_mgr_state_str; + ib_path_compare_rates; + ib_path_rate_get_prev; + ib_path_rate_get_next; local: *; }; diff --git a/opensm/osm_helper.c b/opensm/osm_helper.c index ec1099c..aed95f8 100644 --- a/opensm/osm_helper.c +++ b/opensm/osm_helper.c @@ -439,6 +439,27 @@ static const char *ib_sa_attr_str[] = { #define OSM_SA_ATTR_STR_UNKNOWN_VAL (ARR_SIZE(ib_sa_attr_str) - 1) +static int ordered_rates[] = { + 0, 0, /* 0, 1 - reserved */ + 1, /* 2 - 2.5 Gbps */ + 3, /* 3 - 10 Gbps */ + 6, /* 4 - 30 Gbps */ + 2, /* 5 - 5 Gbps */ + 5, /* 6 - 20 Gbps */ + 8, /* 7 - 40 Gbps */ + 9, /* 8 - 60 Gbps */ + 11, /* 9 - 80 Gbps */ + 12, /* 10 - 120 Gbps */ + 4, /* 11 - 14 Gbps (17 Gbps equiv) */ + 10, /* 12 - 56 Gbps (68 Gbps equiv) */ + 14, /* 13 - 112 Gbps (136 Gbps equiv) */ + 15, /* 14 - 158 Gbps (204 Gbps equiv) */ + 7, /* 15 - 25 Gbps (31.25 Gbps equiv) */ + 13, /* 16 - 100 Gbps (125 Gbps equiv) */ + 16, /* 17 - 200 Gbps (250 Gbps equiv) */ + 17 /* 18 - 300 Gbps (375 Gbps equiv) */ +}; + static int sprint_uint8_arr(char *buf, size_t size, const uint8_t * arr, size_t len) { @@ -2295,3 +2316,55 @@ const char *osm_get_sm_mgr_state_str(IN uint16_t state) sm_mgr_state_str[state] : sm_mgr_state_str[ARR_SIZE(sm_mgr_state_str) - 1]; } + +int ib_path_compare_rates(IN const int rate1, IN const int rate2) +{ + int orate1 = 0, orate2 = 0; + + if (rate1 <= IB_MAX_RATE) + orate1 = ordered_rates[rate1]; + if (rate2 <= IB_MAX_RATE) + orate2 = ordered_rates[rate2]; + if (orate1 < orate2) + return -1; + if (orate1 == orate2) + return 0; + return 1; +} + +static int find_ordered_rate(IN const int rate) +{ + int i; + + for (i = 2; i <= IB_MAX_RATE; i++) { + if (ordered_rates[i] == rate) + return i; + } + return 0; +} + +int ib_path_rate_get_prev(IN const int rate) +{ + int orate; + + if (rate <= IB_MIN_RATE) + return 0; + if (rate > IB_MAX_RATE) + return 0; + orate = ordered_rates[rate]; + orate--; + return find_ordered_rate(orate); +} + +int ib_path_rate_get_next(IN const int rate) +{ + int orate; + + if (rate < IB_MIN_RATE) + return 0; + if (rate >= IB_MAX_RATE) + return 0; + orate = ordered_rates[rate]; + orate++; + return find_ordered_rate(orate); +}