diff mbox

[opensm] PerfMgr: Eliminate no longer used sig_sweep variable

Message ID 53864083.2060305@dev.mellanox.co.il (mailing list archive)
State Accepted
Delegated to: Hal Rosenstock
Headers show

Commit Message

Hal Rosenstock May 28, 2014, 8:01 p.m. UTC
sig_sweep was mostly neutered back in 2007.

Code in osm_perfmgr.c:osm_perfmgr_process is problematic
if max_outstanding_queries is exceeded as nothing signals
sig_sweep event anymore. Remove this as this code is no
longer needed.

Signed-off-by: Hal Rosenstock <hal@mellanox.com>
---
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/include/opensm/osm_perfmgr.h b/include/opensm/osm_perfmgr.h
index 93e57a6..ab02c26 100644
--- a/include/opensm/osm_perfmgr.h
+++ b/include/opensm/osm_perfmgr.h
@@ -125,7 +125,6 @@  struct osm_opensm;
 *  be manipulated only through the provided functions.
 */
 typedef struct osm_perfmgr {
-	cl_event_t sig_sweep;
 	cl_timer_t sweep_timer;
 	struct osm_opensm *osm;
 	osm_subn_t *subn;
diff --git a/opensm/osm_perfmgr.c b/opensm/osm_perfmgr.c
index 2db9585..1c0ed46 100644
--- a/opensm/osm_perfmgr.c
+++ b/opensm/osm_perfmgr.c
@@ -1071,10 +1071,6 @@  void osm_perfmgr_process(osm_perfmgr_t * pm)
 	remove_marked_nodes(pm);
 
 #ifdef ENABLE_OSM_PERF_MGR_PROFILE
-	/* spin on outstanding queries */
-	while (pm->outstanding_queries > 0)
-		cl_event_wait_on(&pm->sig_sweep, 1000, TRUE);
-
 	gettimeofday(&after, NULL);
 	diff_time(&before, &after, &after);
 	osm_log_v2(pm->log, OSM_LOG_INFO, FILE_ID,
@@ -1876,8 +1872,6 @@  ib_api_status_t osm_perfmgr_init(osm_perfmgr_t * pm, osm_opensm_t * osm,
 
 	memset(pm, 0, sizeof(*pm));
 
-	cl_event_construct(&pm->sig_sweep);
-	cl_event_init(&pm->sig_sweep, FALSE);
 	pm->subn = &osm->subn;
 	pm->sm = &osm->sm;
 	pm->log = &osm->log;