From patchwork Mon Dec 18 16:28:05 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Santosh Shilimkar X-Patchwork-Id: 10120687 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C8FAF60327 for ; Mon, 18 Dec 2017 16:28:22 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B96A028C7F for ; Mon, 18 Dec 2017 16:28:22 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id AB66228CFE; Mon, 18 Dec 2017 16:28:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.3 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, SORTED_RECIPS, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 33ED528C7F for ; Mon, 18 Dec 2017 16:28:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936503AbdLRQ2U (ORCPT ); Mon, 18 Dec 2017 11:28:20 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:58953 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936447AbdLRQ2Q (ORCPT ); Mon, 18 Dec 2017 11:28:16 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.21/8.16.0.21) with SMTP id vBIGRfeZ024240; Mon, 18 Dec 2017 16:28:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2017-10-26; bh=soY3bR6nC8OzQsP4/4xhs59r4CA9spjIxCbm06Oo010=; b=VrGmZ42hBS2izod524VH9o1ClkMH7uOBbgdQDTFdgF6PzLKotsZv9+w6EEmqkVWzS3rb 8bKmEISAtBubrjZkHkPrCWi0dFCLvkyrxLDtFmqKDkGekP1Y93Jfc/Tf7+jMeHF+59A0 4YXxoIJTMIeADJEDVck85F3w7Uc47zmC7Ys7fMBYb0T5Vd4+zh8fxh49bpl4/55yBukX EckWIRToguOoCc1TA/W37yoYlEeMnxTW9tFu/zl/hplJ6KNsNdYUvyMesfSf/2kcyyeR a5QJVcByMxU6v5N5HtkMydkgw2eru2psLxPXpqIHuv5daaOvZUD5z9HqhyOeMtzgeb1f jA== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp2130.oracle.com with ESMTP id 2exgh6g9tt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 18 Dec 2017 16:28:10 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id vBIGS9F3011761 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 18 Dec 2017 16:28:09 GMT Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id vBIGS8ZX018109; Mon, 18 Dec 2017 16:28:08 GMT Received: from [10.209.243.219] (/10.209.243.219) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 18 Dec 2017 08:28:07 -0800 Subject: Re: BUG: unable to handle kernel NULL pointer dereference in rds_send_xmit To: syzbot , davem@davemloft.net, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, netdev@vger.kernel.org, rds-devel@oss.oracle.com, syzkaller-bugs@googlegroups.com References: <001a1145ac5480242305609956b3@google.com> From: Santosh Shilimkar Organization: Oracle Corporation Message-ID: <5ba83a68-0103-d514-1b22-900f755f5aa4@oracle.com> Date: Mon, 18 Dec 2017 08:28:05 -0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <001a1145ac5480242305609956b3@google.com> Content-Language: en-US X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8749 signatures=668649 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=699 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1712180218 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 12/18/2017 12:43 AM, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 6084b576dca2e898f5c101baef151f7bfdbb606d > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console output is attached. > > Unfortunately, I don't have any reproducer for this bug yet. > > > BUG: unable to handle kernel NULL pointer dereference at 0000000000000028 > program syz-executor6 is using a deprecated SCSI ioctl, please convert > it to SG_IO > IP: rds_send_xmit+0x80/0x930 net/rds/send.c:186 Looks like another one tripping on empty transport. Mostly below should address it but we will test it if it does. --- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/net/rds/send.c b/net/rds/send.c index 7244d2e..e2d0eaa 100644 --- a/net/rds/send.c +++ b/net/rds/send.c @@ -183,7 +183,7 @@ int rds_send_xmit(struct rds_conn_path *cp) goto out; } - if (conn->c_trans->xmit_path_prepare) + if (conn->c_trans && conn->c_trans->xmit_path_prepare) conn->c_trans->xmit_path_prepare(cp);