diff mbox

[v4,net-next,0/7] qed*: RDMA and infrastructure for iWARP

Message ID CAJ3xEMhVdmpiGxBb8r0Sx3g_4ej7uhaCf4+qSi3ObMJ=-4ybXQ@mail.gmail.com (mailing list archive)
State Superseded
Headers show

Commit Message

Or Gerlitz June 21, 2017, 9:57 a.m. UTC 
On Wed, Jun 21, 2017 at 12:56 PM, Or Gerlitz <gerlitz.or@gmail.com> wrote:
> On Tue, Jun 20, 2017 at 7:35 PM, David Miller <davem@davemloft.net> wrote:
>> From: Yuval Mintz <Yuval.Mintz@cavium.com>
>> Date: Tue, 20 Jun 2017 15:59:59 +0300
>>
>>> Please consider applying this series to `net-next'.
>>
>> Series applied, thanks.

Yuval,

It's broke my build

In file included from drivers/net/ethernet/qlogic/qede/qede.h:43,
                 from drivers/net/ethernet/qlogic/qede/qede_ethtool.c:41:
./include/linux/qed/qede_rdma.h:85: error: expected identifier or '('
before '{' token
In file included from drivers/net/ethernet/qlogic/qede/qede.h:43,
                 from drivers/net/ethernet/qlogic/qede/qede_dcbnl.c:13:
./include/linux/qed/qede_rdma.h:85: error: expected identifier or '('
before '{' token
make[5]: *** [drivers/net/ethernet/qlogic/qede/qede_dcbnl.o] Error 1

here's the fix

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Leon Romanovsky June 21, 2017, 10:10 a.m. UTC | #1 
On Wed, Jun 21, 2017 at 12:57:36PM +0300, Or Gerlitz wrote:
> On Wed, Jun 21, 2017 at 12:56 PM, Or Gerlitz <gerlitz.or@gmail.com> wrote:
> > On Tue, Jun 20, 2017 at 7:35 PM, David Miller <davem@davemloft.net> wrote:
> >> From: Yuval Mintz <Yuval.Mintz@cavium.com>
> >> Date: Tue, 20 Jun 2017 15:59:59 +0300
> >>
> >>> Please consider applying this series to `net-next'.
> >>
> >> Series applied, thanks.
>
> Yuval,
>
> It's broke my build
>
> In file included from drivers/net/ethernet/qlogic/qede/qede.h:43,
>                  from drivers/net/ethernet/qlogic/qede/qede_ethtool.c:41:
> ./include/linux/qed/qede_rdma.h:85: error: expected identifier or '('
> before '{' token
> In file included from drivers/net/ethernet/qlogic/qede/qede.h:43,
>                  from drivers/net/ethernet/qlogic/qede/qede_dcbnl.c:13:
> ./include/linux/qed/qede_rdma.h:85: error: expected identifier or '('
> before '{' token
> make[5]: *** [drivers/net/ethernet/qlogic/qede/qede_dcbnl.o] Error 1
>
> here's the fix
>
> diff --git a/include/linux/qed/qede_rdma.h b/include/linux/qed/qede_rdma.h
> index 1348a16..9904617 100644
> --- a/include/linux/qed/qede_rdma.h
> +++ b/include/linux/qed/qede_rdma.h
> @@ -81,7 +81,7 @@ void qede_rdma_dev_remove(struct qede_dev *dev);
>  void qede_rdma_event_changeaddr(struct qede_dev *edr);
>
>  #else
> -static inline int qede_rdma_dev_add(struct qede_dev *dev);
> +static inline int qede_rdma_dev_add(struct qede_dev *dev)
>  {
>         return 0;
>  }


Yeah, Yuval sent it already:
https://patchwork.ozlabs.org/patch/778632/

Thanks

> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/include/linux/qed/qede_rdma.h b/include/linux/qed/qede_rdma.h
index 1348a16..9904617 100644
--- a/include/linux/qed/qede_rdma.h
+++ b/include/linux/qed/qede_rdma.h
@@ -81,7 +81,7 @@  void qede_rdma_dev_remove(struct qede_dev *dev);
 void qede_rdma_event_changeaddr(struct qede_dev *edr);

 #else
-static inline int qede_rdma_dev_add(struct qede_dev *dev);
+static inline int qede_rdma_dev_add(struct qede_dev *dev)
 {
        return 0;
 }