From patchwork Thu Aug  5 20:31:24 2010
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Roland Dreier <rdreier@cisco.com>
X-Patchwork-Id: 117462
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by demeter.kernel.org (8.14.4/8.14.3) with ESMTP id o75KWl9g008607
	for <patchwork-linux-rdma@patchwork.kernel.org>;
	Thu, 5 Aug 2010 20:33:02 GMT
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S934369Ab0HEUbc (ORCPT
	<rfc822;patchwork-linux-rdma@patchwork.kernel.org>);
	Thu, 5 Aug 2010 16:31:32 -0400
Received: from sj-iport-1.cisco.com ([171.71.176.70]:64561 "EHLO
	sj-iport-1.cisco.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S934344Ab0HEUb2 (ORCPT
	<rfc822; linux-rdma@vger.kernel.org>); Thu, 5 Aug 2010 16:31:28 -0400
Authentication-Results: sj-iport-1.cisco.com;
	dkim=neutral (message not signed) header.i=none
X-IronPort-AV: E=Sophos;i="4.55,324,1278288000"; d="scan'208";a="349662121"
Received: from sj-core-1.cisco.com ([171.71.177.237])
	by sj-iport-1.cisco.com with ESMTP; 05 Aug 2010 20:31:27 +0000
Received: from roland-alpha.cisco.com (roland-alpha.cisco.com [10.33.42.9])
	by sj-core-1.cisco.com (8.13.8/8.14.3) with ESMTP id
	o75KVRDe023371; Thu, 5 Aug 2010 20:31:27 GMT
Received: by roland-alpha.cisco.com (Postfix, from userid 33217)
	id 2DB381FE41; Thu,  5 Aug 2010 13:31:24 -0700 (PDT)
From: Roland Dreier <rdreier@cisco.com>
To: Julia Lawall <julia@diku.dk>
Cc: Faisal Latif <faisal.latif@intel.com>,
	Chien Tung <chien.tin.tung@intel.com>,
	Roland Dreier <rolandd@cisco.com>, Sean Hefty <sean.hefty@intel.com>,
	Hal Rosenstock <hal.rosenstock@gmail.com>, linux-rdma@vger.kernel.org,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 4/42] drivers/infiniband/hw/nes: Adjust confusing if
	indentation
References: <Pine.LNX.4.64.1008052217430.31692@ask.diku.dk>
X-Message-Flag: Warning: May contain useful information
Date: Thu, 05 Aug 2010 13:31:24 -0700
In-Reply-To: <Pine.LNX.4.64.1008052217430.31692@ask.diku.dk> (Julia Lawall's
	message of "Thu, 5 Aug 2010 22:18:01 +0200 (CEST)")
Message-ID: <adaiq3o4x9f.fsf@roland-alpha.cisco.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)
MIME-Version: 1.0
Sender: linux-rdma-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-rdma.vger.kernel.org>
X-Mailing-List: linux-rdma@vger.kernel.org
X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by
	milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]);
	Thu, 05 Aug 2010 20:33:02 +0000 (UTC)


diff --git a/drivers/infiniband/hw/nes/nes_hw.c b/drivers/infiniband/hw/nes/nes_hw.c
index 07c4004..f8233c8 100644
--- a/drivers/infiniband/hw/nes/nes_hw.c
+++ b/drivers/infiniband/hw/nes/nes_hw.c
@@ -2737,9 +2737,9 @@ void nes_nic_ce_handler(struct nes_device *nesdev, struct nes_hw_nic_cq *cq)
 				nesnic->sq_tail &= nesnic->sq_size-1;
 				if (sq_cqes > 128) {
 					barrier();
-				/* restart the queue if it had been stopped */
-				if (netif_queue_stopped(nesvnic->netdev))
-					netif_wake_queue(nesvnic->netdev);
+					/* restart the queue if it had been stopped */
+					if (netif_queue_stopped(nesvnic->netdev))
+						netif_wake_queue(nesvnic->netdev);
 					sq_cqes = 0;
 				}
 			} else {