rdma-core: Add missing systemd-devel dependency to the SUSE rdma-core.spec

Commit Message

Nicolas Morey-Chaisemartin Dec. 7, 2017, 10:16 a.m. UTC

Le 06/12/2017 à 23:06, Nikolova, Tatyana E a écrit :
>
>
> The patch was prompted when the rdma-core daemons were unable to start on a SLES12SP2 system, because the shim version of the systemd functions were used instead. Unfortunately I don't have the details on how rdma-core was installed on this system.

If you don't mind me asking, why are you trying to do this on SLE12SP2 ?
SP2 is using now ancient libraries from OFEd (pre rdma-core).
Even it compiled right for SP2, I have very strong doubt about the system being fully working unless you recompile all IB related RPMs...

I strongly advise doing this from a SLE12SP3 which uses rdma-core v14.
>
> Checking the current SUSE spec file on the same system (without systemd-devel installed), it indeed detects a missing dependency:
> "error: Failed build dependencies: pkgconfig(libsystemd) is needed by rdma-core-15-0.x86_64"
>
> However libsystemd packages (libsystemd0-228-117.12.x86_64 and libsystemd0-32bit-228-117.12.x86_64) are installed on this system, but systemd-devel is necessary to install the required headers, for example "sd-daemon.h" needed by the daemons. 
>
> Maybe it would be better to replace pkgconfig(libsystemd) with pkgconfig(systemd-devel) in the spec file, since systemd-devel requires libsystemd?


Coud you try with this instead of your patch:

Nicolas
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/suse/rdma-core.spec b/suse/rdma-core.spec
index 5be0e1e8..fa41b724 100644
--- a/suse/rdma-core.spec
+++ b/suse/rdma-core.spec
@@ -54,7 +54,8 @@  BuildRequires:  binutils
 BuildRequires:  cmake >= 2.8.11
 BuildRequires:  gcc
 BuildRequires:  pkgconfig
-BuildRequires:  pkgconfig(libsystemd)
+BuildRequires:  pkgconfig(libsystemd-daemon)
+BuildRequires:  pkgconfig(libsystemd-journal)
 BuildRequires:  pkgconfig(libudev)
 BuildRequires:  pkgconfig(systemd)
 BuildRequires:  pkgconfig(udev)