From patchwork Thu Dec 7 10:16:20 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Nicolas Morey-Chaisemartin X-Patchwork-Id: 10098197 X-Patchwork-Delegate: leon@leon.nu Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D304160325 for ; Thu, 7 Dec 2017 10:16:24 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C0A6D2A3EA for ; Thu, 7 Dec 2017 10:16:24 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B519A2A3FB; Thu, 7 Dec 2017 10:16:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 55A4C2A3EA for ; Thu, 7 Dec 2017 10:16:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752471AbdLGKQX (ORCPT ); Thu, 7 Dec 2017 05:16:23 -0500 Received: from mx2.suse.de ([195.135.220.15]:45716 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750981AbdLGKQX (ORCPT ); Thu, 7 Dec 2017 05:16:23 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id E540CAE00; Thu, 7 Dec 2017 10:16:21 +0000 (UTC) Subject: Re: [PATCH] rdma-core: Add missing systemd-devel dependency to the SUSE rdma-core.spec To: "Nikolova, Tatyana E" , Jason Gunthorpe Cc: "dledford@redhat.com" , "leonro@mellanox.com" , "linux-rdma@vger.kernel.org" , "e1000-rdma@lists.sourceforge.net" References: <20171205234005.10904-1-tatyana.e.nikolova@intel.com> <024a3b6a-2f04-36ee-5d4f-51f9e8cb719e@suse.de> <20171206171349.GF29197@mellanox.com> <20171206172731.GA3564@mellanox.com> <13AA599688F47243B14FCFCCC2C803BB3C65CD63@fmsmsx104.amr.corp.intel.com> From: Nicolas Morey-Chaisemartin Openpgp: preference=signencrypt Message-ID: Date: Thu, 7 Dec 2017 11:16:20 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101 Thunderbird/57.0 MIME-Version: 1.0 In-Reply-To: <13AA599688F47243B14FCFCCC2C803BB3C65CD63@fmsmsx104.amr.corp.intel.com> Content-Language: fr-xx-classique+reforme1990 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Le 06/12/2017 à 23:06, Nikolova, Tatyana E a écrit : > > > The patch was prompted when the rdma-core daemons were unable to start on a SLES12SP2 system, because the shim version of the systemd functions were used instead. Unfortunately I don't have the details on how rdma-core was installed on this system. If you don't mind me asking, why are you trying to do this on SLE12SP2 ? SP2 is using now ancient libraries from OFEd (pre rdma-core). Even it compiled right for SP2, I have very strong doubt about the system being fully working unless you recompile all IB related RPMs... I strongly advise doing this from a SLE12SP3 which uses rdma-core v14. > > Checking the current SUSE spec file on the same system (without systemd-devel installed), it indeed detects a missing dependency: > "error: Failed build dependencies: pkgconfig(libsystemd) is needed by rdma-core-15-0.x86_64" > > However libsystemd packages (libsystemd0-228-117.12.x86_64 and libsystemd0-32bit-228-117.12.x86_64) are installed on this system, but systemd-devel is necessary to install the required headers, for example "sd-daemon.h" needed by the daemons. > > Maybe it would be better to replace pkgconfig(libsystemd) with pkgconfig(systemd-devel) in the spec file, since systemd-devel requires libsystemd? Coud you try with this instead of your patch: Nicolas --- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/suse/rdma-core.spec b/suse/rdma-core.spec index 5be0e1e8..fa41b724 100644 --- a/suse/rdma-core.spec +++ b/suse/rdma-core.spec @@ -54,7 +54,8 @@ BuildRequires:  binutils  BuildRequires:  cmake >= 2.8.11  BuildRequires:  gcc  BuildRequires:  pkgconfig -BuildRequires:  pkgconfig(libsystemd) +BuildRequires:  pkgconfig(libsystemd-daemon) +BuildRequires:  pkgconfig(libsystemd-journal)  BuildRequires:  pkgconfig(libudev)  BuildRequires:  pkgconfig(systemd)  BuildRequires:  pkgconfig(udev)