| Message ID | 1600368999-9461-1-git-send-email-rishabhb@codeaurora.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | Move recovery/coredump configuration to sysfs | expand |
On 9/17/20 11:56 AM, Rishabh Bhatnagar wrote: > From Android R onwards Google has restricted access to debugfs in user > and user-debug builds. This restricts access to most of the features > exposed through debugfs. This patch series removes the recovery/coredump > entries from debugfs and moves them to sysfs. > 'Coredump' and 'Recovery' are critical interfaces that are required > for remoteproc to work on Qualcomm Chipsets. Coredump configuration > needs to be set to "inline" in debug/test build and "disabled" in > production builds. Whereas recovery needs to be "disabled" for > debugging purposes and "enabled" on production builds. > > Changelog: > > v4 -> v3: > - Remove the feature flag to expose recovery/coredump > > v3 -> v2: > - Remove the coredump/recovery entries from debugfs > - Expose recovery/coredump from sysfs under a feature flag > > v1 -> v2: > - Correct the contact name in the sysfs documentation. > - Remove the redundant write documentation for coredump/recovery sysfs > - Add a feature flag to make this interface switch configurable. > > Rishabh Bhatnagar (3): > remoteproc: Expose remoteproc configuration through sysfs > remoteproc: Add coredump configuration to sysfs > remoteproc: Add recovery configuration to sysfs > > Documentation/ABI/testing/sysfs-class-remoteproc | 44 ++++++++ > drivers/remoteproc/Kconfig | 12 +++ > drivers/remoteproc/remoteproc_debugfs.c | 10 +- > drivers/remoteproc/remoteproc_sysfs.c | 126 +++++++++++++++++++++++ > 4 files changed, 190 insertions(+), 2 deletions(-) > Hi, Is there a patch 3/3? This email (reply) is patch 0/3, then I see patch 1/2 patch 2/2 so I'm confused. However, the diffstat above references a Kconfig file and neither patch 1/2 nor patch 2/2 contains any Kconfig changes. thanks.
On 2020-09-17 16:40, Randy Dunlap wrote: > On 9/17/20 11:56 AM, Rishabh Bhatnagar wrote: >> From Android R onwards Google has restricted access to debugfs in user >> and user-debug builds. This restricts access to most of the features >> exposed through debugfs. This patch series removes the >> recovery/coredump >> entries from debugfs and moves them to sysfs. >> 'Coredump' and 'Recovery' are critical interfaces that are required >> for remoteproc to work on Qualcomm Chipsets. Coredump configuration >> needs to be set to "inline" in debug/test build and "disabled" in >> production builds. Whereas recovery needs to be "disabled" for >> debugging purposes and "enabled" on production builds. >> >> Changelog: >> >> v4 -> v3: >> - Remove the feature flag to expose recovery/coredump >> >> v3 -> v2: >> - Remove the coredump/recovery entries from debugfs >> - Expose recovery/coredump from sysfs under a feature flag >> >> v1 -> v2: >> - Correct the contact name in the sysfs documentation. >> - Remove the redundant write documentation for coredump/recovery sysfs >> - Add a feature flag to make this interface switch configurable. >> >> Rishabh Bhatnagar (3): >> remoteproc: Expose remoteproc configuration through sysfs >> remoteproc: Add coredump configuration to sysfs >> remoteproc: Add recovery configuration to sysfs >> >> Documentation/ABI/testing/sysfs-class-remoteproc | 44 ++++++++ >> drivers/remoteproc/Kconfig | 12 +++ >> drivers/remoteproc/remoteproc_debugfs.c | 10 +- >> drivers/remoteproc/remoteproc_sysfs.c | 126 >> +++++++++++++++++++++++ >> 4 files changed, 190 insertions(+), 2 deletions(-) >> > > Hi, > > Is there a patch 3/3? > This email (reply) is patch 0/3, then I see > patch 1/2 > patch 2/2 > so I'm confused. However, the diffstat above references a Kconfig file > and neither patch 1/2 nor patch 2/2 contains any Kconfig changes. > > thanks. Hi Randy, The cover letter got messed up. There are only 2 patches now whereas in the earlier versions there were 3 patches. I'll be sending out v5 soon. Please review that.