From patchwork Wed Feb 17 13:28:49 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnaud POULIQUEN X-Patchwork-Id: 12091643 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95405C433E6 for ; Wed, 17 Feb 2021 13:33:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3E17C64E5B for ; Wed, 17 Feb 2021 13:33:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233110AbhBQNcd (ORCPT ); Wed, 17 Feb 2021 08:32:33 -0500 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:14012 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S233052AbhBQNbh (ORCPT ); Wed, 17 Feb 2021 08:31:37 -0500 Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 11HDSWZ2001051; Wed, 17 Feb 2021 14:30:47 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=from : to : cc : subject : date : message-id : mime-version : content-type; s=selector1; bh=bs5hl1wFsAOJu6X9Hycte2PvBsx11N4FQTR9gCM28rE=; b=Rq+WeZxfJKEzCW5WAxI7Pq9xij5zduCIl8/NEiPqAI4XeupiO0sBxkFlWfosF+yWkM6m /wHvgEanq68ssinIUGXqFCKNai3WKh6YVlAUZZkSgm7OEeqQI3sjWM2zDYLAxWcq1Byp 676gwijN38/TCnmIitNy/v13uCqYpA711go8NMJVL0anWDYfEWHg36MR9dBn6c8WIZX9 6FewH84Z9pyBK87CZVwNwnpwfQnKnsQkaHTUhFSl0vHgCNJezNil0+06ABR4MN62Wyzj /dFeHqsRa2hCAiFFBuBePQK1MY3PwZ02Rqt1r5ir2rOR+fq2FcdQ94f4pM1g0gkss66N Ng== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 36p4sffbv5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 17 Feb 2021 14:30:47 +0100 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 4A08F10002A; Wed, 17 Feb 2021 14:30:47 +0100 (CET) Received: from Webmail-eu.st.com (sfhdag2node3.st.com [10.75.127.6]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 16BAD2370C9; Wed, 17 Feb 2021 14:30:47 +0100 (CET) Received: from localhost (10.75.127.47) by SFHDAG2NODE3.st.com (10.75.127.6) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 17 Feb 2021 14:30:46 +0100 From: Arnaud Pouliquen To: Bjorn Andersson , Ohad Ben-Cohen , Mathieu Poirier , Andy Gross CC: , , , , Subject: [PATCH v4 00/16] introduce a generic IOCTL interface for RPMsg channels management Date: Wed, 17 Feb 2021 14:28:49 +0100 Message-ID: <20210217132905.1485-1-arnaud.pouliquen@foss.st.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-Originating-IP: [10.75.127.47] X-ClientProxiedBy: SFHDAG2NODE2.st.com (10.75.127.5) To SFHDAG2NODE3.st.com (10.75.127.6) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.761 definitions=2021-02-17_11:2021-02-16,2021-02-17 signatures=0 Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org This series restructures the RPMsg char driver to decorrelate the control part and to create a generic RPMsg ioctl interface compatible with other RPMsg services. The V4 fixes compilation issue reported by the kernel test robot The V3 is based on the guideline proposed by Mathieu Poirier to keep as much as possible the legacy implementation of the rpmsg_char used by the GLINK and SMD platforms. Objectives of the series: - Allow to create a service from Linux user application: - with a specific name - with or without name service announcement. - Allow to probe the same service by receiving either a NS announcement from the remote firmware or a Linux user application request. - Use these services independently of the RPMsg transport implementation (e.g be able to use RPMSg char with the RPMsg virtio bus). Steps in the series: - Extract the control part of the char dev and create the rpmsg_ctrl.c file (patches 1 to 5) - Enable the use of the chardev with the virtio backend (patches 6 to 10) - Introduce the RPMSG_CREATE_DEV_IOCTL IOCTL to instantiate RPMsg devices (patch 11) The application can then create or release a channel by specifying: - the name service of the device to instantiate. - the source address. - the destination address. - Instantiate the /dev/rpmsg interface on remote NS announcement (patches 12 to 15) In this revision, I do not divide the series into several parts in order to show a complete picture of the proposed evolution. To simplify the review, as a next step, I can send it in several steps listed above. Known current Limitations: - Tested only with virtio RPMsg bus. The glink and smd drivers adaptations have not been tested (not able to test it). - For the virtio backend: No NS announcement is sent to the remote processor if the source address is set to RPMSG_ADDR_ANY. - For the virtio backend: the existing RPMSG_CREATE_EPT_IOCTL is working but the endpoints are not attached to an exiting channel. - to limit patches the pending RPMSG_DESTROY_DEV_IOCTL has not ben implemented. This will be proposed in a second step. This series can be applied on git/andersson/remoteproc.git for-next branch (d9ff3a5789cb). This series can be tested using rpmsgexport, rpmsgcreatedev and ping tools available here: https://github.com/arnopo/rpmsgexport.git Reference to the V3 discussion thread: https://lkml.org/lkml/2021/2/4/194 Arnaud Pouliquen (16): rpmsg: char: rename rpmsg_char_init to rpmsg_chrdev_init rpmsg: move RPMSG_ADDR_ANY in user API rpmsg: add short description of the IOCTL defined in UAPI. rpmsg: char: export eptdev create an destroy functions rpmsg: char: dissociate the control device from the rpmsg class rpmsg: move the rpmsg control device from rpmsg_char to rpmsg_ctrl rpmsg: update rpmsg_chrdev_register_device function rpmsg: glink: add sendto and trysendto ops rpmsg: smd: add sendto and trysendto ops rpmsg: char: use sendto to specify the message destination address rpmsg: virtio: register the rpmsg_ctrl device rpmsg: ctrl: introduce RPMSG_CREATE_DEV_IOCTL rpmsg: char: introduce __rpmsg_chrdev_create_eptdev function rpmsg: char: introduce a RPMsg driver for the RPMsg char device rpmsg: char: no dynamic endpoint management for the default one rpmsg: char: return an error if device already open drivers/rpmsg/Kconfig | 9 ++ drivers/rpmsg/Makefile | 1 + drivers/rpmsg/qcom_glink_native.c | 18 ++- drivers/rpmsg/qcom_smd.c | 18 ++- drivers/rpmsg/rpmsg_char.c | 237 +++++++++++------------------- drivers/rpmsg/rpmsg_char.h | 51 +++++++ drivers/rpmsg/rpmsg_ctrl.c | 229 +++++++++++++++++++++++++++++ drivers/rpmsg/rpmsg_internal.h | 10 +- drivers/rpmsg/virtio_rpmsg_bus.c | 37 ++++- include/linux/rpmsg.h | 3 +- include/uapi/linux/rpmsg.h | 18 ++- 11 files changed, 469 insertions(+), 162 deletions(-) create mode 100644 drivers/rpmsg/rpmsg_char.h create mode 100644 drivers/rpmsg/rpmsg_ctrl.c