mbox series

[v6,0/1] remoteproc: core: do pm relax when in

Message ID 20221206015957.2616-1-quic_aiquny@quicinc.com (mailing list archive)
Headers show
Series remoteproc: core: do pm relax when in | expand

Message

Aiqun Yu (Maria) Dec. 6, 2022, 1:59 a.m. UTC 
If the remote processor is offline, no need to recover anything, and
pm_relax is needed to be called.


summary from some discussion points:

pm_stay_awake() is needed to stop and reverse the suspend process that
is currently underway.

RPROC_OFFLINE state indicate there is no recovery process
is in progress and no chance to do the pm_relax.
Because when recovering from crash, rproc->lock is held and
state is RPROC_CRASHED -> RPROC_OFFLINE -> RPROC_RUNNING,
and then unlock rproc->lock.
When the state is in RPROC_OFFLINE it means separate request
of rproc_stop was done and no need to hold the wakeup source
in crash handler to recover any more.


Changelog
===
V6
---
Address the comments.
Drop the allocate ordered workqueue change.

V5
---
Use goto out instead of directly call pm_relax and return. Suggested by
Mathieu.
Add new change with allocate ordered workqueue for allow only 1 active
work.

V4
---
Add pm relax when in RPROC_OFFLINE.

previous discussion here:
[1] https://lore.kernel.org/lkml/1bcd3fe8-f68d-ea7f-c0f9-68771e3421d5@quicinc.com/
[2] https://lore.kernel.org/linux-remoteproc/20221202094532.2925-1-quic_aiquny@quicinc.com/T/#t

Maria Yu (1):
  remoteproc: core: do pm_relax when in RPROC_OFFLINE state

 drivers/remoteproc/remoteproc_core.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)