From patchwork Fri Jan 6 12:10:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: MD Danish Anwar X-Patchwork-Id: 13091329 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FB88C5479D for ; Fri, 6 Jan 2023 12:11:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232626AbjAFMLK (ORCPT ); Fri, 6 Jan 2023 07:11:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48928 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232538AbjAFMLI (ORCPT ); Fri, 6 Jan 2023 07:11:08 -0500 Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 939977289E; Fri, 6 Jan 2023 04:11:05 -0800 (PST) Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 306CAnee013330; Fri, 6 Jan 2023 06:10:49 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1673007049; bh=tXbc96sb8j5CVa0DGNyxAaajFElFH9Gu+//+jPfif3A=; h=From:To:CC:Subject:Date; b=GGrpv/1PSlUlSK58ZOKmFLB163yN/rmzgiFilW4sqgxVOqnRSdSplMTuEKjTXe9pt VbtNmSbn4eIfuh7ymGL1JE2gAdAdKmb8uoBLUYTYFLzY8WH9QPBccVt7jiznlhBQja /nxEj+HrXAULwRkD8XzOSkaVEfzIz+2ouC71bWPk= Received: from DFLE102.ent.ti.com (dfle102.ent.ti.com [10.64.6.23]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 306CAnAs089015 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 6 Jan 2023 06:10:49 -0600 Received: from DFLE108.ent.ti.com (10.64.6.29) by DFLE102.ent.ti.com (10.64.6.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Fri, 6 Jan 2023 06:10:49 -0600 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE108.ent.ti.com (10.64.6.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Fri, 6 Jan 2023 06:10:49 -0600 Received: from fllv0122.itg.ti.com (fllv0122.itg.ti.com [10.247.120.72]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 306CAmCd096978; Fri, 6 Jan 2023 06:10:48 -0600 Received: from localhost (a0501179-pc.dhcp.ti.com [10.24.69.114]) by fllv0122.itg.ti.com (8.14.7/8.14.7) with ESMTP id 306CAlSq028579; Fri, 6 Jan 2023 06:10:48 -0600 From: MD Danish Anwar To: Mathieu Poirier , Krzysztof Kozlowski , Rob Herring CC: Suman Anna , Roger Quadros , "Andrew F . Davis" , , , , , , , , MD Danish Anwar Subject: [PATCH v14 0/6] Introduce PRU remoteproc consumer API Date: Fri, 6 Jan 2023 17:40:40 +0530 Message-ID: <20230106121046.886863-1-danishanwar@ti.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org The Programmable Real-Time Unit and Industrial Communication Subsystem (PRU-ICSS or simply PRUSS) on various TI SoCs consists of dual 32-bit RISC cores (Programmable Real-Time Units, or PRUs) for program execution. There are 3 foundation components for PRUSS subsystem: the PRUSS platform driver, the PRUSS INTC driver and the PRUSS remoteproc driver. All were already merged and can be found under: 1) drivers/soc/ti/pruss.c Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml 2) drivers/irqchip/irq-pruss-intc.c Documentation/devicetree/bindings/interrupt-controller/ti,pruss-intc.yaml 3) drivers/remoteproc/pru_rproc.c Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml The programmable nature of the PRUs provide flexibility to implement custom peripheral interfaces, fast real-time responses, or specialized data handling. Example of a PRU consumer drivers will be: - Software UART over PRUSS - PRU-ICSS Ethernet EMAC In order to make usage of common PRU resources and allow the consumer drivers to configure the PRU hardware for specific usage the PRU API is introduced. This is the v14 of the patch series [1]. This version of the patchset addresses the comments made on v13 [13] of the series. Two more patch series have been posted ([2] and [3]) that depends on this series, one has been posted to the soc/ti/ tree and another to the networking tree. All the 3 series including this one, has been sent as RFC [4] to get comments and to explain the dependencies. Changes from v13 to v14 : *) Moved the header file pruss.h from include/linux/ . to include/linux/remoteproc/ . Changes from v12 [12] to v13 : *) Fixed the checkpatch warning in patch 2/6 of the series. Changes from v11 [11] to v12 : *) Removed extra put_device() from pru_rproc_get() API as asked by Roger. *) Removed rproc_put() call in the API __pru_rproc_get() when rproc_get_by_phandle() returns null. Instead of that just return the error pointer. Changes from v10 [10] to v11 : *) Re-ordered the patches 2/6 and 3/6 of the series as asked by Roger. Now the 2/6 patch of the series introduces the enum pruss_pru_id and the header file . The patch 3/6 of the series introduces the pru_rproc_get() and pru_rproc_put() APIS with their actua desired arguments. Changes from v9 [9] to v10 : *) There was compilation issue in v9 of the series because of dependencies between 2nd and 3rd patch of the series. Fixed the dependencies in this series. *) Added enum documentation following the kernel-doc style [14] as asked by Roger for 3/6 patch of the series. Changes from v8 [8] to v9 : *) Fixed the warnings generated by running checkpatch.pl script. *) Added Review/Ack tags. *) Listed just the SoBs tags for all the patches as suggested by Mathieu. *) Removed a comment for an already documented field in patch 5/6 of this series. Changes from v7 [7] to v8 : *) Removed get_device(&rproc->dev) from API __pru_rproc_get() in patch 2/5 of this series as asked by Roger. *) Replaced all the SoBs (other than mine) to Co-developed-by tags for all the patches in this series as asked by Mathieu. *) Added a new patch (3/6) in this series for Introduction of pruss_pru_id enum. Previously this enum was part of patch 2/6. As asked by Roger removed this enum (and the APIs that are using the enum) from patch 2/6 and added it in new patch. *) Removed a comment for an already documented field in patch 2/6 of this series. *) Changed 'pru' to 'PRU' in comment of API pru_rproc_set_firmware() as asked by Roger. Changes from v6 [6] to v7 : *) Removed example section from ti,pru-consumer.yaml as the full example included compatible property as well which is not introduced in this series thus creating dt check binding error. Removing the example section fixes the dt binding check error. The example section will be included in "ti,icssg-prueth.yaml" in the next version of series [3] *) Updated the commit message for patch 1/5 of this series to address Krzysztof's comment. Changes from v5 [5] to v6 : *) Added rproc_get_by_phandle() in pru_rproc_get() *) Provided background of Ctable in the commit messege. *) Removed patch "" [15] (6th Patch of the v5 of this series) as it has dependency on series [2], thus creating a cyclic dependency. The patch [15] will be sent along with the next version of series [2]. [1] https://patchwork.kernel.org/project/linux-remoteproc/cover/20220603121520.13730-1-p-mohan@ti.com/ [2] https://lore.kernel.org/all/20220418123004.9332-1-p-mohan@ti.com/ [3] https://lore.kernel.org/all/20220531095108.21757-1-p-mohan@ti.com/ [4] https://patchwork.kernel.org/project/linux-remoteproc/cover/20220406094358.7895-1-p-mohan@ti.com/ [5] https://lore.kernel.org/all/20220607045650.4999-1-p-mohan@ti.com/ [6] https://lore.kernel.org/all/20221012114429.2341215-1-danishanwar@ti.com/ [7] https://lore.kernel.org/all/20221031073801.130541-1-danishanwar@ti.com/ [8] https://lore.kernel.org/all/20221116121634.2901265-1-danishanwar@ti.com/ [9] https://lore.kernel.org/all/20221118111924.3277838-1-danishanwar@ti.com/ [10] https://lore.kernel.org/all/20221201110500.4017889-1-danishanwar@ti.com/ [11] https://lore.kernel.org/all/20221207110411.441692-1-danishanwar@ti.com/ [12] https://lore.kernel.org/all/20221216053313.2974826-1-danishanwar@ti.com/ [13] https://lore.kernel.org/all/20230105092149.686201-1-danishanwar@ti.com/ [14] https://www.kernel.org/doc/html/v6.0/doc-guide/kernel-doc.html#structure-union-and-enumeration-documentation [15] https://lore.kernel.org/all/20220607045650.4999-7-p-mohan@ti.com/ Thanks and Regards, Md Danish Anwar MD Danish Anwar (2): remoteproc: pru: Add enum for PRU Core Identifiers. remoteproc: pru: Add APIs to get and put the PRU cores Roger Quadros (1): remoteproc: pru: Add pru_rproc_set_ctable() function Suman Anna (2): dt-bindings: remoteproc: Add PRU consumer bindings remoteproc: pru: Make sysfs entries read-only for PRU client driven boots Tero Kristo (1): remoteproc: pru: Configure firmware based on client setup .../bindings/remoteproc/ti,pru-consumer.yaml | 60 +++++ drivers/remoteproc/pru_rproc.c | 230 +++++++++++++++++- include/linux/remoteproc/pruss.h | 83 +++++++ 3 files changed, 368 insertions(+), 5 deletions(-) create mode 100644 Documentation/devicetree/bindings/remoteproc/ti,pru-consumer.yaml create mode 100644 include/linux/remoteproc/pruss.h