Message ID | 20230904055010.4118982-1-quic_viswanat@quicinc.com (mailing list archive) |
---|---|
Headers | show |
Series | Fix tcsr_mutex register for IPQ6018 | expand |
On 4.09.2023 07:50, Vignesh Viswanathan wrote: > IPQ6018 has 32 tcsr_mutext hwlock registers of 0x1000 size each. > The compatible string qcom,ipq6018-tcsr-mutex is mapped to > of_msm8226_tcsr_mutex which has 32 locks configured with stride of 0x80 > and doesn't match the HW present in IPQ6018. > > This series fixes the following: > 1. Fix the tcsr_mutex hwlock register size to 0x20000 in ipq6018.dtsi. > 2. Remove qcom,ipq6018-tcsr-mutex compatible string for tcsr_mutex in > ipq6018.dtsi. > 3. Drop unused qcom,ipq6018-tcsr-mutex compatible string from > qcom_hwspinlock driver and dt-bindings. > Sounds like 20230904063344.4144086-1-quic_viswanat@quicinc.com can't go in without this then? Konrad
On 9/4/2023 9:28 PM, Konrad Dybcio wrote: > On 4.09.2023 07:50, Vignesh Viswanathan wrote: >> IPQ6018 has 32 tcsr_mutext hwlock registers of 0x1000 size each. >> The compatible string qcom,ipq6018-tcsr-mutex is mapped to >> of_msm8226_tcsr_mutex which has 32 locks configured with stride of 0x80 >> and doesn't match the HW present in IPQ6018. >> >> This series fixes the following: >> 1. Fix the tcsr_mutex hwlock register size to 0x20000 in ipq6018.dtsi. >> 2. Remove qcom,ipq6018-tcsr-mutex compatible string for tcsr_mutex in >> ipq6018.dtsi. >> 3. Drop unused qcom,ipq6018-tcsr-mutex compatible string from >> qcom_hwspinlock driver and dt-bindings. >> > Sounds like 20230904063344.4144086-1-quic_viswanat@quicinc.com can't > go in without this then? > They can independently go in as the current max size and stride set for IPQ6018 still has 32 locks and moving the index 3 shouldn't cause any issues. However, functionally IPQ6018's HW lock is broken and will be fixed once this series goes in. Thanks, Vignesh > Konrad