mbox series

[v2,0/2] Fix tcsr_mutex register for IPQ6018

Message ID 20230905095535.1263113-1-quic_viswanat@quicinc.com (mailing list archive)
Headers show
Series Fix tcsr_mutex register for IPQ6018 | expand

Message

Vignesh Viswanathan Sept. 5, 2023, 9:55 a.m. UTC
IPQ6018 has 32 tcsr_mutex hwlock registers of 0x1000 size each.
The compatible string qcom,ipq6018-tcsr-mutex is mapped to
of_msm8226_tcsr_mutex which has 32 locks configured with stride of 0x80
and doesn't match the HW present in IPQ6018.

This series fixes the following:
 1. Fix the tcsr_mutex register size to 0x20000 in IPQ6018 DTSI.
 2. Remove IPQ6018 specific compatible in hwspinlock driver so that it
    falls back to pick of_tcsr_mutex data.

Changes in v2:
 - Drop changes to remove qcom,ipq6018-tcsr-mutex from dt-bindings
 - Drop changes to remove qcom,ipq6018-tcsr-mutex compatible from
   ipq6018.dtsi
 - Add Fixes and stable tags

Vignesh Viswanathan (2):
  arm64: dts: qcom: ipq6018: Fix tcsr_mutex register size
  hwspinlock: qcom: Remove IPQ6018 SOC specific compatible

 arch/arm64/boot/dts/qcom/ipq6018.dtsi | 2 +-
 drivers/hwspinlock/qcom_hwspinlock.c  | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

Comments

Bjorn Andersson Sept. 20, 2023, 3:58 a.m. UTC | #1
On Tue, 05 Sep 2023 15:25:33 +0530, Vignesh Viswanathan wrote:
> IPQ6018 has 32 tcsr_mutex hwlock registers of 0x1000 size each.
> The compatible string qcom,ipq6018-tcsr-mutex is mapped to
> of_msm8226_tcsr_mutex which has 32 locks configured with stride of 0x80
> and doesn't match the HW present in IPQ6018.
> 
> This series fixes the following:
>  1. Fix the tcsr_mutex register size to 0x20000 in IPQ6018 DTSI.
>  2. Remove IPQ6018 specific compatible in hwspinlock driver so that it
>     falls back to pick of_tcsr_mutex data.
> 
> [...]

Applied, thanks!

[1/2] arm64: dts: qcom: ipq6018: Fix tcsr_mutex register size
      commit: 72fc3d58b87b0d622039c6299b89024fbb7b420f

Best regards,
Bjorn Andersson Sept. 20, 2023, 5:02 p.m. UTC | #2
On Tue, 05 Sep 2023 15:25:33 +0530, Vignesh Viswanathan wrote:
> IPQ6018 has 32 tcsr_mutex hwlock registers of 0x1000 size each.
> The compatible string qcom,ipq6018-tcsr-mutex is mapped to
> of_msm8226_tcsr_mutex which has 32 locks configured with stride of 0x80
> and doesn't match the HW present in IPQ6018.
> 
> This series fixes the following:
>  1. Fix the tcsr_mutex register size to 0x20000 in IPQ6018 DTSI.
>  2. Remove IPQ6018 specific compatible in hwspinlock driver so that it
>     falls back to pick of_tcsr_mutex data.
> 
> [...]

Applied, thanks!

[2/2] hwspinlock: qcom: Remove IPQ6018 SOC specific compatible
      commit: 823313068617bf2414c6067504b4e2ce5768e601

Best regards,