| Message ID | 20240311-qcom-pd-mapper-v4-0-24679cca5c24@linaro.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | soc: qcom: add in-kernel pd-mapper implementation | expand |
On 11/03/2024 16:34, Dmitry Baryshkov wrote: > Protection domain mapper is a QMI service providing mapping between > 'protection domains' and services supported / allowed in these domains. > For example such mapping is required for loading of the WiFi firmware or > for properly starting up the UCSI / altmode / battery manager support. > > The existing userspace implementation has several issue. It doesn't play > well with CONFIG_EXTRA_FIRMWARE, it doesn't reread the JSON files if the > firmware location is changed (or if the firmware was not available at > the time pd-mapper was started but the corresponding directory is > mounted later), etc. > > However this configuration is largely static and common between > different platforms. Provide in-kernel service implementing static > per-platform data. > > NOTE: this is an RFC / RFT, the domain mapping data might be inaccurate > (especially for SM6xxx and SC7xxx platforms), which is reflected by > several TODO and FIXME comments in the code. > > -- > 2.39.2 > > --- > Changes in v4: > - Fixed missing chunk, reenabled kfree in qmi_del_server (Konrad) > - Added configuration for sm6350 (Thanks to Luca) > - Removed RFC tag (Konrad) > - Link to v3: https://lore.kernel.org/r/20240304-qcom-pd-mapper-v3-0-6858fa1ac1c8@linaro.org > > Changes in RFC v3: > - Send start / stop notifications when PD-mapper domain list is changed > - Reworked the way PD-mapper treats protection domains, register all of > them in a single batch > - Added SC7180 domains configuration based on TCL Book 14 GO > - Link to v2: https://lore.kernel.org/r/20240301-qcom-pd-mapper-v2-0-5d12a081d9d1@linaro.org > > Changes in RFC v2: > - Swapped num_domains / domains (Konrad) > - Fixed an issue with battery not working on sc8280xp > - Added missing configuration for QCS404 > > --- > Dmitry Baryshkov (7): > soc: qcom: pdr: protect locator_addr with the main mutex > soc: qcom: qmi: add a way to remove running service > soc: qcom: add pd-mapper implementation > remoteproc: qcom: pas: correct data indentation > remoteproc: qcom: adsp: add configuration for in-kernel pdm > remoteproc: qcom: mss: add configuration for in-kernel pdm > remoteproc: qcom: pas: add configuration for in-kernel pdm > > drivers/remoteproc/Kconfig | 3 + > drivers/remoteproc/qcom_q6v5_adsp.c | 82 +++++- > drivers/remoteproc/qcom_q6v5_mss.c | 80 +++++- > drivers/remoteproc/qcom_q6v5_pas.c | 502 ++++++++++++++++++++++++++++++------ > drivers/soc/qcom/Kconfig | 10 + > drivers/soc/qcom/Makefile | 2 + > drivers/soc/qcom/pdr_interface.c | 6 +- > drivers/soc/qcom/qcom_pdm.c | 346 +++++++++++++++++++++++++ > drivers/soc/qcom/qcom_pdm_msg.c | 188 ++++++++++++++ > drivers/soc/qcom/qcom_pdm_msg.h | 66 +++++ > drivers/soc/qcom/qmi_interface.c | 67 +++++ > include/linux/soc/qcom/pd_mapper.h | 39 +++ > include/linux/soc/qcom/qmi.h | 2 + > 13 files changed, 1302 insertions(+), 91 deletions(-) > --- > base-commit: 1843e16d2df9d98427ef8045589571749d627cf7 > change-id: 20240301-qcom-pd-mapper-e12d622d4ad0 > > Best regards, With: =================><=============================================== diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c index ba53df7ea30e..1cfc52d5247b 100644 --- a/drivers/remoteproc/qcom_q6v5_pas.c +++ b/drivers/remoteproc/qcom_q6v5_pas.c @@ -909,6 +909,13 @@ static const struct qcom_pdm_domain_data *sm8350_adsp_domains[] = { &adsp_charger_pd, }; +static const struct qcom_pdm_domain_data *sm8550_adsp_domains[] = { + &adsp_audio_pd, + &adsp_sensor_pd, + &adsp_root_pd, + &adsp_charger_pd, +}; + static const struct qcom_pdm_domain_data cdsp_root_pd = { .domain = "msm/cdsp/root_pd", .instance_id = 76, @@ -1477,8 +1484,8 @@ static const struct adsp_data sm8550_adsp_resource = { .ssr_name = "lpass", .sysmon_name = "adsp", .ssctl_id = 0x14, - .domains = sm8350_adsp_domains, - .num_domains = ARRAY_SIZE(sm8350_adsp_domains), + .domains = sm8550_adsp_domains, + .num_domains = ARRAY_SIZE(sm8550_adsp_domains), }; static const struct adsp_data sm8550_cdsp_resource = { =================><=============================================== Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8550-QRD Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8650-QRD Thanks, Neil
Protection domain mapper is a QMI service providing mapping between 'protection domains' and services supported / allowed in these domains. For example such mapping is required for loading of the WiFi firmware or for properly starting up the UCSI / altmode / battery manager support. The existing userspace implementation has several issue. It doesn't play well with CONFIG_EXTRA_FIRMWARE, it doesn't reread the JSON files if the firmware location is changed (or if the firmware was not available at the time pd-mapper was started but the corresponding directory is mounted later), etc. However this configuration is largely static and common between different platforms. Provide in-kernel service implementing static per-platform data. NOTE: this is an RFC / RFT, the domain mapping data might be inaccurate (especially for SM6xxx and SC7xxx platforms), which is reflected by several TODO and FIXME comments in the code. -- 2.39.2 --- Changes in v4: - Fixed missing chunk, reenabled kfree in qmi_del_server (Konrad) - Added configuration for sm6350 (Thanks to Luca) - Removed RFC tag (Konrad) - Link to v3: https://lore.kernel.org/r/20240304-qcom-pd-mapper-v3-0-6858fa1ac1c8@linaro.org Changes in RFC v3: - Send start / stop notifications when PD-mapper domain list is changed - Reworked the way PD-mapper treats protection domains, register all of them in a single batch - Added SC7180 domains configuration based on TCL Book 14 GO - Link to v2: https://lore.kernel.org/r/20240301-qcom-pd-mapper-v2-0-5d12a081d9d1@linaro.org Changes in RFC v2: - Swapped num_domains / domains (Konrad) - Fixed an issue with battery not working on sc8280xp - Added missing configuration for QCS404 --- Dmitry Baryshkov (7): soc: qcom: pdr: protect locator_addr with the main mutex soc: qcom: qmi: add a way to remove running service soc: qcom: add pd-mapper implementation remoteproc: qcom: pas: correct data indentation remoteproc: qcom: adsp: add configuration for in-kernel pdm remoteproc: qcom: mss: add configuration for in-kernel pdm remoteproc: qcom: pas: add configuration for in-kernel pdm drivers/remoteproc/Kconfig | 3 + drivers/remoteproc/qcom_q6v5_adsp.c | 82 +++++- drivers/remoteproc/qcom_q6v5_mss.c | 80 +++++- drivers/remoteproc/qcom_q6v5_pas.c | 502 ++++++++++++++++++++++++++++++------ drivers/soc/qcom/Kconfig | 10 + drivers/soc/qcom/Makefile | 2 + drivers/soc/qcom/pdr_interface.c | 6 +- drivers/soc/qcom/qcom_pdm.c | 346 +++++++++++++++++++++++++ drivers/soc/qcom/qcom_pdm_msg.c | 188 ++++++++++++++ drivers/soc/qcom/qcom_pdm_msg.h | 66 +++++ drivers/soc/qcom/qmi_interface.c | 67 +++++ include/linux/soc/qcom/pd_mapper.h | 39 +++ include/linux/soc/qcom/qmi.h | 2 + 13 files changed, 1302 insertions(+), 91 deletions(-) --- base-commit: 1843e16d2df9d98427ef8045589571749d627cf7 change-id: 20240301-qcom-pd-mapper-e12d622d4ad0 Best regards,