| Message ID | 20240407-qcom-halt-regs-fixup-v1-0-a0ea4e2c178e@z3ntu.xyz (mailing list archive) |
|---|---|
| Headers | show |
| Series | Fix up qcom,halt-regs definition in various schemas | expand |
On Sun, Apr 07, 2024 at 11:58:29AM +0200, Luca Weiss wrote: > The original motivation is that a bunch of other schemas fail to > validate qcom,halt-regs, for example like in the following examples: > > arch/arm64/boot/dts/qcom/apq8016-sbc.dtb: remoteproc@4080000: qcom,halt-regs:0: [20] is too short > from schema $id: http://devicetree.org/schemas/remoteproc/qcom,msm8916-mss-pil.yaml# > arch/arm64/boot/dts/qcom/apq8096-ifc6640.dtb: remoteproc@2080000: qcom,halt-regs:0: [82] is too short > from schema $id: http://devicetree.org/schemas/remoteproc/qcom,msm8996-mss-pil.yaml# > arch/arm64/boot/dts/qcom/apq8039-t2.dtb: remoteproc@4080000: qcom,halt-regs:0: [32] is too short > from schema $id: http://devicetree.org/schemas/remoteproc/qcom,msm8916-mss-pil.yaml# > > While I'm actually not quite sure why these patches fix this in > the other schemas - feels like a bug/limitation in dt-schema maybe? - Was this with v2024.02? It should be a bit better there. Though it may just have different errors. The limitation is that property types and in the case of matrix's (which phandle-array actually is) range for dimensions are global. So if there's not correct dimensions for a property, the tools aren't going to decode it properly. Rob
On Dienstag, 9. April 2024 17:10:41 CEST Rob Herring wrote: > On Sun, Apr 07, 2024 at 11:58:29AM +0200, Luca Weiss wrote: > > The original motivation is that a bunch of other schemas fail to > > validate qcom,halt-regs, for example like in the following examples: > > > > arch/arm64/boot/dts/qcom/apq8016-sbc.dtb: remoteproc@4080000: qcom,halt-regs:0: [20] is too short > > from schema $id: http://devicetree.org/schemas/remoteproc/qcom,msm8916-mss-pil.yaml# > > arch/arm64/boot/dts/qcom/apq8096-ifc6640.dtb: remoteproc@2080000: qcom,halt-regs:0: [82] is too short > > from schema $id: http://devicetree.org/schemas/remoteproc/qcom,msm8996-mss-pil.yaml# > > arch/arm64/boot/dts/qcom/apq8039-t2.dtb: remoteproc@4080000: qcom,halt-regs:0: [32] is too short > > from schema $id: http://devicetree.org/schemas/remoteproc/qcom,msm8916-mss-pil.yaml# > > > > While I'm actually not quite sure why these patches fix this in > > the other schemas - feels like a bug/limitation in dt-schema maybe? - > > Was this with v2024.02? It should be a bit better there. Though it > may just have different errors. The limitation is that property > types and in the case of matrix's (which phandle-array actually is) > range for dimensions are global. So if there's not correct dimensions > for a property, the tools aren't going to decode it properly. You're right, I doesn't look like I can reproduce this with the latest dtschema installed. Anyways these patches should be good to actually validate qcom,halt-regs for the schemas I'm touching here. Regards Luca > > Rob >
On Sun, 07 Apr 2024 11:58:29 +0200, Luca Weiss wrote: > The original motivation is that a bunch of other schemas fail to > validate qcom,halt-regs, for example like in the following examples: > > arch/arm64/boot/dts/qcom/apq8016-sbc.dtb: remoteproc@4080000: qcom,halt-regs:0: [20] is too short > from schema $id: http://devicetree.org/schemas/remoteproc/qcom,msm8916-mss-pil.yaml# > arch/arm64/boot/dts/qcom/apq8096-ifc6640.dtb: remoteproc@2080000: qcom,halt-regs:0: [82] is too short > from schema $id: http://devicetree.org/schemas/remoteproc/qcom,msm8996-mss-pil.yaml# > arch/arm64/boot/dts/qcom/apq8039-t2.dtb: remoteproc@4080000: qcom,halt-regs:0: [32] is too short > from schema $id: http://devicetree.org/schemas/remoteproc/qcom,msm8916-mss-pil.yaml# > > [...] Applied, thanks! [1/3] dt-bindings: remoteproc: qcom,qcs404-cdsp-pil: Fix qcom,halt-regs definition commit: a0bcbce661216b9d9d00fb652b35f35da77b2287 [2/3] dt-bindings: remoteproc: qcom,sc7280-wpss-pil: Fix qcom,halt-regs definition commit: 16e204e958096d649aa1617433f31995a9c60809 [3/3] dt-bindings: remoteproc: qcom,sdm845-adsp-pil: Fix qcom,halt-regs definition commit: 4d5ba6ead1dc9fa298d727e92db40cd98564d1ac Best regards,
The original motivation is that a bunch of other schemas fail to validate qcom,halt-regs, for example like in the following examples: arch/arm64/boot/dts/qcom/apq8016-sbc.dtb: remoteproc@4080000: qcom,halt-regs:0: [20] is too short from schema $id: http://devicetree.org/schemas/remoteproc/qcom,msm8916-mss-pil.yaml# arch/arm64/boot/dts/qcom/apq8096-ifc6640.dtb: remoteproc@2080000: qcom,halt-regs:0: [82] is too short from schema $id: http://devicetree.org/schemas/remoteproc/qcom,msm8996-mss-pil.yaml# arch/arm64/boot/dts/qcom/apq8039-t2.dtb: remoteproc@4080000: qcom,halt-regs:0: [32] is too short from schema $id: http://devicetree.org/schemas/remoteproc/qcom,msm8916-mss-pil.yaml# While I'm actually not quite sure why these patches fix this in the other schemas - feels like a bug/limitation in dt-schema maybe? - the patches should be correct anyways to validate qcom,halt-regs in the schemas I'm touching. Signed-off-by: Luca Weiss <luca@z3ntu.xyz> --- Luca Weiss (3): dt-bindings: remoteproc: qcom,qcs404-cdsp-pil: Fix qcom,halt-regs definition dt-bindings: remoteproc: qcom,sc7280-wpss-pil: Fix qcom,halt-regs definition dt-bindings: remoteproc: qcom,sdm845-adsp-pil: Fix qcom,halt-regs definition .../devicetree/bindings/remoteproc/qcom,qcs404-cdsp-pil.yaml | 6 +++++- .../devicetree/bindings/remoteproc/qcom,sc7280-wpss-pil.yaml | 6 +++++- .../devicetree/bindings/remoteproc/qcom,sdm845-adsp-pil.yaml | 6 +++++- 3 files changed, 15 insertions(+), 3 deletions(-) --- base-commit: 8568bb2ccc278f344e6ac44af6ed010a90aa88dc change-id: 20240407-qcom-halt-regs-fixup-2c6cce9734e4 Best regards,