From patchwork Thu Apr 11 02:35:22 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xuan Zhuo X-Patchwork-Id: 13625338 Received: from out30-111.freemail.mail.aliyun.com (out30-111.freemail.mail.aliyun.com [115.124.30.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5762238C; Thu, 11 Apr 2024 02:35:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.30.111 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712802936; cv=none; b=f1qBsvTCXZdpCIyT2vjmFzjGZlm+eBw32DBaF4UKsG4sBJ91n1D2z4udpXrLkfanyuk/LMOo8cQCIL3+YA1K5H2FZhIi5iq3GNXzTR6dz81qClAW770UfJy5kg2xeeEs6mVkkOcHDdJNmkCUWuuRDxdTUFpaFWJP/MP5J7Ptwnw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712802936; c=relaxed/simple; bh=X/h6jJmg7pdb7oBPTYgjlDbTNF50GDbNhn/fUDDm2TE=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Content-Type; b=Ggasj/vCmqtpa5F6GoRL3iQ4v+O4rnOSmzhATmqNB9x9hFj9tA3dMwaBGfVG7G5e/bd9dt4DNIfZvR1hKwmDn0rDadiblUIb87WVzGfvFtFN/G09ec5qgNo5pQhnORxB075husMEk6201V+bdINjZOBGnbkQOBu1VXwwSfK2qj8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b=jp9OIj++; arc=none smtp.client-ip=115.124.30.111 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b="jp9OIj++" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1712802930; h=From:To:Subject:Date:Message-Id:MIME-Version:Content-Type; bh=4SIkgH9C8lwT74kHhHbMGvxYj1Nu+sbNA2gSlRxGlA4=; b=jp9OIj++XmxPWL74rBIhu4cFTU5opOuTcmrowK2Tcyv+nxY0q+PEX5HngbGDCGHVtyrPFa6xjBZ0LNcK9q5VeIxtNWWYKPWR88YAWm2ofWY/P0AvJTcq3BZF7toHMZe/dvZyKczEbNFYTwvHScL67kOu4eqVUJEcFDePyMLZhT8= X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R181e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045170;MF=xuanzhuo@linux.alibaba.com;NM=1;PH=DS;RN=26;SR=0;TI=SMTPD_---0W4JW4Gq_1712802928; Received: from localhost(mailfrom:xuanzhuo@linux.alibaba.com fp:SMTPD_---0W4JW4Gq_1712802928) by smtp.aliyun-inc.com; Thu, 11 Apr 2024 10:35:29 +0800 From: Xuan Zhuo To: virtualization@lists.linux.dev Cc: Richard Weinberger , Anton Ivanov , Johannes Berg , Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Vadim Pasternak , Bjorn Andersson , Mathieu Poirier , Cornelia Huck , Halil Pasic , Eric Farman , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , "Michael S. Tsirkin" , David Hildenbrand , Jason Wang , Xuan Zhuo , linux-um@lists.infradead.org, platform-driver-x86@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org Subject: [PATCH vhost v8 0/6] refactor the params of find_vqs() Date: Thu, 11 Apr 2024 10:35:22 +0800 Message-Id: <20240411023528.10914-1-xuanzhuo@linux.alibaba.com> X-Mailer: git-send-email 2.32.0.3.g01195cf9f Precedence: bulk X-Mailing-List: linux-remoteproc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Git-Hash: d277a0b9519b This pathset is splited from the http://lore.kernel.org/all/20240229072044.77388-1-xuanzhuo@linux.alibaba.com That may needs some cycles to discuss. But that notifies too many people. But just the four commits need to notify so many people. And four commits are independent. So I split that patch set, let us review these first. The patch set try to refactor the params of find_vqs(). Then we can just change the structure, when introducing new features. Thanks. v8: 1. rebase the vhost branch v7: 1. fix two bugs. @Jason v6: 1. virtio_balloon: a single variable for both purposes. 2. if names[i] is null, return error v5: 1. virtio_balloon: follow David Hildenbrand's suggest http://lore.kernel.org/all/3620be9c-e288-4ff2-a7be-1fcf806e6e6e@redhat.com 2. fix bug of the reference of "cfg_idx" http://lore.kernel.org/all/202403222227.Sdp23Lcb-lkp@intel.com v4: 1. remove support for names array entries being null 2. remove cfg_idx from virtio_vq_config v3: 1. fix the bug: "assignment of read-only location '*cfg.names'" v2: 1. add kerneldoc for "struct vq_transport_config" @ilpo.jarvinen v1: 1. fix some comments from ilpo.jarvinen@linux.intel.com Xuan Zhuo (6): virtio_balloon: remove the dependence where names[] is null virtio: remove support for names array entries being null. virtio: find_vqs: pass struct instead of multi parameters virtio: vring_create_virtqueue: pass struct instead of multi parameters virtio: vring_new_virtqueue(): pass struct instead of multi parameters virtio_ring: simplify the parameters of the funcs related to vring_create/new_virtqueue() arch/um/drivers/virtio_uml.c | 36 +++-- drivers/platform/mellanox/mlxbf-tmfifo.c | 23 +-- drivers/remoteproc/remoteproc_virtio.c | 37 +++-- drivers/s390/virtio/virtio_ccw.c | 38 ++--- drivers/virtio/virtio_balloon.c | 48 +++---- drivers/virtio/virtio_mmio.c | 36 +++-- drivers/virtio/virtio_pci_common.c | 69 ++++----- drivers/virtio/virtio_pci_common.h | 9 +- drivers/virtio/virtio_pci_legacy.c | 16 ++- drivers/virtio/virtio_pci_modern.c | 37 +++-- drivers/virtio/virtio_ring.c | 173 ++++++++--------------- drivers/virtio/virtio_vdpa.c | 51 ++++--- include/linux/virtio_config.h | 76 +++++++--- include/linux/virtio_ring.h | 93 +++++++----- tools/virtio/virtio_test.c | 4 +- tools/virtio/vringh_test.c | 28 ++-- 16 files changed, 382 insertions(+), 392 deletions(-) --- 2.32.0.3.g01195cf9f