| Message ID | 20240430105307.1190615-1-b-padhi@ti.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | remoteproc: k3-r5: Wait for core0 power-up before powering up core1 | expand |
On Tue, Apr 30, 2024 at 04:23:05PM +0530, Beleswar Padhi wrote: > PSC controller has a limitation that it can only power-up the second core > when the first core is in ON state. Power-state for core0 should be equal > to or higher than core1, else the kernel is seen hanging during rproc > loading. > > Make the powering up of cores sequential, by waiting for the current core > to power-up before proceeding to the next core, with a timeout of 2sec. > Add a wait queue event in k3_r5_cluster_rproc_init call, that will wait > for the current core to be released from reset before proceeding with the > next core. > > Also, ensure that core1 can not be powered on before core0 when starting > cores from sysfs. Similarly, ensure that core0 can not be shutdown > before core1 from sysfs. > > v3: Changelog: > 1) Added my own Signed-off-by in PATCH 1, specifying the changes done > 2) Addressed changes requested by adding comments in code in PATCH 1 > > Link to v2: > https://lore.kernel.org/all/20240424130504.494916-1-b-padhi@ti.com/ > > v2: Changelog: > 1) Fixed multi-line comment format > 2) Included root cause of bug in comments > 3) Added a patch to ensure power-up/shutdown is sequential via sysfs > > Link to v1: > https://lore.kernel.org/all/20230906124756.3480579-1-a-nandan@ti.com/ > > Apurva Nandan (1): > remoteproc: k3-r5: Wait for core0 power-up before powering up core1 > > Beleswar Padhi (1): > remoteproc: k3-r5: Do not allow core1 to power up before core0 via > sysfs > > drivers/remoteproc/ti_k3_r5_remoteproc.c | 56 +++++++++++++++++++++++- > 1 file changed, 54 insertions(+), 2 deletions(-) Applied - thanks, Mathieu > > -- > 2.34.1 >
PSC controller has a limitation that it can only power-up the second core when the first core is in ON state. Power-state for core0 should be equal to or higher than core1, else the kernel is seen hanging during rproc loading. Make the powering up of cores sequential, by waiting for the current core to power-up before proceeding to the next core, with a timeout of 2sec. Add a wait queue event in k3_r5_cluster_rproc_init call, that will wait for the current core to be released from reset before proceeding with the next core. Also, ensure that core1 can not be powered on before core0 when starting cores from sysfs. Similarly, ensure that core0 can not be shutdown before core1 from sysfs. v3: Changelog: 1) Added my own Signed-off-by in PATCH 1, specifying the changes done 2) Addressed changes requested by adding comments in code in PATCH 1 Link to v2: https://lore.kernel.org/all/20240424130504.494916-1-b-padhi@ti.com/ v2: Changelog: 1) Fixed multi-line comment format 2) Included root cause of bug in comments 3) Added a patch to ensure power-up/shutdown is sequential via sysfs Link to v1: https://lore.kernel.org/all/20230906124756.3480579-1-a-nandan@ti.com/ Apurva Nandan (1): remoteproc: k3-r5: Wait for core0 power-up before powering up core1 Beleswar Padhi (1): remoteproc: k3-r5: Do not allow core1 to power up before core0 via sysfs drivers/remoteproc/ti_k3_r5_remoteproc.c | 56 +++++++++++++++++++++++- 1 file changed, 54 insertions(+), 2 deletions(-)