[V3,0/2] Use of devname for interrupt descriptions and tracepoint support for smp2p

Message

Sudeepgoud Patil June 27, 2024, 10:48 a.m. UTC

This commit enhances the smp2p driver by adding support for using the device
name in interrupt descriptions and introducing tracepoint functionality.
These improvements facilitate more effective debugging of smp2p-related issues.

The devname patch, along with the callback to print the irq chip name as the
device name and the removal of the ‘smp2p’ string from the irq request,
results in a unique interrupt description.

Tracepoint functionality captures essential details such as subsystem name,
negotiation specifics, supported features, bit changes, and subsystem restart
activity. These enhancements significantly improve debugging capabilities
for inter-subsystem issues.

Changes in v3:
- Updated patch to use devname for interrupt descriptions with a different approach.
- Modified tracepoint patch by removing remote_pid field from all tracepoints.
- Using SMP2P_FEATURE_SSR_ACK definition from smp2p.c instead of redefiniton. 
- Link to v2: https://lore.kernel.org/all/[e-mail]

Changes in v2:
- Added support to include the remote name in the smp2p IRQ devname, allowing for remote PID-name mapping
- Mapped the remote PID (Process ID) along with the remote name in tracepoints, as suggested by Chris
- Modified to capture all `out->features` instead of just the `ssr_ack`, following Chris's recommendation
- Expanded the commit description to provide additional context
- Link to v1: https://lore.kernel.org/all/[e-mail]

Chris Lew (1):
  soc: qcom: smp2p: Use devname for interrupt descriptions

Sudeepgoud Patil (1):
  soc: qcom: smp2p: Introduce tracepoint support

 drivers/soc/qcom/Makefile      |  1 +
 drivers/soc/qcom/smp2p.c       | 20 ++++++-
 drivers/soc/qcom/trace-smp2p.h | 98 ++++++++++++++++++++++++++++++++++
 3 files changed, 118 insertions(+), 1 deletion(-)
 create mode 100644 drivers/soc/qcom/trace-smp2p.h

--

Comments

Bjorn Andersson July 3, 2024, 3:37 a.m. UTC | #1

On Thu, 27 Jun 2024 16:18:29 +0530, Sudeepgoud Patil wrote:
> This commit enhances the smp2p driver by adding support for using the device
> name in interrupt descriptions and introducing tracepoint functionality.
> These improvements facilitate more effective debugging of smp2p-related issues.
> 
> The devname patch, along with the callback to print the irq chip name as the
> device name and the removal of the ‘smp2p’ string from the irq request,
> results in a unique interrupt description.
> 
> [...]

Applied, thanks!

[1/2] soc: qcom: smp2p: Use devname for interrupt descriptions
      commit: e49380c155940cb47e291a4b3fcb7fdffee6aa4d

Best regards,