From patchwork Sat Oct 8 04:23:15 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Andersson X-Patchwork-Id: 9367975 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7EB6960487 for ; Sat, 8 Oct 2016 04:23:53 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 686DB298A5 for ; Sat, 8 Oct 2016 04:23:53 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5D2AB298BE; Sat, 8 Oct 2016 04:23:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C41D3298AE for ; Sat, 8 Oct 2016 04:23:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754049AbcJHEXr (ORCPT ); Sat, 8 Oct 2016 00:23:47 -0400 Received: from mail-pf0-f180.google.com ([209.85.192.180]:33905 "EHLO mail-pf0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752978AbcJHEXc (ORCPT ); Sat, 8 Oct 2016 00:23:32 -0400 Received: by mail-pf0-f180.google.com with SMTP id e6so31689651pfk.1 for ; Fri, 07 Oct 2016 21:23:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=OKaWtWJdZ6JHLAh5FsSl4a3J8eWePxRIhEO+BGRwJEc=; b=HWaPOmT9xrR2ISrFKg/UxEgFvZ8qHLMNteTy8LJRnXiPi45rpAlVxuiTWq7427s+V8 L2iGu04EWiCp3tKbOtxag29yaUK+iDIonBmreB1pw80B6qKJlIT2Ngma7eGVwwKHF4bn p1QnC+KwU87BXJdZ88G0c5Z3rIaLvvx0fnFHo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=OKaWtWJdZ6JHLAh5FsSl4a3J8eWePxRIhEO+BGRwJEc=; b=IC0wm4jmotFgWDWbjPXoLJfe1fW2zQPDSYZ/aoUPZCpEFm6UO/EKHkBBxL1rNQ23QH VMd7ICivlzcoMXKXee+cLHpwkNfD8XTIJA8VQFPcnXw6WJFlNC4L6Ych1gLkTCbJMcJ7 9oF5r1Cd1hEsiv6bvX2IlOEVYMZSMAWf6cRosATOEDx/1e+gXR99xoRXjOE/6wTGsy0T vuisTqS5CBmY8Hr3BOvgKST72KkVj1i//HdQzHtpf4jHYrOzehmxoYXx3a+hnKeEp0Ne NZWL7IYCiyZgvx4Ic9mQB775Cm+tdvIjiGnqUm9yedq4c7MNNfzOz+jjzM1HObxKPA+X V5ZQ== X-Gm-Message-State: AA6/9RmncD2WpgLaalIUF9YTmgdI+udch8fkHV7vB3mn2eisY6tYNcMnHq6vaocsPurOtARU X-Received: by 10.98.7.4 with SMTP id b4mr24844984pfd.136.1475900611343; Fri, 07 Oct 2016 21:23:31 -0700 (PDT) Received: from localhost.localdomain (ip68-111-223-48.sd.sd.cox.net. [68.111.223.48]) by smtp.gmail.com with ESMTPSA id t67sm17537506pfd.32.2016.10.07.21.23.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 07 Oct 2016 21:23:30 -0700 (PDT) From: Bjorn Andersson To: Ohad Ben-Cohen , Bjorn Andersson Cc: Jonathan Corbet , Linus Walleij , Marek Novak , Matteo Sartori , Michal Simek , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: [PATCH 5/5] rpmsg: smd: Register rpmsg user space interface for edges Date: Fri, 7 Oct 2016 21:23:15 -0700 Message-Id: <1475900595-8375-5-git-send-email-bjorn.andersson@linaro.org> X-Mailer: git-send-email 2.5.0 In-Reply-To: <1475900595-8375-1-git-send-email-bjorn.andersson@linaro.org> References: <1475900595-8375-1-git-send-email-bjorn.andersson@linaro.org> Sender: linux-remoteproc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Create and register a rpmsg device for use with the rpmsg user space interface, allowing user space to access SMD channels. Also provide the "rpmsg_name" device attribute to expose the edge name in sysfs, allowing the user to write udev rules for specific rpmsg devices and their children. Signed-off-by: Bjorn Andersson --- drivers/rpmsg/qcom_smd.c | 36 ++++++++++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) diff --git a/drivers/rpmsg/qcom_smd.c b/drivers/rpmsg/qcom_smd.c index 92efa74a0024..86856b2b558a 100644 --- a/drivers/rpmsg/qcom_smd.c +++ b/drivers/rpmsg/qcom_smd.c @@ -983,6 +983,20 @@ static int qcom_smd_create_device(struct qcom_smd_channel *channel) return rpmsg_register_device(rpdev); } +static int qcom_smd_create_chrdev(struct qcom_smd_edge *edge) +{ + struct qcom_smd_device *qsdev; + + qsdev = kzalloc(sizeof(*qsdev), GFP_KERNEL); + if (!qsdev) + return -ENOMEM; + + qsdev->edge = edge; + qsdev->rpdev.ops = &qcom_smd_device_ops; + qsdev->rpdev.dev.parent = &edge->dev; + return rpmsg_chrdev_register_device(&qsdev->rpdev); +} + /* * Allocate the qcom_smd_channel object for a newly found smd channel, * retrieving and validating the smem items involved. @@ -1284,6 +1298,21 @@ static void qcom_smd_edge_release(struct device *dev) kfree(edge); } +static ssize_t rpmsg_name_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + struct qcom_smd_edge *edge = to_smd_edge(dev); + + return sprintf(buf, "%s\n", edge->of_node->name); +} +static DEVICE_ATTR_RO(rpmsg_name); + +static struct attribute *qcom_smd_edge_attrs[] = { + &dev_attr_rpmsg_name.attr, + NULL +}; +ATTRIBUTE_GROUPS(qcom_smd_edge); + /** * qcom_smd_register_edge() - register an edge based on an device_node * @parent: parent device for the edge @@ -1305,6 +1334,7 @@ struct qcom_smd_edge *qcom_smd_register_edge(struct device *parent, edge->dev.parent = parent; edge->dev.release = qcom_smd_edge_release; + edge->dev.groups = qcom_smd_edge_groups; dev_set_name(&edge->dev, "%s:%s", dev_name(parent), node->name); ret = device_register(&edge->dev); if (ret) { @@ -1318,6 +1348,12 @@ struct qcom_smd_edge *qcom_smd_register_edge(struct device *parent, goto unregister_dev; } + ret = qcom_smd_create_chrdev(edge); + if (ret) { + dev_err(&edge->dev, "failed to register chrdev for edge\n"); + goto unregister_dev; + } + schedule_work(&edge->scan_work); return edge;