From patchwork Fri Dec 2 22:03:37 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Andersson X-Patchwork-Id: 9459331 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A8DBD60757 for ; Fri, 2 Dec 2016 22:05:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 999D22858E for ; Fri, 2 Dec 2016 22:05:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8BCC928599; Fri, 2 Dec 2016 22:05:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7A29628599 for ; Fri, 2 Dec 2016 22:05:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755532AbcLBWEx (ORCPT ); Fri, 2 Dec 2016 17:04:53 -0500 Received: from mail-pg0-f41.google.com ([74.125.83.41]:35971 "EHLO mail-pg0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752790AbcLBWE1 (ORCPT ); Fri, 2 Dec 2016 17:04:27 -0500 Received: by mail-pg0-f41.google.com with SMTP id f188so111296096pgc.3 for ; Fri, 02 Dec 2016 14:03:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=f+ckKY8JI7CGril9ed8VW70lGLWMPBxvQxgHgl0eicE=; b=AUD+906badpem3f+sW+aIlO0pLckfKE2623MTKYHSyfS+JMxp1p0mBf7sP3EVwKY75 xYuzsF4c7fusFHmZYoUMBHmme8rxvybfwkAIK8uAR/xWL/M9rDmB/tMSY0ruIIKYBHU/ BCtx7TgIPiYKwQ/iUer+W1W11SUtWwGKvfJfo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=f+ckKY8JI7CGril9ed8VW70lGLWMPBxvQxgHgl0eicE=; b=dVE3szF0E7pnT1Zh3SKHA4Swflq2HGaFUSXVfkov7sWzBDBekUrwQRLeq4RKj0ivhM nUA4eQHnV2PRG/KqUhCD4/NnW/mo2AuGSaBYj+lMbT7MvHnTvHyjg0odICQfChCB70uI jw0OYWJ/8DY7SqsHPy26ZAoI6maxI2THuw1nfRs3yaIVg/wwgef/7/ElvvgVjh5OQ020 icpHbIYkg8cipeIXdtGZTMZ6V7uJuoNYPbmqFtS4//1J1W0m2PVvk79/Uf5Cm16qN/91 VIsDggQv20iMTcqT6fvg2EL0q5pmGB+rcSHGpfxuJNoh+TSCMiaeiLT0RoS5DYvGLCWN M/LA== X-Gm-Message-State: AKaTC03Q2/3TpFLJZu/xnfDSTqa4CDJaq+hMhZKk3DGeS6PcnqFwPZCwUYLw49S5ef80e2F1 X-Received: by 10.98.215.85 with SMTP id v21mr46811827pfl.80.1480716226549; Fri, 02 Dec 2016 14:03:46 -0800 (PST) Received: from localhost.localdomain (ip68-111-223-48.sd.sd.cox.net. [68.111.223.48]) by smtp.gmail.com with ESMTPSA id q20sm9908719pgn.39.2016.12.02.14.03.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 02 Dec 2016 14:03:45 -0800 (PST) From: Bjorn Andersson To: Ohad Ben-Cohen , Bjorn Andersson Cc: linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: [PATCH v2 4/4] rpmsg: smd: Register rpmsg user space interface for edges Date: Fri, 2 Dec 2016 14:03:37 -0800 Message-Id: <1480716217-23303-4-git-send-email-bjorn.andersson@linaro.org> X-Mailer: git-send-email 2.5.0 In-Reply-To: <1480716217-23303-1-git-send-email-bjorn.andersson@linaro.org> References: <1480716217-23303-1-git-send-email-bjorn.andersson@linaro.org> Sender: linux-remoteproc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Create and register a rpmsg device for use with the rpmsg user space interface, allowing user space to access SMD channels. Also provide the "rpmsg_name" device attribute to expose the edge name in sysfs, allowing the user to write udev rules for specific rpmsg devices and their children. Signed-off-by: Bjorn Andersson --- Changes since v1: - Moved rpmsg_name attribute to different patch drivers/rpmsg/qcom_smd.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/drivers/rpmsg/qcom_smd.c b/drivers/rpmsg/qcom_smd.c index 52c4ec570464..7552ef0e82ba 100644 --- a/drivers/rpmsg/qcom_smd.c +++ b/drivers/rpmsg/qcom_smd.c @@ -1002,6 +1002,20 @@ static int qcom_smd_create_device(struct qcom_smd_channel *channel) return rpmsg_register_device(rpdev); } +static int qcom_smd_create_chrdev(struct qcom_smd_edge *edge) +{ + struct qcom_smd_device *qsdev; + + qsdev = kzalloc(sizeof(*qsdev), GFP_KERNEL); + if (!qsdev) + return -ENOMEM; + + qsdev->edge = edge; + qsdev->rpdev.ops = &qcom_smd_device_ops; + qsdev->rpdev.dev.parent = &edge->dev; + return rpmsg_chrdev_register_device(&qsdev->rpdev); +} + /* * Allocate the qcom_smd_channel object for a newly found smd channel, * retrieving and validating the smem items involved. @@ -1357,6 +1371,12 @@ struct qcom_smd_edge *qcom_smd_register_edge(struct device *parent, goto unregister_dev; } + ret = qcom_smd_create_chrdev(edge); + if (ret) { + dev_err(&edge->dev, "failed to register chrdev for edge\n"); + goto unregister_dev; + } + schedule_work(&edge->scan_work); return edge;