| Message ID | 1481804490-8583-8-git-send-email-akdwived@codeaurora.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On 12/15, Avaneesh Kumar Dwivedi wrote: > Add support to use reset control framework for resetting MSS > with hexagon v56 1.5.0. > > Signed-off-by: Avaneesh Kumar Dwivedi <akdwived@codeaurora.org> > Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> > --- Applied to clk-next. I take it the dts part won't be landing in v4.11 so no need to make a special branch for this new define.
On Wed, Dec 28, 2016 at 03:40:16PM -0800, Stephen Boyd wrote: > On 12/15, Avaneesh Kumar Dwivedi wrote: > > Add support to use reset control framework for resetting MSS > > with hexagon v56 1.5.0. > > > > Signed-off-by: Avaneesh Kumar Dwivedi <akdwived@codeaurora.org> > > Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> > > --- > > Applied to clk-next. I take it the dts part won't be landing in > v4.11 so no need to make a special branch for this new define. I'd prefer to avoid this by using the hard coded values instead of #defines until the pieces are in place. So any DT changes sent during that time period will not be accepted if they use the #define, or I will munge them myself. Regards, Andy -- To unsubscribe from this list: send the line "unsubscribe linux-remoteproc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu 29 Dec 09:09 PST 2016, Andy Gross wrote: > On Wed, Dec 28, 2016 at 03:40:16PM -0800, Stephen Boyd wrote: > > On 12/15, Avaneesh Kumar Dwivedi wrote: > > > Add support to use reset control framework for resetting MSS > > > with hexagon v56 1.5.0. > > > > > > Signed-off-by: Avaneesh Kumar Dwivedi <akdwived@codeaurora.org> > > > Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> > > > --- > > > > Applied to clk-next. I take it the dts part won't be landing in > > v4.11 so no need to make a special branch for this new define. > > I'd prefer to avoid this by using the hard coded values instead of #defines > until the pieces are in place. So any DT changes sent during that time period > will not be accepted if they use the #define, or I will munge them myself. > In testing of the Hexagon PIL on "real" hardware we ran into PBL error -284098560, so we will need to get the SCM calls for assigning memory permissions (SCM_SVC_MP/MEM_PROT_ASSIGN_ID) to move forward with the 8996 PIL. In addition to this we also need a few more gcc clocks and working rpmcc on 8996 (i.e. GLINK). So we don't have to worry about this define in v4.11. Thanks for picking up the patch Stephen. Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-remoteproc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/clk/qcom/gcc-msm8996.c b/drivers/clk/qcom/gcc-msm8996.c index fe03e6f..fd4bf6f 100644 --- a/drivers/clk/qcom/gcc-msm8996.c +++ b/drivers/clk/qcom/gcc-msm8996.c @@ -3423,6 +3423,7 @@ enum { [GCC_MSMPU_BCR] = { 0x8d000 }, [GCC_MSS_Q6_BCR] = { 0x8e000 }, [GCC_QREFS_VBG_CAL_BCR] = { 0x88020 }, + [GCC_MSS_RESTART] = { 0x8f008 }, }; static const struct regmap_config gcc_msm8996_regmap_config = { diff --git a/include/dt-bindings/clock/qcom,gcc-msm8996.h b/include/dt-bindings/clock/qcom,gcc-msm8996.h index 1828723..1f5c422 100644 --- a/include/dt-bindings/clock/qcom,gcc-msm8996.h +++ b/include/dt-bindings/clock/qcom,gcc-msm8996.h @@ -339,6 +339,7 @@ #define GCC_PCIE_PHY_COM_NOCSR_BCR 102 #define GCC_USB3_PHY_BCR 103 #define GCC_USB3PHY_PHY_BCR 104 +#define GCC_MSS_RESTART 105 /* Indexes for GDSCs */